IETF Logo Mail Archive

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

"Joe Clarke (jclarke)" <jclarke@cisco.com> Fri, 10 July 2020 22:15 UTC

Return-Path: <jclarke@cisco.com>
X-Original-To: opsawg@ietfa.amsl.com
Delivered-To: opsawg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 113B53A0B18; Fri, 10 Jul 2020 15:15:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.598
X-Spam-Level:
X-Spam-Status: No, score=-9.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=K5g4VYq6; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=TAKsLLK6
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gF8VP5mKVJoq; Fri, 10 Jul 2020 15:15:12 -0700 (PDT)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4A6A43A08B0; Fri, 10 Jul 2020 15:15:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1964; q=dns/txt; s=iport; t=1594419312; x=1595628912; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Enc+/aDdTX1vfZ3qp055BOtBy+m+C+PlIitOvzDeQCc=; b=K5g4VYq6daY3mldkoMXhoplDq8nylOLqh/D01HQq+HV3dHpvGIuFJqbf YskzIHpS35Q1nnF2aVERRJS0Fhym/nKFPfE0ch8oXGKuLWt5AeSBRHx+D 6jXQWBzBrym+j2cpO1sAGP/KbMZv/Ff5LiPQ1/s1hG4CxozvraVYbLsqL 4=;
IronPort-PHdr: 9a23:pCfgrh2xs7X4sHpZsmDT+zVfbzU7u7jyIg8e44YmjLQLaKm44pD+JxWGuadmjUTCWsPQ7PcXw+bVsqW1X2sG7N7BtX0Za5VDWlcDjtlehA0vBsOJSCiZZP7nZiA3BoJOAVli+XzoOklOE8G4bFrX8TW+6DcIEUD5Mgx4bu3+Bo/ViZGx0Oa/s53eaglFnnyze7R3eR63tg7W8MIRhNhv
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0C1AAD75whf/4kNJK1gGgEBAQEBAQEBAQEDAQEBARIBAQEBAgIBAQEBQIFKgVJRB4FHLxcVCoQpg0YDjU6YXYFCgREDVQsBAQEMAQEtAgQBAYRNAheBfwIkOBMCAwEBCwEBBQEBAQIBBgRthS4BLAyFbwEBAQECARIREQwBATcBBAsCAQgYAgImAgICMBUQAQEEDgUigwSCTAMOIAGebgKBOYhhdoEygwEBAQWFNRiCDgmBDioBgmmDVIYzGoFBP4E4HIJNPoQIARIBIAGDFjOCLZJAolsKgl2ZVQMdgnOJNI1chSOtAYNSAgQCBAUCDgEBBYFqI2dwcBVlAYI+PhIXAg2BGQWNAINxilZ0NwIGAQcBAQMJfI1pAYEQAQE
X-IronPort-AV: E=Sophos;i="5.75,336,1589241600"; d="scan'208";a="706017649"
Received: from alln-core-4.cisco.com ([173.36.13.137]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 10 Jul 2020 22:15:09 +0000
Received: from XCH-RCD-003.cisco.com (xch-rcd-003.cisco.com [173.37.102.13]) by alln-core-4.cisco.com (8.15.2/8.15.2) with ESMTPS id 06AMF1RP021288 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 10 Jul 2020 22:15:07 GMT
Received: from xhs-rcd-002.cisco.com (173.37.227.247) by XCH-RCD-003.cisco.com (173.37.102.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 10 Jul 2020 17:15:01 -0500
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 10 Jul 2020 17:15:01 -0500
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 10 Jul 2020 18:15:00 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eiUjw9D3c+LjPoIBqn6e2jsqhOZt6ixnOmoLuOBMC1VPFEXdDZp1pzKZHN3KYlawjTKsqb/1a8KoNq+Nq+oBP0DQpp4RloSWlgr7EbmLH/znZqkA9sL2DFZQBBajl3HrNHrDPldX8qcGVSEhAvenKE0mor8XQxbi1JfbuNYrms7npvNv3rF3Q5xqFJa8QjABMZ2J+HvAsh/EDHwBbIIz1efhybV7qphp1axHMGurxkcSO3gr8xddO2FqlUkwOFlEZSLdoAPCZ+tu25DUSO/27FFgc+n3liZ/F998APqj1YpyCmgOl4KJhJgEWgG6Z902jSvXmOwMdOUBOSBX4f0P4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Enc+/aDdTX1vfZ3qp055BOtBy+m+C+PlIitOvzDeQCc=; b=MfJgznuGF10a6Z/NfiauHfqe07vN8PRqYix6BQfGRRufNrc3MJnX7Ci7K4ItxXLHaKwf5KPtlhgv5s54t7UiFw/m8BwtuaFJl9gXycVjH4fEST6cty6Ly4WTGL8NbeJsVu0Zn1ot79vQgc6UAuYoaD6BzTCtIPh9M+PRRNnX1RPuBITzsHiaLtWMlA0/6PVBEJleTpd0qFbBDu1ym8KGG5V4waZClC4mFRgRt2UI52tX2vcyRS6Z7UcnBigkSNTWBu+cfBGpRXxzburAfXW2wIv9pqy01xM5//7zpgiB/MZCKXScvTDHmI8UJFWLJOupHtc4U87TAnLwNpC3CNRBAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Enc+/aDdTX1vfZ3qp055BOtBy+m+C+PlIitOvzDeQCc=; b=TAKsLLK6Agl4w19XSeLeNaNLfkc6fiPIklMTyuXavSi6kNegjyrbxW2j3cacFZ2png3zP9X7K6rkfqi9cAz+uEk3jOm+Mpy7Z+x9BKH/RvDn6RH28pVpxJX1osBLcmm2Y3KBzW6cbRFMn90kc7Xk4/BXdNkvgb9FUnE33NAiEjI=
Received: from BN6PR11MB1667.namprd11.prod.outlook.com (2603:10b6:405:e::12) by BN6PR11MB1300.namprd11.prod.outlook.com (2603:10b6:404:3c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Fri, 10 Jul 2020 22:15:00 +0000
Received: from BN6PR11MB1667.namprd11.prod.outlook.com ([fe80::2949:27ee:578f:1a83]) by BN6PR11MB1667.namprd11.prod.outlook.com ([fe80::2949:27ee:578f:1a83%3]) with mapi id 15.20.3174.022; Fri, 10 Jul 2020 22:15:00 +0000
From: "Joe Clarke (jclarke)" <jclarke@cisco.com>
To: "Rob Wilton (rwilton)" <rwilton@cisco.com>
CC: "draft-ietf-opsawg-tacacs-yang.all@ietf.org" <draft-ietf-opsawg-tacacs-yang.all@ietf.org>, opsawg <opsawg@ietf.org>
Thread-Topic: AD review of draft-ietf-opsawg-tacacs-yang-07
Thread-Index: AdZW2lnspRS1VWiiT9qRjIzfKMZsMAALTK6A
Date: Fri, 10 Jul 2020 22:14:59 +0000
Message-ID: <F4203B1C-825F-43FB-BDC4-2DBDB7E74B31@cisco.com>
References: <MN2PR11MB436612630CAFCACF3A89BD56B5650@MN2PR11MB4366.namprd11.prod.outlook.com>
In-Reply-To: <MN2PR11MB436612630CAFCACF3A89BD56B5650@MN2PR11MB4366.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3608.80.23.2.2)
authentication-results: cisco.com; dkim=none (message not signed) header.d=none;cisco.com; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [173.38.117.80]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7c075ffb-b3f0-4aef-13a4-08d8251eafc0
x-ms-traffictypediagnostic: BN6PR11MB1300:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BN6PR11MB1300229DFE484E68C466B319B8650@BN6PR11MB1300.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 9Y2XsVnTwA99haMoQhVNbmCa7ySi5nmcXub4SPcWkdIFs/IcMtCgTnCKbD6adJDgFoaKOzSije606UsN/lRpregcL/d8Gq5YOw7hwrSd6SslI1b082hXEwEq1l8BCTwpUoRZZYDNBwxLAtfmNSbPklrZwjkCIedxplKsrywL0J6NPeqCSghU3p+fIdsGu/4+IHw+6IqZTMzcSnUnizv9ClCl2V7GBeIdNxMDSxtXGyQt1k7ic+U0gzMJO0swMhR5785SWWbrte1ykvHILdJC3ByikuulDdyLyJ9QsgUUQ71DD3qwONk9miG7+/3Q0SjtAg3rxsHQsm6H/Jgmp8XN5Q==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1667.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(366004)(39860400002)(376002)(346002)(136003)(36756003)(8936002)(186003)(91956017)(53546011)(71200400001)(6506007)(26005)(6862004)(4326008)(316002)(5660300002)(54906003)(6512007)(2616005)(86362001)(8676002)(66946007)(37006003)(64756008)(66446008)(33656002)(83380400001)(6636002)(450100002)(2906002)(478600001)(6486002)(76116006)(66476007)(66556008); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: gsK2uU0FXjDnNu+wVTm8cgTZuaGlcCNfAnSmOE86TqEzEmxBTmfEshso4RkLXI8AGXfybMBCZwKF2psByMSUOIkTFF9rh/nxk2bO8IU3+bRW7b/iHdmcjhaQDc3FB7je7lnxxyEdzELUSYfKaxztF8NgA41MR/u6uobTxncKsLfYVnDNqFSUgP2m+/AJseu6sQBoiDXjkoGKRxg1tDv5FT/zTfApkPR1m1yCNMaYACYjUPVc1ND4lheMWB2f0P3cyrfIxyqSY1GU9S55tcVXPR6/jXHlW6TiyK2/eOWd3S9xZdLytN879EwjuHJciuWQaD3GOIH+1ja8rIZJvjW4tQsv2QiBUpzV9Ik2Gg2mMYbjFFCzDL+qP7MXi/d4jDRJRFTfRFCFlrRAjW6QrAarTV5dNknQe4kxlxpT1eCG7gydHLTxf3mcZJf9UaoGN8joEwFmd4Pg2vGJ1rgh0yRDp+sdFyLbCAx1sUmi87/gmJN3dA2H4ODSXf/DrfP4t/Zi
Content-Type: text/plain; charset="utf-8"
Content-ID: <FCFC3F17A13CF54F8414C5F586DF7608@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1667.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c075ffb-b3f0-4aef-13a4-08d8251eafc0
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2020 22:14:59.9383 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: e7umdc7Vec4ohKVej6VmUG8SB6WCHtz3JbOOh7h41g/Un8yJURrV5OhZrC0HFysD2L0tPapDWFTgWWvaknivFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1300
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.13, xch-rcd-003.cisco.com
X-Outbound-Node: alln-core-4.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/opsawg/-xV6RE_Z0aKxYCg7_daxNsZ0jzo>
Subject: Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07
X-BeenThere: opsawg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OPSA Working Group Mail List <opsawg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/opsawg>, <mailto:opsawg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/opsawg/>
List-Post: <mailto:opsawg@ietf.org>
List-Help: <mailto:opsawg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/opsawg>, <mailto:opsawg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jul 2020 22:15:14 -0000

Thanks, Rob.  Maybe it’s just me, but your email is truncated as you can see below.  I also didn’t see any attachment.

Joe

> On Jul 10, 2020, at 12:52, Rob Wilton (rwilton) <rwilton@cisco.com> wrote:
> 
> Apologies for the delay, but please find my AD review of the TACACS+ YANG module draft.
> 
> I would like to thank the authors for their work on this document, and the WG for providing reviews and input in this document.
> 
> I believe that the document is in good shape but propose some minor changes to some of the wording in places.
> 
> One particular question that I would like to pull to the top is the naming of the module and identifiers:
> These generally use "tacacsplus", but I think that "tacacs-plus" might be better and more readable.
> 
> 
> Full comments are inline in the document below (marked as #)
> 
> 
>   The YANG model can be used with network management protocols such as
>   NETCONF[RFC6241] to install, manipulate, and delete the configuration
>   of network devices.
> 
>    Abstract
> 
>       This document defines a YANG module that augment the System      
>       Management data model defined in the RFC 7317 with TACACS+ client
>       model.  The data model of Terminal Access Controller Access Control
>       System Plus (TACACS+) client allows the configuration of TACACS+
>       servers for centralized Authentication, Authorization and Accounting

v2.23.0 | Report a Bug | By Email