Re: [OPSAWG] Lars Eggert's No Objection on draft-ietf-opsawg-l3sm-l3nm-11: (with COMMENT)

mohamed.boucadair@orange.com Wed, 22 September 2021 10:18 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: opsawg@ietfa.amsl.com
Delivered-To: opsawg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 918163A1486; Wed, 22 Sep 2021 03:18:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=orange.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RiZiMnYvJQ7z; Wed, 22 Sep 2021 03:18:52 -0700 (PDT)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.66.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 458A83A1484; Wed, 22 Sep 2021 03:18:52 -0700 (PDT)
Received: from opfedar01.francetelecom.fr (unknown [xx.xx.xx.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by opfedar22.francetelecom.fr (ESMTP service) with ESMTPS id 4HDvQf3CZpz2xsT; Wed, 22 Sep 2021 12:18:50 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.com; s=ORANGE001; t=1632305930; bh=A5woKJ4sIfvS+reC9dFsAKO1TDT/MqXkhytJxfYCUI8=; h=From:To:Subject:Date:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; b=dplVpBCTq96vJmi0FPwabS+vl6A3v+wV11RfJd04kIARLCcY04B5rnYTaeXY54Se9 NOmk/LmPQj35Y0wkxOl8PYFzvsyVh4/MWVuBZlSYkagPLg+FFyA23xfunt8vuNb5vy tbbI8sU4ipQAx/SY0W0gYEjEm5cOokl6WdseXmDZH79O/VqzrccEvYrfGKHZ0psece 7Wt7pS5ZGObpQxh917WUyCLPoK5tC/3wG14HLUwxATd/CG9x2xvb1i86KtxJp+rK2R BPt3hDB4ujujYErGou5WWIfa4uVGoz9/eESaIqgD8XY3rlgehB2wfESRmQsGkRE5fR b1rKRMPZJeVnQ==
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by opfedar01.francetelecom.fr (ESMTP service) with ESMTPS id 4HDvQf1kS2zBrLQ; Wed, 22 Sep 2021 12:18:50 +0200 (CEST)
From: mohamed.boucadair@orange.com
To: Lars Eggert <lars@eggert.org>, The IESG <iesg@ietf.org>
CC: "draft-ietf-opsawg-l3sm-l3nm@ietf.org" <draft-ietf-opsawg-l3sm-l3nm@ietf.org>, "opsawg-chairs@ietf.org" <opsawg-chairs@ietf.org>, "opsawg@ietf.org" <opsawg@ietf.org>, "adrian@olddog.co.uk" <adrian@olddog.co.uk>
Thread-Topic: Lars Eggert's No Objection on draft-ietf-opsawg-l3sm-l3nm-11: (with COMMENT)
Thread-Index: AQHXrhyFYZDT4F1TkEeu3jU8qiJljquv2SJQ
Date: Wed, 22 Sep 2021 10:18:48 +0000
Message-ID: <13692_1632305930_614B030A_13692_477_1_787AE7BB302AE849A7480A190F8B93303540A746@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
References: <163214155151.13914.14609813774678560196@ietfa.amsl.com>
In-Reply-To: <163214155151.13914.14609813774678560196@ietfa.amsl.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.114.13.247]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/opsawg/3iVMoGAP9VZlTTXKVVbxYJraTcE>
Subject: Re: [OPSAWG] Lars Eggert's No Objection on draft-ietf-opsawg-l3sm-l3nm-11: (with COMMENT)
X-BeenThere: opsawg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OPSA Working Group Mail List <opsawg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/opsawg>, <mailto:opsawg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/opsawg/>
List-Post: <mailto:opsawg@ietf.org>
List-Help: <mailto:opsawg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/opsawg>, <mailto:opsawg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Sep 2021 10:18:58 -0000

Hi Lars, 

Thank you for the review. 

Please see inline. 

Cheers,
Med

> -----Message d'origine-----
> De : Lars Eggert via Datatracker [mailto:noreply@ietf.org]
> Envoyé : lundi 20 septembre 2021 14:39
> À : The IESG <iesg@ietf.org>
> Cc : draft-ietf-opsawg-l3sm-l3nm@ietf.org; opsawg-chairs@ietf.org;
> opsawg@ietf.org; adrian@olddog.co.uk; adrian@olddog.co.uk
> Objet : Lars Eggert's No Objection on draft-ietf-opsawg-l3sm-l3nm-11:
> (with COMMENT)
> 
> Lars Eggert has entered the following ballot position for
> draft-ietf-opsawg-l3sm-l3nm-11: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-
> criteria.html
> for more information about DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-opsawg-l3sm-l3nm/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> It would be useful to summarize this document's relationship to RFC8299
> in the abstract.

[[Med]] Sure. Made this change to the github copy: 

OLD:
   This document defines an L3VPN Network YANG Model (L3NM) that can be
   used for the provisioning of Layer 3 Virtual Private Network (VPN)
   services within a service provider network.  The model provides a
   network-centric view of L3VPN services.

NEW:
   As a complement to the Layer 3 Virtual Private Network Service YANG
   data Model (L3SM), used for communication between customers and
   service providers, this document defines an L3VPN Network YANG Model
   (L3NM) that can be used for the provisioning of Layer 3 Virtual
   Private Network (VPN) services within a service provider network.
   The model provides a network-centric view of L3VPN services.

> 
> ------------------------------------------------------------------------
> -------
> All comments below are about very minor potential issues that you may
> choose to address in some way - or ignore - as you see fit. Some were
> flagged by automated tools (via https://github.com/larseggert/ietf-
> reviewtool), so there will likely be some false positives. There is no
> need to let me know what you did with these suggestions.

[[Med]] Considered most of the proposals below. We kept "key chain" to align with the usage in RFC8177. 

All the changes can be seen at: https://github.com/IETF-OPSAWG-WG/lxnm/blob/master/I-D-L3NM/draft-ietf-opsawg-l3sm-l3nm.txt 


> 
> Section 7.6.3. , paragraph 43, nit:
> > icates which BFD flavor is used to setup the session (e.g., classic
> BFD [RFC
> >                                    ^^^^^
> The verb "set up" is spelled as two words. The noun "setup" is spelled
> as one.
> 
> Section 7.7. , paragraph 1, nit:
> > y applicable if both RP redundancy and and delivery through optimal
> path are
> >                                    ^^^^^^^
> Possible typo: you repeated a word.
> 
> Section 8. , paragraph 8, nit:
> >  VPLS and, VXLAN. Other values may defined, if needed."; leaf type {
> type ide
> >                                    ^^^^^^^
> The modal verb "may" requires the verb's base form.
> 
> Section 8. , paragraph 32, nit:
> > cription "Reference to the TCP-AO key chain."; reference "RFC 8177:
> YANG Key
> >                                   ^^^^^^^^^
> This word is normally spelled as one.
> 
> Section 8. , paragraph 32, nit:
> > description "Reference to the MD5 key chain."; reference "RFC 8177:
> YANG Key
> >                                   ^^^^^^^^^
> This word is normally spelled as one.
> 
> Section 8. , paragraph 32, nit:
> > f; description "Customer-supplied key chain."; } } } } } container
> service {
> >                                   ^^^^^^^^^
> This word is normally spelled as one.
> 
> Section 8. , paragraph 32, nit:
> > cast static source/group associated to to IGMP session"; leaf group-
> addr { ty
> >                                     ^^^^^
> Possible typo: you repeated a word.
> 
> Document references draft-ietf-opsawg-vpn-common-09, but -10 is the
> latest available revision.
> 
> Obsolete reference to RFC4447, obsoleted by RFC8077 (this may be on
> purpose).
> 
> These URLs point to tools.ietf.org, which is being deprecated:
>  * http://tools.ietf.org/wg/opsawg/
> 
> 


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.