Re: [OPSAWG] Review of draft-arokiarajseda-ipfix-data-export-yang-model
"Arokiaraj, Anand (Nokia - IN/Chennai)" <anand.arokiaraj@nokia.com> Mon, 02 May 2022 20:06 UTC
Return-Path: <anand.arokiaraj@nokia.com>
X-Original-To: opsawg@ietfa.amsl.com
Delivered-To: opsawg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DAC57C14F75F for <opsawg@ietfa.amsl.com>; Mon, 2 May 2022 13:06:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.473
X-Spam-Level:
X-Spam-Status: No, score=-2.473 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.575, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YICUnJsM5tSl for <opsawg@ietfa.amsl.com>; Mon, 2 May 2022 13:06:28 -0700 (PDT)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2105.outbound.protection.outlook.com [40.107.22.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B0020C14F73D for <opsawg@ietf.org>; Mon, 2 May 2022 13:06:27 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aRe+np84Ypfdr/nQt/ZVuqVX0kHIXhFfBHn3kg6C+vLr7/qUX0euY5qVJ7r7VdCaZTI2LFR27FBlXR+K4ntfYzL3qs8CiVQFB5bNnXuQVjJWzeLVOAAeG7Mxmw5w1/T7Nkfhqsm3pdlao5vUUR5VabU9SqpJptr0hpZgGUk8B+hGKCjF2/96OVfFzdkVxspd3jqPLpV3n5X87RYY0CzE6x67eK5CSkiHkOAPKgR/2FE6gp4SvCQOPVglY+RqNTZ4T8oqErhsGsU/vmjX18itCshqsx94P+Qf0e1p/NNpyr38ppXGY3pzgUsVheewmPzfOkdV3qWRaDQ7R0ApexfS5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zkSdY4V84AGLDpn3958yLmgVmrphhkPZkqr+YTyRZqo=; b=P+mo1USajpIzaBHm+GD1dU9yWVwu3UZKcMCnExr7DfXL4crOI3FVN0jznUH66Zb8x5caC5GfMw7yfK+V7qMVOPX10XjpCtdfRqZYcSHzAzBGRCEc3ZwCjT0qN20mO3nJuW5ukbcpVIdgZABk8ztvMOCk2kPxyHBKpcIs6ynSdbe2jsAnbZCNgpQxlQcCIks0Vn8rbQRg83IVcolEOrUiCL6fK5zkOiRn7yN27nlCe8UFl4QHinOzrR9l/18hfNWros5qsSHpjflYqrRHWR4deq6JBfS8dEDE2/0kdbXB+A/86cKpgye02Kw4KOglLjxnZRWc4zaOanObTL/IGhmVPg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zkSdY4V84AGLDpn3958yLmgVmrphhkPZkqr+YTyRZqo=; b=G4pV/9RMclnQomNr+BiX3iVug9ZFKO4sPZduPfcQ/i8V65/ApFr1OeUe1UqPOjwbMGVTZGWoDdamU0XRvd0+VXI7UWV1jmRmEYLSfAQTjjK3XoqENxf08I+DKO3Vb/HftQ8zJnaMT/5QxfbC5Q6yQINR29m2GZ9Ar52zA1RWyyA=
Received: from DU2PR07MB8271.eurprd07.prod.outlook.com (2603:10a6:10:278::14) by AM0PR07MB4596.eurprd07.prod.outlook.com (2603:10a6:208:79::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Mon, 2 May 2022 20:06:23 +0000
Received: from DU2PR07MB8271.eurprd07.prod.outlook.com ([fe80::7daf:b65c:dfc1:3d97]) by DU2PR07MB8271.eurprd07.prod.outlook.com ([fe80::7daf:b65c:dfc1:3d97%5]) with mapi id 15.20.5206.024; Mon, 2 May 2022 20:06:23 +0000
From: "Arokiaraj, Anand (Nokia - IN/Chennai)" <anand.arokiaraj@nokia.com>
To: "Joe Clarke (jclarke)" <jclarke@cisco.com>, "opsawg@ietf.org" <opsawg@ietf.org>
Thread-Topic: Review of draft-arokiarajseda-ipfix-data-export-yang-model
Thread-Index: AQHYSP5rjt9iAUSHMEa22JdmMc33Xa0MLZxQ
Date: Mon, 02 May 2022 20:06:22 +0000
Message-ID: <DU2PR07MB8271406AFEFEA35CA5DBFF66FBC19@DU2PR07MB8271.eurprd07.prod.outlook.com>
References: <BN9PR11MB5371E07FE28FEC7B354BB40FB8E49@BN9PR11MB5371.namprd11.prod.outlook.com> <DU2PR07MB8271BD3EEB46765303B0B362FBEA9@DU2PR07MB8271.eurprd07.prod.outlook.com> <BN9PR11MB5371A715FD60C457009EB341B8EA9@BN9PR11MB5371.namprd11.prod.outlook.com> <DU2PR07MB8271FE0CA0090EF0028BBB88FBFE9@DU2PR07MB8271.eurprd07.prod.outlook.com> <BN9PR11MB5371D4E3CCC5FEF3B2D14683B8C19@BN9PR11MB5371.namprd11.prod.outlook.com>
In-Reply-To: <BN9PR11MB5371D4E3CCC5FEF3B2D14683B8C19@BN9PR11MB5371.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2e438bc6-a80e-43d0-6593-08da2c773b09
x-ms-traffictypediagnostic: AM0PR07MB4596:EE_
x-microsoft-antispam-prvs: <AM0PR07MB45960DBE6FFD173A62F8DBACFBC19@AM0PR07MB4596.eurprd07.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 083+4m0FeWnvHG8Kmg5QpXe8CJ0WdPuxEIktxqJ2kk8tupyiF/5k5LBQhdNRjFsga/CdJnPdRpJbdbA0zUsOsKPPOJy953D4lHXOaCfI7DgDetrs3N97RMoOdd2VnQ9RZJrQepNbhuPq+Ms88oPU3PKWpwUx6j+d20hyRHW510xSyj7RmO8N1Ttx1YT4sO7w6YJux4Awf2kxYY+FcedHCjl6cjCezpKcQqxQzL+wxOoISv9MLRQXyZOOwFJj4m/ufRHP11n4DYHi+cN0ldmDGvsBpBISWSnlKMVR9ZAqMrHWsVsjQPcmNxRjfoQ1NL/Z8jLyu458dXuJgYd1NNdzdLRgRV+WhoDWSBLL4+tcWUc3wd0OTnshwKB6Q/qF6fD2mpelilUDMVAIU/idJvm+dIvbPO8Vu7iqGH6RVpO6MYjFrlAEythPvZQPsD0NBjEta9C21ZqcGEEYnjpNM7go+VDV8aRVjqhfTanBMeWOLfCmgGKRRP+ZvbnYeeIEsnatMDtNjRs2OZcDerNq02yMo8Wy+NFRy0F2vKwKBFCVSTu98aNAyf2dBqUmp9hLqJN4kyzQKEpGqtSCgL9jja1nXZCRHqM9sXmNBz77klXCU81KCupWNY1rfhkbQndzC2UEy1XLuOjBUGPj3gl+4f6w6cXyBs27gu3wXEXv9qgDatBIBI3GAU4dy3wOTCdIJNOEAzo74XYOV2We2FjoJA2lEOKae3MxwmIRXAOQV/W2/pqUKAdENBsc/lcp6z6Wf8XxhuM87Vlxq40FxR2wplE97n4Idviz6tO2u9Jzj13SlCRFZzabeTMucq5kLiBkjmOMt+nGIlyDed0NlkrgPWE62g==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR07MB8271.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(26005)(7696005)(9686003)(83380400001)(71200400001)(186003)(6506007)(5660300002)(52536014)(8936002)(33656002)(110136005)(2906002)(82960400001)(64756008)(66946007)(66556008)(66446008)(8676002)(316002)(66476007)(55016003)(53546011)(966005)(38100700002)(38070700005)(86362001)(122000001)(76116006)(166002); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: E/oNuOMFIcWWPNX7sRGsaEjblsxytK1WlKmKuIItdIJqkIXzmqKryYJgu2oHdTwPDWc0jtAQDEHICg5Oy6TcRnoyW3QCHBu4+rcGyMZ58qAODqFG0pZxTZb2XbYjnZ7jl2OXHk52WWyZ2dVlJnXrexfaSxL8oiHP30BaP/w8/qZ59oL4mJthQuy3QvuTOPhIfZ27mz50/uEdYAQtciPvbxD2GOTa6AaJz/Xh0C0juQT2liWcTHVwUAiN+xnTduH++793nUGW3rOi/+5DMFXvNUDAJEYuT6ABlcp+2TcyzytFhzkuNX7kkhpwrDeMVXQIlSr3KQWpS+ee81z3PcrpklsjZyggqH/l7YO0ppRB58I5ZoUuhwVFBi3TrtRqXrxGFprOChvAuq65Nj/+ALHVBtUFzkyp2AnP6ugCJOv8LuzMMfbLD88ymVKbNRvShk1csrVm9Uox51AYXdCesGcMq+vflescxxGcG+h664SXKZMoiZ16Y/unrFGAo2eszfxOp4zxDtbJWOvcjLHlBFq6uVl8ZCwl//xxPk0bXIrhdnOPdz/Dm7x6DxwToAWID9LC0qlTJw5xBhwBeTHiQ4yja4KQUUfTajaWE3MeFCGhdG7SlXhiqMjl37Erh3Go9JCPz89ME/gyMbQcPlatr8n9MlJcymwjRWxNMA3fpLeIfv3EbFnpKGVxTD7lZk6+JTsjQiLDChJ7HEvjauc2Bjm2tC5ysUUnxML0WQQ4o+ykDeOPFrzZe/BXECeiMrOpkdAsoIq+cIPZdK4xV7NbzV8pFU6Z5+TKP0n7rchJNx+juPt4/5ktv7R6irnYN6tGPRZoVvntM0DCGofxTmTyKxNTpoJY+K+JwN97b0WMLJHFVmDRvSdpHJ8H+Oog37Xt4U3ruunj3/GM8hItEPdOI3aBDOh2h9KSbfTCKMO7i/wvi6XroUrLYizKSDfBU/Ux9a9535Fp7j9XMDovwcQACeM1LBdCZufQa27gN02Jnt6bFhpe3DapWHuiVS2UdpQBi2y5X17y5OwMZJBy6nxhMUvNC59oWH10LWM4iMpidmzJUpioRgFXKXVrf8BGJAD2z//HykokllkN4BIHvEqz3AmMCaFCjDc1fvmOqQvFry3zE/TUEJg+obUbG2Vxj8u5I/7yB+exfQPM1cXtmlZZW3pgDaYDNa8zId9wN6GGn2wiT5SUw97QCp42Gs1hphYcEh8qvYzx6WiAb3fGnxMT4FaUSONEzs+d9NsoGEq4fwUwDEwoAf9ROhXUHfvzqv7otGhDx6U/Rx+rhQ8pf1gN4zEBl25S6lfGMrCtI9sV7uNt5Psqt8QUl1bSZOUybfngoezlE6xrCWMvEIeZQQGVmZLL5cC1kGPNU12Oq15CclF6+EPuTE7HQQbtWP1sckCAGfSVbfN9ZF29v5XypiSLl3+alH/8HHyc0ObeSzR/O3GmlnW+tj9ZC2ttZZ+2Ukgt003hvhTgrCI81j00RcOCJVDySVXQI0XhkSjOJJf6gOf/CBNTu1nlUzhjMA6GsunaNKs5cEkDKrghVzfzccWUrTIdfHzt7rIv2yd3vcqGfu0lMteut6P2i62qQU1HddbD8gAZbyh5tt/7nOcoaAVx051IbGewVQWlhEBwy38l+F785PVugKj2UbtVfNhsabnclJv/0+ygwyceL+9bDFqlXbrVTEG44h7ix5ACqqjyFmQPDHXt/mvsdagpLQBZbea8cKnBLc2aPkkDtwL5mPsINlUFZAvq9aIykG2lmyE2rHqnkCY=
Content-Type: multipart/alternative; boundary="_000_DU2PR07MB8271406AFEFEA35CA5DBFF66FBC19DU2PR07MB8271eurp_"
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR07MB8271.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e438bc6-a80e-43d0-6593-08da2c773b09
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2022 20:06:22.9236 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TYHa9PDv0ZKtkdSIjqOR83PQ5GWY9D1oeC7Hd13wJvvhJjfaQTxFdyxGgzJt7ytGrrNnYW1OsN6bZqNbebNv9eFQjsCzVLdTuxlLhkrgniM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR07MB4596
Archived-At: <https://mailarchive.ietf.org/arch/msg/opsawg/RQjf2vY_O5HVpPjnbnm_M4V7LBw>
Subject: Re: [OPSAWG] Review of draft-arokiarajseda-ipfix-data-export-yang-model
X-BeenThere: opsawg@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: OPSA Working Group Mail List <opsawg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/opsawg>, <mailto:opsawg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/opsawg/>
List-Post: <mailto:opsawg@ietf.org>
List-Help: <mailto:opsawg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/opsawg>, <mailto:opsawg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 02 May 2022 20:06:31 -0000
Joe, I think you meant IPFIX and/or YANG model. We removed the SNMP MIB references and updated the RFC6728 references. Regards, Anand Arokiaraj From: Joe Clarke (jclarke) <jclarke@cisco.com> Sent: Monday, May 2, 2022 7:10 PM To: Arokiaraj, Anand (Nokia - IN/Chennai) <anand.arokiaraj@nokia.com>; opsawg@ietf.org Subject: Re: Review of draft-arokiarajseda-ipfix-data-export-yang-model You read my mind, Anand. I was coming here to remind the WG that we'd like some more comments on this. If you know IPFIX and/or SNMP please read and comment on-list. Thanks. Joe On 5/1/22 14:41, Arokiaraj, Anand (Nokia - IN/Chennai) wrote: Hi All, A new version of the draft is now available at https://www.ietf.org/archive/id/draft-arokiarajseda-ipfix-data-export-yang-model-01.txt The comments raised by Joe have been addressed and all references to IPFIX MIB have been removed. Please let us know if there are more comments. Regards, Anand Arokiaraj From: Joe Clarke (jclarke) <jclarke@cisco.com><mailto:jclarke@cisco.com> Sent: Monday, April 11, 2022 6:09 PM To: Arokiaraj, Anand (Nokia - IN/Chennai) <anand.arokiaraj@nokia.com><mailto:anand.arokiaraj@nokia.com>; opsawg@ietf.org<mailto:opsawg@ietf.org> Subject: Re: Review of draft-arokiarajseda-ipfix-data-export-yang-model Thanks for addressing these. I hope to see more WG reviews soon. Joe On 4/11/22 01:24, Arokiaraj, Anand (Nokia - IN/Chennai) wrote: Hi Joe, Thanks for your feedback! The comments show that we have not entirely come out of replacing-RFC-6728-mode. Please find our responses inline ([Anand/Marta]). In addition to this, we will also remove the references to the IPFIX MIB since they are already part of RFC 6728 and not required to be stated again here. Regards, Anand Arokiaraj From: OPSAWG <opsawg-bounces@ietf.org><mailto:opsawg-bounces@ietf.org> On Behalf Of Joe Clarke (jclarke) Sent: Tuesday, April 5, 2022 8:34 PM To: opsawg@ietf.org<mailto:opsawg@ietf.org> Subject: [OPSAWG] Review of draft-arokiarajseda-ipfix-data-export-yang-model Hello, WG. As promised (threatened?) I wanted to poke the WG to review this work. The authors have done, in my opinion, a good job of simplifying the original work down to around 16 pages of text and then the YANG module, considerations, and examples. So, PLEASE REVIEW! We'd like to do a call for adoption in the next few weeks. I figured the best way to tease out some more WG reviews was to provide one myself. Overall I just found a few readability issues plus a couple of larger questions. First, the big question. Why are you specifying your own set of TLS parameters rather than reference and use https://datatracker.ietf.org/doc/html/draft-ietf-netconf-tls-client-server-27. It seems you could leverage the groupings there and reference a certificate for export encryption. [Anand/Marta] Indeed, we could use the tls-client-grouping from the referenced draft. Second, in the YANG module, you have some patterns like \S+. Are you really that permissive? Would certain Unicode patterns work for names or do you want to be more specific in allowed characters? Maybe it is since, for example, IE names can be unicode characters (but it looks like they can have spaces). I'm also concerned about the use of max in your string lengths. Shouldn't the IE Name be limited to 65535? [Anand/Marta] Again, this is an outdated definition i realize. I think it would be best to follow the interface name and hardware component name definitions - "type string" and no explicit length restriction. As for typos and readability... Section 1: s/statisticis/statistics/ Section 2: s/logical interface/logical interfaces/ s/suffient/sufficient/ s/and IE id/and IE ID/ [Anand/Marta] Thanks for listing out the typos. Section 3.1: You refer to ExportingProcess, but the code is exporting-process. I'm not sure why the two couldn't align. Maybe in Figure 1, you want the block to be ExportingProcess? Ultimately, I'm trying to tie the text to the figure and YANG tree. [Anand/Marta]Not just exporting-process, there is a mismatch for all the class names TransportLayerSecurity/transport-layer-security, TransportSession/transport-session, Template/template, DataProcess/data-export. Will update the yang names in all the references. Joe
- [OPSAWG] Review of draft-arokiarajseda-ipfix-data… Joe Clarke (jclarke)
- Re: [OPSAWG] Review of draft-arokiarajseda-ipfix-… Arokiaraj, Anand (Nokia - IN/Chennai)
- Re: [OPSAWG] Review of draft-arokiarajseda-ipfix-… Joe Clarke (jclarke)
- Re: [OPSAWG] Review of draft-arokiarajseda-ipfix-… Arokiaraj, Anand (Nokia - IN/Chennai)
- Re: [OPSAWG] Review of draft-arokiarajseda-ipfix-… Joe Clarke (jclarke)
- Re: [OPSAWG] Review of draft-arokiarajseda-ipfix-… Arokiaraj, Anand (Nokia - IN/Chennai)
- Re: [OPSAWG] Review of draft-arokiarajseda-ipfix-… Joe Clarke (jclarke)