[OPSAWG] Review of draft-arokiarajseda-ipfix-data-export-yang-model

["Joe Clarke (jclarke)" <[e-mail]>]

Hello, WG.  As promised (threatened?) I wanted to poke the WG to review this work.  The authors have done, in my opinion, a good job of simplifying the original work down to around 16 pages of text and then the YANG module, considerations, and examples.  So, PLEASE REVIEW!

We'd like to do a call for adoption in the next few weeks.

I figured the best way to tease out some more WG reviews was to provide one myself.  Overall I just found a few readability issues plus a couple of larger questions.  First, the big question.

Why are you specifying your own set of TLS parameters rather than reference and use https://datatracker.ietf.org/doc/html/draft-ietf-netconf-tls-client-server-27.  It seems you could leverage the groupings there and reference a certificate for export encryption.

Second, in the YANG module, you have some patterns like \S+.  Are you really that permissive?  Would certain Unicode patterns work for names or do you want to be more specific in allowed characters?  Maybe it is since, for example, IE names can be unicode characters (but it looks like they can have spaces).  I'm also concerned about the use of max in your string lengths.  Shouldn't the IE Name be limited to 65535?

As for typos and readability...

Section 1:

s/statisticis/statistics/

Section 2:

s/logical interface/logical interfaces/

s/suffient/sufficient/

s/and IE id/and IE ID/

Section 3.1:

You refer to ExportingProcess, but the code is exporting-process.  I’m not sure why the two couldn’t align.  Maybe in Figure 1, you want the block to be ExportingProcess?

Ultimately, I'm trying to tie the text to the figure and YANG tree.

Joe