Re: [OPSAWG] Last Call: <draft-ietf-opsawg-l2nm-15.txt> (A YANG Network Data Model for Layer 2 VPNs) to Proposed Standard

mohamed.boucadair@orange.com Wed, 18 May 2022 10:56 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: opsawg@ietfa.amsl.com
Delivered-To: opsawg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ECB81C14F72D; Wed, 18 May 2022 03:56:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.095
X-Spam-Level:
X-Spam-Status: No, score=-2.095 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=orange.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m-w7JGd163lR; Wed, 18 May 2022 03:56:39 -0700 (PDT)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.66.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BB785C14F720; Wed, 18 May 2022 03:56:38 -0700 (PDT)
Received: from opfedar05.francetelecom.fr (unknown [xx.xx.xx.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by opfedar27.francetelecom.fr (ESMTP service) with ESMTPS id 4L390N6CDkz2y35; Wed, 18 May 2022 12:56:36 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.com; s=ORANGE001; t=1652871396; bh=E5pkykUoWobMpSSBVWbaLBfMXg6KzxU3ODXF9cnbEnY=; h=From:To:Subject:Date:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; b=OSLY7BPB88R0DDcDEagW8PxcRtRzbEbiw0eA828veghDn/fxRerUzgJ4HLOh9bY5r 4ny4Dl7xGJR38TaOYowpNiD7YktxJVAU9xuz6XKgepaNGPdN9R0h81JRajFM3JpvPT bfgDCnOj5RrwYWohFvqeh3fmt8un8MvkjZJWEK2Gw5k6naZ0mHzSBG7k1Pk8p1LDJ6 NjpnnPi0jnHADDrDVYlCe+1Yswk3h3LDKCX5SXv6OKtElocjXJzjdDE8NxSg3lVPvu qUP1ilvktXHF6qz1VW3WuNnXVNzRzKf0WlpzkHQAA1iJnHq7SCknJDs6GpIwy6R8/H cPBRfdMw3KX7w==
From: mohamed.boucadair@orange.com
To: tom petch <daedulus@btconnect.com>, "last-call@ietf.org" <last-call@ietf.org>
CC: "adrian@olddog.co.uk" <adrian@olddog.co.uk>, "opsawg@ietf.org" <opsawg@ietf.org>, "opsawg-chairs@ietf.org" <opsawg-chairs@ietf.org>, "draft-ietf-opsawg-l2nm@ietf.org" <draft-ietf-opsawg-l2nm@ietf.org>
Thread-Topic: Last Call: <draft-ietf-opsawg-l2nm-15.txt> (A YANG Network Data Model for Layer 2 VPNs) to Proposed Standard
Thread-Index: AQHYapLfpr1FnddpykiOsVLUCswuXq0kdQqw
Content-Class:
Date: Wed, 18 May 2022 10:56:36 +0000
Message-ID: <19520_1652871396_6284D0E4_19520_150_1_f2d9733bfa9a405293d2f6d055ff91bd@orange.com>
References: <165124323213.7379.13149514636739448316@ietfa.amsl.com> <6284B0D5.2080105@btconnect.com>
In-Reply-To: <6284B0D5.2080105@btconnect.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Enabled=true; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SetDate=2022-05-18T10:51:38Z; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Method=Privileged; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Name=unrestricted_parent.2; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SiteId=90c7a20a-f34b-40bf-bc48-b9253b6f5d20; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ActionId=9980fb13-a0c3-4bd1-b435-2c5b27bdabea; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ContentBits=0
x-originating-ip: [10.115.26.50]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/opsawg/YzM5jzI3zY-u5TsFTw3uqaZ6SC4>
Subject: Re: [OPSAWG] Last Call: <draft-ietf-opsawg-l2nm-15.txt> (A YANG Network Data Model for Layer 2 VPNs) to Proposed Standard
X-BeenThere: opsawg@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: OPSA Working Group Mail List <opsawg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/opsawg>, <mailto:opsawg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/opsawg/>
List-Post: <mailto:opsawg@ietf.org>
List-Help: <mailto:opsawg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/opsawg>, <mailto:opsawg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 May 2022 10:56:43 -0000

Tom, 

Please see one additional clarification inline. 

Cheers,
Med

> -----Message d'origine-----
> De : tom petch <daedulus@btconnect.com>
> Envoyé : mercredi 18 mai 2022 10:40
> À : last-call@ietf.org
> Cc : adrian@olddog.co.uk; opsawg@ietf.org; opsawg-chairs@ietf.org;
> draft-ietf-opsawg-l2nm@ietf.org
> Objet : Re: Last Call: <draft-ietf-opsawg-l2nm-15.txt> (A YANG
> Network Data Model for Layer 2 VPNs) to Proposed Standard
> 
> On 29/04/2022 15:40, The IESG wrote:
>  > The IESG has received a request from the Operations and
> Management Area  > Working Group WG (opsawg) to consider the
> following document: - 'A YANG  > Network Data Model for Layer 2
> VPNs'
>  >    <draft-ietf-opsawg-l2nm-15.txt> as Proposed Standard
> 
...
> s.7.5.2 has
>    +--rw (signaling-option)?              choice
>        |     +--:(bgp)                            case
>        |     |  ...                                choice bgp-type
>        |     +--:(ldp-or-l2tp)                    case
> 
> so I expect to see
>   choice signaling-option   which I do on page 87
>   case bgp                  also on page 87
>   ....
>   case ldp-or-l2tp          nowhere to be seen.
> In fact, there is no case, rather there is a container with that
> identifier on page 93.  This is valid  YANG - a container can
> stand in
> for a case - but with six pages of YANG in-between, this is hard
> to
> follow.  I would suggest /container/case/ or if there is a reason
> for
> not using case, then add a comment to that effect in the YANG
> module
> prior to the container statement.
> 

[Med] I prefer to maintain the current structure as it adheres with this part from 7950  

   As a shorthand, the "case" statement can be omitted if the branch
   contains a single "anydata", "anyxml", "choice", "container", "leaf",
   "list", or "leaf-list" statement.  In this case, the case node still
   exists in the schema tree, and its identifier is the same as the
   identifier of the child node.

I made this change to remind this is still part of the choice: 

OLD: 
                container ldp-or-l2tp {
                  description
                    "Container for LDP or L2TP-signaled PWs. ";
NEW:
                container ldp-or-l2tp {
                  description
                    "Container for LDP or L2TP-signaled PWs 
                     choice.";


> Tom Petch

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.