Re: [OPSAWG] Shepherd review of draft-ietf-opsawg-l2nm
"Joe Clarke (jclarke)" <jclarke@cisco.com> Fri, 19 November 2021 09:49 UTC
Return-Path: <jclarke@cisco.com>
X-Original-To: opsawg@ietfa.amsl.com
Delivered-To: opsawg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DD03F3A0CEE; Fri, 19 Nov 2021 01:49:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.596
X-Spam-Level:
X-Spam-Status: No, score=-9.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=DCvg5cGr; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=XAGxoJy1
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3ZOr0TIqrpWs; Fri, 19 Nov 2021 01:49:21 -0800 (PST)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7B5E13A0CEB; Fri, 19 Nov 2021 01:49:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=16469; q=dns/txt; s=iport; t=1637315360; x=1638524960; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=GMDrYTHy0SRW3O2uKCm3rQPAjDKG2dfXlcKaNNcNJSE=; b=DCvg5cGr4rpHMltTzq39QS31RMJHamtaYM/TdAHyRkymnwOnLgWuTzmS TbgGIKlvXVXTL+AKqUGSAHhbLdqUBBzF7/ihsCz1SbfjV1aUMKQMP8k6b U0oBK5Ixxh5v8tDjBgvie54W0IZ+pqKt0k0pgOUOB2XpReiWTQYNq926e c=;
IronPort-PHdr: A9a23:5ZC8uRDXGmhEKCMkRco8UyQVaBdPi9zP1kY95pkmjudIdaKut9TnMVfE7PpgxFnOQc3A6v1ChuaX1sKoWWEJ7Zub9nxXdptKWkwJjMwMlFkmB8iIQUTwMP/taXk8G8JPHF9o9n22Kw5bAsH7MlbTuXa1qzUVH0aXCA==
IronPort-Data: A9a23:PcV8RK0zCRmXLqj4vvbD5Rtzkn2cJEfYwER7XKvMYLTBsI5bp2dRyGQaXjuFa66DazCjet8nb9y3o00A65KEzN8yT1c43Hw8FHgiRegpqji6wuYcB84ZRyH6ZBoPA/42N5+Qc6jYcleG/k30a+G4/CElvU21buOU5NDsa3gZqTBMEE/NuTo78wIIqtYAbeqRWmthivuqyyHrA2JJ7hYvWo4iBw1vnzs01Bj6kGtwUlXT/pmntneG/5UeJMp3ya1csxLFrodo8u6SH44vzZmj9W/fuhwqEN7gyPDwc1YBRfjZOg3mZnh+Avf5xEMd4H1plP9mb5Lwam8P49mNt9J6zNxXtpGYQgYyNaqKk+MYO/VdO3EhZfMcp+SdfRBTtuTWlSUqaUDExO11BV45FYwV5ugxBntBndQUMjkDclWCiv64hbWjUeBziYEnds/uFIISpn8myivWZd4vTYrCSqPi4ttU0DA/wMtJW+vdD/f1wxIHgA/oeRZDPBIcD4gz2b3ujXjkeDoeo1WQzZfbKlP7lGRZuIUB+vKMEjBSefhoow==
IronPort-HdrOrdr: A9a23:LV3x2KnuBI54hHfQolare6uokSLpDfOAimdD5ihNYBxZY6Wkfp+V/cjzhCWbtN9OYh4dcIi7SdW9qXO1z+8T3WBjB8bcYOCAghrnEGgC1/qs/9SEIU3DH4FmpNxdmsRFebjN5DtB/IfHCWuDYqwdKbC8mcjC74qzvhQdLz2CKZsQkjuRYTzrdHGeMTM2fabRY6Dsn/avyQDQHUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtUTVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrDAKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7nvZKqm72JeNt9MbsbuWqcGSGptnbJe7pHofh2NiuixupqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MYiFW5uYd899RjBmcsa+ShVfbXhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zs93YN4T4MB6/XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkfgIzfDvfIZNwIo5mZzHXl8dvWkue1j2AcnLx5FP+gClehT1Yd0s8LAp23FUgMyPeFPbC1z1dLl1qbrSnxw2OLyvZ8qO
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0BRBgDFcpdh/5ldJa1QAQYDHgEBCxIMQIFOC4FSKSgHd1o3MYgOA4U5hQ6DAgOQKopjgS6BJQNUCwEBAQ0BASoLDAQBAYFLgnRFAoJpAiU0CQ4BAgQBAQESAQEFAQEBAgEGBIEJE4U7AQUnDYZDAQEBAwEBECgGAQEsCwEPAgEIGB4QJwslAQEEAQ0FCBqCUIJVAy8BDqQjAYE6AoofeIEzgQGCCAEBBgQEhQoYgjUDBoE6gw6EDYcXJxyBSUSBFAFDeYFuPoJjAQGBMwEDKQIFGhcPgwiCLo9SFQFzKRYjBCIZCBAUDiQJDAIDJRMeGjgLHwUXIQiRTBuND54wgSUKgzqfIBWDbIt1hkyRAZYVH6A3PQ4NhFsCBAIEBQIOAQEGgWE7gVlwFTuCaVEZD4EbhjGGVAwFEYEEAQyCP4UUhUp0OAIGCwEBAwmPXoJGAQE
X-IronPort-AV: E=Sophos;i="5.87,247,1631577600"; d="scan'208";a="870627324"
Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 19 Nov 2021 09:49:18 +0000
Received: from mail.cisco.com (xbe-aln-006.cisco.com [173.36.7.21]) by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id 1AJ9nII4019243 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=OK); Fri, 19 Nov 2021 09:49:18 GMT
Received: from xfe-rcd-004.cisco.com (173.37.227.252) by xbe-aln-006.cisco.com (173.36.7.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Fri, 19 Nov 2021 03:49:18 -0600
Received: from xfe-rcd-001.cisco.com (173.37.227.249) by xfe-rcd-004.cisco.com (173.37.227.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Fri, 19 Nov 2021 03:49:17 -0600
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (72.163.14.9) by xfe-rcd-001.cisco.com (173.37.227.249) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14 via Frontend Transport; Fri, 19 Nov 2021 03:49:17 -0600
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7E+DOnItzy8WtbVPSKuCHN+t9lx+TaFK5KSxZ1lLFQWCY40AJD0mKP4SVATQRP7dcv+V84owgehY9WsfyKNls9B4bph2UDrgRDMWbq/ndGu9kXvk2B2lw4Z4oNXRWzuYugFo5ECsgCgFBOQ+5K5cuV4XLeq/AwKWKOHjnywQO25qsP2hn3M6u06SU65jXyAOyAbUkbsto5Sup8ceYaTUWo31YS4viE2iQt7PeFD4gaju4aqkX03vhjOj6/EY3kb838fR0hFMNYaZlTpeGS6eRrc8+nqcE7M7EY2NtFB6sJtS/njAXOpAdrj/j8iI5++gsiWLk7PfC7wp7RtEwAx3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HtIfs8f1qkVNLSSduwvgEuIfmSL2ibr7YVJo1GZ9vhg=; b=aFhZYSHlbgTmhUrsFNUm2q2PE018zY/2XrnJpE67SazkeTsi/p1y0L0eTD6n9EQYCwl4gW3hBcsDZaxoWs2gA6PipW4MBHBgEzy+07Nuy1Ehi31s650D3+b1mvIPnrfUs+S/+63ENe+t+PeDzhHrS8A2LiEjRkNFjH5iOodwqbPjZESsW2RfhmwRWk+eNv1ZqZBJgtyrjgV1j51Nz15a9LUe3h8Q43mJUc0c4Rf/FJbrD97XpdrxFdODWomxGOTak96aRbP4b9kCw9RX+zuS23y168WXJQG5nUxQstkgr+p4ed3EaVWY65kJlLS093W2A2DrtyuZvuH3L/u3/+b0kg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HtIfs8f1qkVNLSSduwvgEuIfmSL2ibr7YVJo1GZ9vhg=; b=XAGxoJy1a+w2+zhgWACb+yhKJUJcc1zUBjvPP+F0Ld7sCQSvuSpFmsV6K6eA9Ncc/HlQXTs+GsF8+T1pSdJy35SA+BmRDjN04LTNAIH/GrVItV9bmyvkaVp3Epx98uYsTZ3KuHCIf4/wVV8pO/4VLpRhln2vSpQeZVBRFILAXXQ=
Received: from BL1PR11MB5368.namprd11.prod.outlook.com (2603:10b6:208:311::17) by BL0PR11MB3442.namprd11.prod.outlook.com (2603:10b6:208:68::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Fri, 19 Nov 2021 09:49:16 +0000
Received: from BL1PR11MB5368.namprd11.prod.outlook.com ([fe80::1944:92c9:6ee9:bb2d]) by BL1PR11MB5368.namprd11.prod.outlook.com ([fe80::1944:92c9:6ee9:bb2d%8]) with mapi id 15.20.4690.016; Fri, 19 Nov 2021 09:49:16 +0000
From: "Joe Clarke (jclarke)" <jclarke@cisco.com>
To: "adrian@olddog.co.uk" <adrian@olddog.co.uk>, "draft-ietf-opsawg-l2nm@ietf.org" <draft-ietf-opsawg-l2nm@ietf.org>
CC: "opsawg@ietf.org" <opsawg@ietf.org>
Thread-Topic: [OPSAWG] Shepherd review of draft-ietf-opsawg-l2nm
Thread-Index: AdfcqQjhkUIl4edGSFqa4+7aP+gOpQ==
Date: Fri, 19 Nov 2021 09:49:16 +0000
Message-ID: <BL1PR11MB5368B91A5D519F15F3E1BDC7B89C9@BL1PR11MB5368.namprd11.prod.outlook.com>
References: <00fa01d7dca9$a8a55430$f9effc90$@olddog.co.uk>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cisco.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4c748833-1be5-4ff9-62b7-08d9ab41d9c7
x-ms-traffictypediagnostic: BL0PR11MB3442:
x-microsoft-antispam-prvs: <BL0PR11MB3442A8B13DE6A35556183338B89C9@BL0PR11MB3442.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: BFBU2NdGH1ZK98smbxl8Ksd3hPrNvmXpyD/nVtEYvg8fBcZgEa3N1CcLvU7l/xQ+ycQP8CQVE1cADutZbX+kjyUogJXFZQHQdFnPkziiBGM0JfryB/FIpXL3yy8zv9tnsbJxbP4wsnBYou1Yba3W7So2/ZBg4J9CvZ63f2qxX4xpEgq0OSpVKgDEuJ/8WqEsl10M8vyzRS/B2jsHFBKjI+iPxVRKxBEAoawFeEiLZQ0w/BUpEYuhSPdV6aknTLYNhEwaxDdBQVCielo2AH3Au5M5kPUJ8BA8K+WiAWH+0xm8uCQCLYZnTiClcrroVu9HTwbtmtm9LNaxCFzfOqxB40KI5ql5dqU8/Lisk1AAJ7m59lkWsjZ/DyN8UnPeAEaYWlIqjIWce+SJSutqJP2TlVkR82E3Y2wYn821fs0iOdC5BQ7duP3tKS7IMIkNU8ifi8kz0E5gUtVynBXaaTvAd9N0wBEJfaDtzsqiHtP2R3CMC4FIDPDoSPk/dQvu8XizIJ6+ZkFEVLfGhdIXDundG41GomiN/hgyacnM7uRnreQ6qUSOWGJvPFYrNkMx/REY2xb3PZeSoquATi2tJ88FTON+i6jGF3jN0S8XtRrDeBijFdED7efU2SqqAtA4tqP8GcvIulFC3sT3M729GTLHDbaLS6o3MTFzRo8QxY1F5S1+VXDTZk1E5G7rFOkNnega0F14TfPyWZfYHl0x92jiENO9xn6QHn0e5e9I4GdzvA+cbI8NOTo++j4sLjziwy8sCurfnzo2tzCnSxuXQo5yZw/ScyfH1/3P6AvUBp/0t6k=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL1PR11MB5368.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(5660300002)(2906002)(66574015)(8676002)(66946007)(66476007)(38100700002)(53546011)(6506007)(9686003)(33656002)(52536014)(55016002)(38070700005)(66556008)(91956017)(66446008)(76116006)(64756008)(966005)(40140700001)(8936002)(30864003)(508600001)(7696005)(71200400001)(26005)(316002)(4326008)(55236004)(186003)(122000001)(110136005)(83380400001)(86362001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: Eqps/L202lczowYwoK+KbdzXFT4GAffOH8kRm/jprl0cHR29a7GeBWgga3yuYdEBxD10rVZV5sCRaLwMcX3IXyyfzQc/cAa2udaE3+El2R5ceI2mvQrnBH792cDMHhcSmDEW6tGT+y/C9BHr0+89eK9rrt6b51bvhKMvYSV4DSyght1WnfYBYDgXRhNSiPrEdhX3CPBGSmuDQWowQbjerNXYdF1VOUA2L7RMhF6ok8sbmPT32pwJqroRM825vG0YswwUmsh9zNv2KbxkTkAx6OdtOF8QDx8VnhWNnFUnod7eFdT1NhSKZMU4kvxgBJMMUrLyIvJmWY2gOwOPFiamYtbG9kcAY9dLE1WNS36QxSUgHv1riR1T9B3s01rb2Tik31YuVv9rpLvxp+uxZMXU2ZDzSFgG7d3sOFGK2V6OB/Fg084xSpySM7VHw87PTtbjfLUvYMCiYViapKtFlEntPTZCi7DxaZqBz8IZWy+PR68wzWrYtlThLPKzUOcC5eIZhEUCSoGeTbMyxunZvxjjx8Q/HJWBPTk1VFkuuISxeiByzowr7Xt4CcrV61nWatbU3ikHHB9PxUEpOzX5SqzqIrfHcStTyzC51coH/D8opM+Fbp+hYzd3NPfYPjMV5ZiLchO30rej+eROdFXUeizw36pcLGiigz2F3jxeFT97HiFD34fB4MvXUWoQLeMkKEAqUoJl68lm4PkILPDA+cZqK116Y7JDrRr4DknMTFnB3v4bWSsAJT1DYIev9dOsjqIY1e7NCGpGzr1a8yE/UcTpcgb/TJ6RfkJrT6xomH1s5awTjFq4d224RRgbcrpDDAqPLEJ7CLp5nwfqkDUQkGf+mraTvinv8diqcjxcuynESES0WlK3r2U69W38qKTYUcPYQnm6MjRQh1nP3CpdgUSy2Sx4+j84RYOe/29VC/xilBCGapT1yIgqKJL4ay4oF+o5mp7yrEs3NAIkHkNClFFoPVdR+GzJoAtOsKgvup/1jMz0v3KvT4chMo+f7T02ew3I0wCy8HJeDA6cK5M3XJ9EQQl/wqlCtToy3ERtkZEi7k+MQVGQAVKTgONcvzhdcV6noucYAugNMlnj/qbJFB5omw1fgtt3FT+xxsHWAYcnxiC+91SVYXTGV9xdKoVEGzaC5pl5/3k451VhKNmxoEsjOtTZOOGl1tjV+cB2Fde6m24GcrVoXyEDASx/sPgIVgJi2TXM/Uh7Qam6BmrKAMqetwmYq3dl7LQhfgDNvWz9uMfcYkyMj/3y+7bSYeEs39p5DfgPVDcezVPyHJz1egPhKww4+tbQmO/ibRDo3qZDEifgyKmgYjEJ/xEtkNcmakmBji0pQnkUI7LcJNTQOABfc9wjcNJPHS9Kvy4xeKN24p+f4rbonWBgg0w7iN+l4F2va+FGXqB5U7ZaHKv/meJhXxAB3gfqMhFSaT/skv6LAfdIHgM04KH+9vwbMGMToYqW119O4qSsX/0FJx8tt/xEDrNUrHLZm0xMyIpj0d5tDGt6jVE1ZU0DJNij1uDjjBxZXZSQaEExfF+g2GADFQHicKtjP5RlgTBpLYZWL03W8KeYx4KtaYfHD+9pbb56iBynzvcqarFc24pnHKtwkhITqVMe6QmVIoI7iQu3xtSeSXI=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5368.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c748833-1be5-4ff9-62b7-08d9ab41d9c7
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2021 09:49:16.2641 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5sj5KvYcNedvvy9HIM41pTOl6Jijsz65D+Er9vX7SMa2dcDlHtXXXCAFrDEzFTNJgrB72RCMHDEwpnLn6gtt6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3442
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.21, xbe-aln-006.cisco.com
X-Outbound-Node: rcdn-core-2.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/opsawg/hLyrAcW8iECeGo3vlkmH73C38BE>
Subject: Re: [OPSAWG] Shepherd review of draft-ietf-opsawg-l2nm
X-BeenThere: opsawg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OPSA Working Group Mail List <opsawg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/opsawg>, <mailto:opsawg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/opsawg/>
List-Post: <mailto:opsawg@ietf.org>
List-Help: <mailto:opsawg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/opsawg>, <mailto:opsawg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Nov 2021 09:49:26 -0000
Thank you for taking on these drafts, Adrian and for a thorough review of L2NM. Joe On 11/18/21 13:25, Adrian Farrel wrote: > I have done my review of draft-ietf-opsawg-l2nm based on revision -10 of > the draft. Sorry it took so long, but there are a few pages of text that > needed to be read. > > I have to congratulate the authors on this substantial piece of work. A > lot of time and effort must have gone into it. > > It seems to be in pretty reasonable shape to me. Of course, it would be > a surprise if such a long document didn't have a few issues, but most of > what I have below is just nits. > > Please feel free to ask for clarification or to refute anything I have > said. > > Thanks, > > Adrian > > ==== > > I see "layer 2" and "Layer 2" etc. I think in the context of L2VPN, > L2NM, etc., "Layer 2" is fine. But others "like Layer 2 connection" > are used inconsistently. > > --- > > Abstract doesn't need "(VPN)" > > --- > > Abstract > > s/providers/provider/ > s/Also, the document/Also, this document/ > s/that defines/that define/ > > --- > > 1. > > OLD > [RFC8466] defines an L2VPN Service Model (L2SM) YANG data model that > can be used for Layer 2 Virtual Private Network (L2VPN) service > ordering matters between customers and service providers. > NEW > [RFC8466] defines an L2VPN Service Model (L2SM) YANG data model that > can be used between customers and service providers for ordering > Layer 2 Virtual Private Network (L2VPN) services. > END > > --- > > 1. > > s/providers network/provider's network/ > s/Also, the document/Also, this document/ > s/rather than be limited/rather than being limited/ > > --- > > 2. Service orchestrator > > s/responsible of the CE-PE/responsible for the CE-PE/ > > --- > > 2. > > You might put "VPN node" before "VPN network access" to resolve the > reference. > > --- > > 2. Layer 2 VPN Service Network Model (L2NM) > > s/providers network/provider's network/ > > --- > > Figure 1 > > It is unclear what +++++++ > + AAA + > +++++++ means, and I don't see any text about it. > > Is "Bearer Connection" identical to "Ethernet Segment"? See the > definition of "bearer" in "VPN network access" in section 2. If they are > the same, why use two terms? If they are different, please define bearer > connection. > > --- > > Section 6 and the Ethernet Segment YANG Module comes as a bit of a > surprise. There is just one mention of that module (in Section 5). > > I think the Abstract and Introduction should at least mention the ES > module. > > --- > > Figure 3 appears to have some rather random whitespace. Needs tidying? > Perhaps tabs were used in the original. > > Figures 7, 8, 9, 11, 12, 13, 15 are pretty bad, too. > > Figures 6, 14, and 22 have this a little. > > Figure 17 is pretty much OK, but I don't know that "enumeration" needs > to be on a separate line each time. > > --- > > Section 5 > > s/is meant to manage L2VPN services/is used to manage L2VPN services/ > > --- > > Section 6 > > In reference to the structure shown in Figure 3, the following data > nodes can be included: > > Too much passive voice. Can be included: > - where? > - by whom? > - under what circumstances are they included or left out? > > --- > > Section 6 > > 'name' s/with a service/within a service/ > > 'esi-redundancy-mode' Not sure, should you... > s/Single-Active/'single-active'/ > s/All-Active/'all-active/ > > There are a number of data nodes shown in Figure 3 that don't have > explanations in the text. Is that intentional? It would seem to me that > they should be described in the same way as the other nodes. If you mean > to leave them out, perhaps say so and point at the YANG for definitive > descriptions of the other nodes. > > --- > > Section 7 > > s/is meant to manage L2VPNs/is used to manage L2VPNs/ > > --- > > Section 7.2 > > 'forwarding-profile-identifier': > Such policies may consist, for example, at applying Access > Control Lists (ACLs). > > Can't parse this. Maybe "...may consist, for example, of applying..." > > --- > > Section 7.3 > > s/Such 'vpn-id' is/Such a 'vpn-id' is/ > > > 'signaling-type': Indicates the signaling that is used for setting > s/setting/setting up/ > > s/l2tp-signaling'/'l2tp-signaling'/ > > --- > > Section 7.3 > 'underlay-transport' > (e.g., an identifier of a VPN+ instance, a virtual network > identifier, or a network slice name) > I don't know why you have "identifier" for the first two, but "name" for > a network slice. Wouldn't "identifier" serve better for all three cases > as... > (e.g., an identifier of a VPN+ instance, virtual network, or > network slice) > > 'status' > s/provision/provisioning/ > > 'vpn-node' > s/various 'description' data node/various 'description' data nodes,/ > > --- > > Section 7.3 > > Table 1: Valid Signaling Options per VPN > Service Type > > Maybe delete "Valid" > > --- > > Section 7.4 > > I think PCP needs to expanded here. (Especially since you don't mean > Port Control Protocol.) > > --- > > Section 7.5.1 > > s/'bgp-auto-discovery' container/The 'bgp-auto-discovery' container/ > > --- > > Section 7.5.2.1 > > s/this is VLAN-based/a this is VLAN-based/ > > --- > > Section 7.5.2.1 > > The value of the 'pw- > encapsulation-type' are taken from the IANA-maintained "iana-bgp- > l2-encaps" module. > > A reference to Section 8.1 would be good. > > --- > > Section 7.5.2.2 > > s/include a an/include an/ > > --- > > Section 7.5.2.3 > > The PW type ('pseudowire-type') value is taken from the > IANA-maintained "iana-pseudowire-types" module. > > A reference to Section 8.2 would be good. > > --- > > 7.6 > > As such, every 'vpn-network-access' MUST belong to > one and only one 'vpn-node'. > > I'm not sure how to interpret this. The vpn-network-access part of the > tree is anchored under vpn-node. So it cannot be in two places at once. > > Maybe this is saying that the value of the 'id' node must not appear > twice across the whole instantiation of the data model? > > --- > > Section 7.6 > > s/' global-parameters-profile'/'global-parameters-profile'/ > > --- > > Section 7.6.1 > > s/OAM 802.3 ah/OAM 802.3ah/ > > --- > > Section 7.6.4 > > 'svc-pe-to-ce-bandwidth' and 'svc-ce-to-pe-bandwidth' are missing colons > > --- > > Section 8.1 > > The "iana-bgp-l2-encaps" YANG module (Section 8.1) is designed to > echo the registry available at [IANA-BGP-L2]. > > This *is* Section 8.1 > Instead of "is designed to echo" say "echoes" > > --- > > Section 8.1 > > Appendix B lists the > initial values included in the "iana-bgp-l2-encaps" YANG module. > > Initial values of what? I think you are saying that the YANG model is > populated according to the state of the registry at the time of > publication of this document (and that new entries to the registry > should be matched with additional nodes in this model). > > So, I would be inclined to leave this out. > > And actually, I'd omit Appendix B which doesn't add anything. > > --- > > 8.1 and other subsections > > It is useful to help resolve references and import clauses by placing > some text before the <CODE BEGINS> to say something like... > > This module makes imports from [RFCaaaa], and makes references to > [RFCbbbb] and [RFCcccc]. > > --- > > Section 8.1 > > I believe the correct postal details are: > > Internet Assigned Numbers Authority (IANA) > 12025 Waterfront Drive, Suite 300 > Los Angeles CA 90094 > USA > > +1-424-254-5300 (phone) > > --- > > 8.1 and 8.2 > identity layer-2-transport { > base foo; > description > "IP Layer 2 Transport."; > reference > "RFC 3032: MPLS Label Stack Encoding"; > } > > I don't quite get this. Is the reference wrong? Is the name of the > identity and the description wrong? > > --- > > Section 8.2 > > The comments about the introductory paragraphs of 8.1 apply to 8.2. > Also the comment about the contact address. > > --- > > Section 8.2 > > Why don't atm-aal5 and atm-vp-virtual-trunk have reference clauses? > > --- > Section 8.4 > > I don't find any explanation or reference for the color-type identities > or the color-type leaf. Maybe a description for Figure 20, or a > description clause for the leaf or the base identity. > > --- > > Section 8.4 > > I'm puzzled as to which leaf nodes qualify for a default clause and > which don't. > > For example, ccm-interval and ccm-holdtime have default values. That > seems reasonable. But message-period and measurement-interval do not. > > Similarly, mac-loop-prevention and frequency have defaults, retry-timer > does not. > > Can you say how you decided which leaf nodes don't merit a default > value? Can you check that you have assigned a default everywhere one is > needed? > > --- > > Section 8.4 > > leaf ce-vlan-preservation { > type boolean; > description > "Preserve the CE-VLAN ID from ingress to egress,i.e., > CE-VLAN tag of the egress frame are identical to > those of the ingress frame that yielded this egress > service frame. If All-to-One bundling within a site > > s/,i.e.,/, i.e.,/ > s/are identical/is identical/ > s/those/that/ > > --- > > Section 8.4 > > leaf ne-id { > type string; > description > "Indicates the node's IP address."; > } > > But 7.5 had > 'ne-id': Includes a unique identifier of the network element where > the VPN node is deployed. > ...and 8.3 had > leaf ne-id { > type string; > description > "Unique identifier of the network element where the ES > is configured with a service provider network."; > > Now, I know that a node's IP address is usually used as the unique > identifier of the node, but 7.5 and 8.3 make it look like you could use > something else so long as it is unique. > > Additionally, "unique" is probably stronger than you mean, since you are > probably happy with a certain domain of uniqueness. > > Compare and contrast with > > leaf router-id { > type rt-types:router-id; > description > "A 32-bit number in the dotted-quad format that is > used to uniquely identify a node within an > autonomous system (AS). "; > } > > --- > > Section 8.4 > leaf pw-description { > type string; > description > "Includes an interface description used to > send a human-readable administrative > string describing the interface to the > remote."; > > To the remote what? > Actually, to be completely clear, are you saying that the interface > description is used to send a string to the remote? Or is this garbled? > > Could be... > Includes a human-readable description of the interface. This may be used > when communicating with remote administrative processes to identify the > interface. > > --- > > Section 8.4 > > There is a set of three members of the container 'connection' that are > of type string : l2-termination-point, local-bridge-reference, and > bearer-reference. The description classes are clear up to a point, but > "a reference to" doesn't really tell me what I should put in these > objects. > > --- > > Section 8.4 > leaf port-speed { > type uint32; > description > "Port speed."; > } > > This is missing a units clause. And I would be slightly worried that > uint32 might not be future-proof with some possible units. > > --- > > Section 8.4 > > leaf ce-id { > type uint16; > description > "The PE must know the set of virtual > circuits connecting it to the CE and a > CE ID identifying the CE within the VPN."; > > The first part of the description ("set of VCs connecting to the CE") is > true, but is it relevant to this leaf? > > --- > > Section 9 > > The YANG modules specified in this document defines schema for data > that is designed to be accessed via network management protocols such > as NETCONF [RFC6241] or RESTCONF [RFC8040] . The lowest NETCONF layer > > s/defines schema/define schemas/ > s/that is/that are/ > s/] ./]./ > > --- > > I think 10.2 and 10.3 should make it clearer that IANA is requested to > maintain the two YANG models. > > --- > > Thanks for all the examples. They are helpful. > > --- > > A.1 > > s/used to configured/used to configure/ > > --- > > A.4 > > s/depictes/depicts/ > > --- > > A.4 > > In Figure 29 is it intentional that the left-hand end of the Emulated > Service is at the edge of the CE, but the right-hand end is in the > middle of the CE. > > --- > > A.6 > > s/In such as configuration/In such a configuration/ > > --- > > I'm unclear of the purpose of Appendixes B and C. They seem to repeat > information that is found in the relevant IANA registries. > > _______________________________________________ > OPSAWG mailing list > OPSAWG@ietf.org > https://www.ietf.org/mailman/listinfo/opsawg >
- [OPSAWG] Shepherd review of draft-ietf-opsawg-l2nm Adrian Farrel
- Re: [OPSAWG] Shepherd review of draft-ietf-opsawg… mohamed.boucadair
- Re: [OPSAWG] Shepherd review of draft-ietf-opsawg… Joe Clarke (jclarke)
- Re: [OPSAWG] Shepherd review of draft-ietf-opsawg… Adrian Farrel
- Re: [OPSAWG] Shepherd review of draft-ietf-opsawg… mohamed.boucadair
- Re: [OPSAWG] Shepherd review of draft-ietf-opsawg… Adrian Farrel
- Re: [OPSAWG] Shepherd review of draft-ietf-opsawg… mohamed.boucadair
- Re: [OPSAWG] Shepherd review of draft-ietf-opsawg… Moti Morgenstern