Re: [OPSAWG] I-D Action: draft-ietf-opsawg-tacacs-08.txt

Joe Clarke <jclarke@cisco.com> Tue, 20 February 2018 17:52 UTC

Return-Path: <jclarke@cisco.com>
X-Original-To: opsawg@ietfa.amsl.com
Delivered-To: opsawg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 27BB112D943 for <opsawg@ietfa.amsl.com>; Tue, 20 Feb 2018 09:52:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.53
X-Spam-Level:
X-Spam-Status: No, score=-14.53 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XR1NclNZsqHp for <opsawg@ietfa.amsl.com>; Tue, 20 Feb 2018 09:52:14 -0800 (PST)
Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 91CCB127909 for <opsawg@ietf.org>; Tue, 20 Feb 2018 09:52:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4466; q=dns/txt; s=iport; t=1519149134; x=1520358734; h=subject:references:to:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding; bh=24yYZT83ULNr7f//6rlti13jsPIMfrtD9YmOG14kohQ=; b=Xd0SCrbEbqlMBqURoeZqum3M0BHj6nDpBH1RB6huloW5rwEyYTUMZo4a hAfIeud8qA7zilKV2AUNYGikBXmCmeuPTnByHYM/tsSnGJHsAMBbNuIX3 OegGTHj9wQuL6t2JcYEg634RxU47vyaJ6j7WjFDGHmkcnw4ruB2cuAVnS Q=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0C0AgClX4xa/5xdJa1TCRkBAQEBAQEBAQEBAQEHAQEBAQGDT2ZwKINnmCyBUDKBF5hfChgLhElPAoJsVxUBAgEBAQEBAQJrKIUkAQEEAQEhDwE7GwsYAgImAgInMBMGAgEBF4oIEK0ygieFAYN5ghMBAQEHAQEBAQEjgQ+Df4IogVeBaCmDBYMwAQECAQEXgSwUFoMXgmUFk2iQTQmIJI1mgiBnhUODciaHZY4GihmBPDUjgVFNIxUZIYJDCYULIzeNIAEBAQ
X-IronPort-AV: E=Sophos;i="5.46,540,1511827200"; d="scan'208";a="72854428"
Received: from rcdn-core-5.cisco.com ([173.37.93.156]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2018 17:52:13 +0000
Received: from [10.118.87.83] (rtp-jclarke-nitro2.cisco.com [10.118.87.83]) by rcdn-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id w1KHqDGW009278 for <opsawg@ietf.org>; Tue, 20 Feb 2018 17:52:13 GMT
References: <151905481837.18617.15913982011400739178@ietfa.amsl.com>
To: opsawg@ietf.org
From: Joe Clarke <jclarke@cisco.com>
Organization: Cisco
Message-ID: <5aef06e0-68a6-cdd1-d165-0eaba1e10d8f@cisco.com>
Date: Tue, 20 Feb 2018 12:52:13 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <151905481837.18617.15913982011400739178@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/opsawg/xfEhh72DGTSZ9mDkfBvrXZ5ZlYw>
Subject: Re: [OPSAWG] I-D Action: draft-ietf-opsawg-tacacs-08.txt
X-BeenThere: opsawg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: OPSA Working Group Mail List <opsawg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/opsawg>, <mailto:opsawg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/opsawg/>
List-Post: <mailto:opsawg@ietf.org>
List-Help: <mailto:opsawg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/opsawg>, <mailto:opsawg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Feb 2018 17:52:17 -0000

Thank you, authors.  Would you send a synopsis of the changes to the
list as well as what you feel is left to do?  It would be good to spur
some more discussion on this.

I read through the text, focusing on the changes, and found a few typos
and nits.

Section 1:

OLD:

The normative description of Legacy features such as ARAP and
outbound authentication have

NEW:

The normative description of Legacy features such as ARAP and
outbound authentication has

===

Section 1:

s/authroization/authorization/

===

Section 3.3

You have one reference to "Single connection Mode".  Why is the 'c'
lowercase here?  For consistency, it should be uppercase.

===

Section 3.4

OLD:

For example, the client try alternative methods, if they are available,

NEW:

For example, the client tries alternative methods, if they are available,

===

Section 3.4

s/implmentation/implementation/

===

Section 3.5

OLD:

.  for example

NEW:

.  For example

===

Section 3.7

OLD:

refer to section section

NEW:

refer to section

===

Section 4.1

You refer to the Unix su(1) command in man page style notation.  This
may not be fully understood by all readers.  I think it would be better
to describe what su does in a short phrase (This is comparable to the
"su" command on Unix, which substitutes the current user's identity with
another).

===

Section 4.4.2.3

s/alays/always/

===

Sections 4.4.2.4 and 4.4.2.5

OLD:

The TACACS+ server must rejects

NEW:

The TACACS+ server must reject

===

Section 4.4.3

s/temrination/termination/

===

Section 4.4.3

You say, "oplease refer to section" (which has a typo).  But I don't
think you need the please at all here.

===

Section 5

s/clients actions/client's actions/

===

Section 5.1

s/corrsponds/corresponds/

===

Section 7.1

Stardate is canonically inconsistent

:-)

===

Section 7.2

Under nohangup, I think you have a typo with "authorization.y."  Not
sure if you intended something else there, or that "y." just crept in.

===

Section 8

s/()such as/(such as/

===

Section 8

s/starts starts/starts/

===

Section 8

s/reuthentication/reauthentication/

===

Section 8

You mention su again, but do so without man page notation.  you also
refer to unix instead of Unix.  Perhaps a good solution is to point to
one of the web=based man page gateways to create a true xref for su.

===

Section 9.1

s/For this reasons/For these reasons/

===

Section 9.2

s/which may me/which may be/

===

Section 9.5

s/apropriate/appropriate/

===

Section 9.5

s/send send secret keys/send secret keys/

Joe




On 2/19/18 10:40, internet-drafts@ietf.org wrote:
> 
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the Operations and Management Area Working Group WG of the IETF.
> 
>         Title           : The TACACS+ Protocol
>         Authors         : Thorsten Dahm
>                           Andrej Ota
>                           Douglas C. Medway Gash
>                           David Carrel
>                           Lol Grant
> 	Filename        : draft-ietf-opsawg-tacacs-08.txt
> 	Pages           : 43
> 	Date            : 2018-02-19
> 
> Abstract:
>    TACACS+ provides Device Administration for routers, network access
>    servers and other networked computing devices via one or more
>    centralized servers.  This document describes the protocol that is
>    used by TACACS+.
> 
> 
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-opsawg-tacacs/
> 
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-opsawg-tacacs-08
> https://datatracker.ietf.org/doc/html/draft-ietf-opsawg-tacacs-08
> 
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-opsawg-tacacs-08
> 
> 
> Please note that it may take a couple of minutes from the time of submission
> until the htmlized version and diff are available at tools.ietf.org.
> 
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
> 
> _______________________________________________
> OPSAWG mailing list
> OPSAWG@ietf.org
> https://www.ietf.org/mailman/listinfo/opsawg
>