Re: [OSPF] AD review of draft-ietf-ospf-node-admin-tag-04

Shraddha Hegde <shraddha@juniper.net> Thu, 24 September 2015 17:27 UTC

Return-Path: <shraddha@juniper.net>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2958F1A6FFA; Thu, 24 Sep 2015 10:27:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 816ssgMqOO4X; Thu, 24 Sep 2015 10:27:52 -0700 (PDT)
Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0717.outbound.protection.outlook.com [IPv6:2a01:111:f400:fc10::717]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6DA7C1B2AF6; Thu, 24 Sep 2015 10:27:51 -0700 (PDT)
Received: from BY1PR0501MB1381.namprd05.prod.outlook.com (10.160.107.139) by BY1PR0501MB1384.namprd05.prod.outlook.com (10.160.107.142) with Microsoft SMTP Server (TLS) id 15.1.274.16; Thu, 24 Sep 2015 17:27:23 +0000
Received: from BY1PR0501MB1381.namprd05.prod.outlook.com ([10.160.107.139]) by BY1PR0501MB1381.namprd05.prod.outlook.com ([10.160.107.139]) with mapi id 15.01.0268.017; Thu, 24 Sep 2015 17:27:23 +0000
From: Shraddha Hegde <shraddha@juniper.net>
To: "Acee Lindem (acee)" <acee@cisco.com>, Alia Atlas <akatlas@gmail.com>, OSPF List <ospf@ietf.org>, "draft-ietf-ospf-node-admin-tag@ietf.org" <draft-ietf-ospf-node-admin-tag@ietf.org>
Thread-Topic: [OSPF] AD review of draft-ietf-ospf-node-admin-tag-04
Thread-Index: AQHQ9WiopRmlncyHX0WMH9Q8OCJEuJ5I54wAgAAH9YCAAv+HkA==
Date: Thu, 24 Sep 2015 17:27:23 +0000
Message-ID: <BY1PR0501MB13813D6AF5B739F98D9383E9D5430@BY1PR0501MB1381.namprd05.prod.outlook.com>
References: <CAG4d1rdCDNrk+Hn0SkSx1LeRfSUHr+LLSJ8LR-k5ui6WUm0h3A@mail.gmail.com> <CAG4d1rfOa9M8adSxocHka0wYL7wZbUP94ujGC9CW16QOiSBEfA@mail.gmail.com> <D2272216.30E2B%acee@cisco.com>
In-Reply-To: <D2272216.30E2B%acee@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=shraddha@juniper.net;
x-originating-ip: [116.197.184.13]
x-microsoft-exchange-diagnostics: 1; BY1PR0501MB1384; 5:fCgYMMqwJWtli7e04aj3YjzvkqoOq8aDFBZe7fpF1gKeJzQfwQ+5E77eyqa6OE//ahWvnJuBKP774OhROB+bqDJjxKg9meR2ddCx+gr6JKm9N3CttyUd/iYDtELD/wlpfj902+GFffk5k9PbRrDCvQ==; 24:LICRGRGEVucoFTmFnEMJeVeg925a3SiFsBkX3Kl8VJ7C3EkY9lKHqP8904ryF8PLGBq729Y0ZYJUW7F6DBc5AuG6l9h7q1b2cbiet4HWoD8=; 20:6yiBxfubQvCZUEocb55e32BTQyLVdYlv2/zZeasxYqV3y74Mab0FitMgG7513emjRl3s6bNLOTnOBTAj4tkp0Q==
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0501MB1384;
x-microsoft-antispam-prvs: <BY1PR0501MB1384777E9B9B16E664EA57C1D5430@BY1PR0501MB1384.namprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(95692535739014)(108003899814671);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001); SRVR:BY1PR0501MB1384; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0501MB1384;
x-forefront-prvs: 070912876F
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(189002)(377454003)(199003)(24454002)(164054003)(43784003)(45984002)(19580405001)(5001770100001)(19300405004)(54356999)(230783001)(76176999)(122556002)(99286002)(105586002)(40100003)(50986999)(106116001)(66066001)(19625215002)(46102003)(19609705001)(106356001)(33656002)(64706001)(101416001)(74316001)(16236675004)(107886002)(92566002)(11100500001)(2900100001)(189998001)(5001960100002)(5004730100002)(2950100001)(19580395003)(77096005)(68736005)(5002640100001)(15975445007)(86362001)(102836002)(5003600100002)(5007970100001)(2501003)(77156002)(5001860100001)(62966003)(5001830100001)(81156007)(4001540100001)(76576001)(87936001)(10400500002)(97736004); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR0501MB1384; H:BY1PR0501MB1381.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en;
received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts)
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_BY1PR0501MB13813D6AF5B739F98D9383E9D5430BY1PR0501MB1381_"
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2015 17:27:23.5651 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0501MB1384
Subject: Re: [OSPF] AD review of draft-ietf-ospf-node-admin-tag-04
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Sep 2015 17:27:55 -0000

Alia,

Thank you very much for the review and comments.
I have updated the draft and draft-ietf-ospf-node-admin-tag-05 is posted.

Authors list has been reduced to 6 and one author moved to contributor’s list.
Here is the list of other comments and resolutions

1) In the abstract: "This optional operational capability allows to
   express and act upon locally-defined network policy which considers
   node properties conveyed by tags."

   What is the subject that "to express and act upon"?  Is it a router?
   Please clean up.
<Shraddha>changed  to
“The node-tags can be used to express and apply locally-defined
network policies which is a very useful operational capability.”


2) In Sec 3.2: "The TLV SHOULD be considered an unordered list."  Perhaps
   "the value contents of the TLV" or something that makes it clearer?
<Shraddha>Changed to
“The administrative tag list within the TLV SHOULD be considered
an unordered list.”


3) In Sec 4.3: " [RFC7490] proposed method of"  should be
   "[RFC7490] defines a method of"
<Shraddha> Updated

4) In Sec 5, I'm fairly certain that admin tags can leak additional
   information to an IGP snooper.  It would be useful to have some thoughts
   about that.
<Shraddha>
Node admin tags may be used by operators to indicate geographical location or other
sensitive information.
As indicated in <xref target="RFC2328"/> and <xref target="RFC5340"/> OSPF authentication
mechanisms do not provide  confidentiality and the information carried in node admin tags could be leaked to an IGP
snooper.

5) In IANA considerations, please duplicated the suggested value (10) that
   was mentioned in Sec 3.1

<Shraddha> Updated

Rgds
Shraddha


From: Acee Lindem (acee) [mailto:acee@cisco.com]
Sent: Wednesday, September 23, 2015 1:01 AM
To: Alia Atlas <akatlas@gmail.com>om>; OSPF List <ospf@ietf.org>rg>; draft-ietf-ospf-node-admin-tag@ietf.org
Subject: Re: [OSPF] AD review of draft-ietf-ospf-node-admin-tag-04

Thanks Alias - Speaking as Document Shepherd…

Authors,

Please let me know if you require any assistance - these all seem like good comments.

From: OSPF <ospf-bounces@ietf.org<mailto:ospf-bounces@ietf.org>> on behalf of Alia Atlas <akatlas@gmail.com<mailto:akatlas@gmail.com>>
Date: Tuesday, September 22, 2015 at 3:02 PM
To: OSPF WG List <ospf@ietf.org<mailto:ospf@ietf.org>>, "draft-ietf-ospf-node-admin-tag@ietf.org<mailto:draft-ietf-ospf-node-admin-tag@ietf.org>" <draft-ietf-ospf-node-admin-tag@ietf.org<mailto:draft-ietf-ospf-node-admin-tag@ietf.org>>
Subject: Re: [OSPF] AD review of draft-ietf-ospf-node-admin-tag-04



On Tue, Sep 22, 2015 at 2:58 PM, Alia Atlas <akatlas@gmail.com<mailto:akatlas@gmail.com>> wrote:
As is customary, I have done my AD review of draft-ietf-ospf-node-admin-tag-04
before requesting IETF Last Call.

First, I'd like to thank the working group and Shraddha, Harish, Hannes, Rob,
Anton, Zhenbin, and Bruno for their hard work on the draft.  However, this short
draft has 7 authors, which is a couple over the author limit for RFCs.  Experience
has shown that it takes much longer to process a draft through AUTH48 and the
other steps necessary (responsiveness to comments, agreement, etc) with a large
number of authors.  While I am willing to be persuaded - on or off list - that all 7
of the current authors are actively editing, I would prefer that a smaller number be
selected as the active editors.

In some cases, a draft represents a multi-vendor effort requiring a significant commitment from more than 5 authors and I’d specifically request a deviation from the author limit. I don’t see this to be the case with this draft.



While that discussion is ongoing, here are my technical comments.  In general,
the draft is in good shape but could use some English grammar editing; I have not
tried to indicate all the places where "the" is missing, for instance.

1) In the abstract: "This optional operational capability allows to
   express and act upon locally-defined network policy which considers
   node properties conveyed by tags."

   What is the subject that "to express and act upon"?  Is it a router?
   Please clean up.

2) In Sec 3.2: "The TLV SHOULD be considered an unordered list."  Perhaps
   "the value contents of the TLV" or something that makes it clearer?

3) In Sec 4.3: " [RFC7490] proposed method of"  should be
   "[RFC7490] defines a method of"

4) In Sec 5, I'm fairly certain that admin tags can leak additional
   information to an IGP snooper.  It would be useful to have some thoughts
   about that.

When you include this, be sure and point out the the attacker would also require knowledge of the policies corresponding to the tags. I’d also point out that the policies and advertised tags are local to the OSPF routing domain as is done in RFC 5530.

Thanks,
Acee


5) In IANA considerations, please duplicated the suggested value (10) that
   was mentioned in Sec 3.1

Thanks again for the hard work.  The sooner we resolve whom the editors are,
the sooner this draft can proceed.  Ideally, if updated by Thursday, it could enter
IETF Last Call and make the IESG telechat on Oct 17.

Oct 15 that is.


Regards,
Alia