Re: [OSPF] Implementation of draft-ietf-ospf-dbex-opt-02.txt

"Vishwas Manral" <vishwas.ietf@gmail.com> Wed, 02 April 2008 21:47 UTC

Return-Path: <ospf-bounces@ietf.org>
X-Original-To: ospf-archive@optimus.ietf.org
Delivered-To: ietfarch-ospf-archive@core3.amsl.com
Received: from core3.amsl.com (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 8B8583A6EE3; Wed, 2 Apr 2008 14:47:01 -0700 (PDT)
X-Original-To: ospf@core3.amsl.com
Delivered-To: ospf@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 4967628C519 for <ospf@core3.amsl.com>; Wed, 2 Apr 2008 14:47:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nLSJm5s8gBlx for <ospf@core3.amsl.com>; Wed, 2 Apr 2008 14:47:00 -0700 (PDT)
Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.170]) by core3.amsl.com (Postfix) with ESMTP id 651343A6F0E for <ospf@ietf.org>; Wed, 2 Apr 2008 14:45:55 -0700 (PDT)
Received: by wf-out-1314.google.com with SMTP id 25so2989770wfa.31 for <ospf@ietf.org>; Wed, 02 Apr 2008 14:45:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=2osCAyMpdyF57H5q9LOt4bKSgtCKeGhSm9QyVK+gQO8=; b=Jnd+lS5K17u1XFiHDjjxPilFAPAQHu4gwKCDAG6tTdPqiwMwbABTps96Nx1Msfk1eguAel1VvTqx9FivpmlTZeuusdQ6jsGqUHXaz406kN7uAquAwxMSUqX4ZhHAFT5m+JifAXk393Dnv2PbLVq46HxdbVxFpk5UBWhm1bFKYu8=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=RA3wN6mrZut3UAhHayBBgR++q8o8zRQjDqzTcvcRPc7X1zXXYvkE3PNJzxzS/dKhxzZgVjucOrNtTo3hfBgh/dTucorxE0wSLennMo+QqT1DIldJOoEqx69MguWajONGVqG4JZNDkFMVp5jBj2Tq4EABEXM3+mmfQnKSxBUGUmo=
Received: by 10.142.12.14 with SMTP id 14mr6475033wfl.152.1207172756681; Wed, 02 Apr 2008 14:45:56 -0700 (PDT)
Received: by 10.143.9.18 with HTTP; Wed, 2 Apr 2008 14:45:56 -0700 (PDT)
Message-ID: <77ead0ec0804021445l6dfa77fah7f70b303c2d943cb@mail.gmail.com>
Date: Wed, 02 Apr 2008 14:45:56 -0700
From: Vishwas Manral <vishwas.ietf@gmail.com>
To: Richard Ogier <ogier@earthlink.net>
In-Reply-To: <77ead0ec0804021438m7ac2863icd0ed5dd808f9ba3@mail.gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
References: <47F4026E.2060503@earthlink.net> <77ead0ec0804021438m7ac2863icd0ed5dd808f9ba3@mail.gmail.com>
Cc: OSPF List <ospf@ietf.org>
Subject: Re: [OSPF] Implementation of draft-ietf-ospf-dbex-opt-02.txt
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/pipermail/ospf>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ospf-bounces@ietf.org
Errors-To: ospf-bounces@ietf.org

Hi Richard,

To contradict what I just said. I think just having the LSA's in any
order will still help. As we have a Master slave model for DD exchange
the same will not affect the order in which LSA's are sent out.

The total number of LSA's exchanged will still be the total number of LSA's.

Thanks,
Vishwas

On undefined, Vishwas Manral <vishwas.ietf@gmail.com> wrote:
> Hi Richard,
>
>  I think the draft is good and helpful.
>
>  Besides the changes already mentioned below, one more point that could
>  help is to actually send the LSA's in DB description packets in
>  different orders. If we probably run between two similar
>  implementations and bring up a new link between two routers (which are
>  already in connected in the same area - the optimization may not
>  help).
>
>  Thanks,
>  Vishwas
>
>
>
>  On undefined, Richard Ogier <ogier@earthlink.net> wrote:
>  > During the recent IESG review of this draft, it was mentioned
>  >  that there are no known implementations of this database
>  >  exchange optimization (other than the OSPF-MDR implementation
>  >  available from Boeing).  It is trivial to modify an existing
>  >  OSPF implementation to use this optimization, and I am including
>  >  a patch below for the Quagga 0.99.9 implementation of OSPFv3.
>  >  This patch was tested using the GTNetS simulator.
>  >
>  >  You can download the source code for Quagga 0.99.9 at
>  >  http://www.quagga.net/download/
>  >
>  >  To incorporate the optimization, put the "diff" code below in
>  >  a file called "patch_file" (you might have to correct any
>  >  wraparound), and apply the patch to the file
>  >
>  >  quagga-0.99.9/ospf6d/ospf6_message.c
>  >
>  >  I.e., go to the above directory and run
>  >
>  >  patch ospf6_message.c < patch_file
>  >
>  >  To activate the optimization, you must define DBEX_OPT.
>  >
>  >  Richard
>  >
>  >  558a559,572
>  >   >
>  >   > #ifdef DBEX_OPT  // From draft-ietf-ospf-dbex-opt
>  >   >       // If his is newer or same as mine, then remove mine
>  >   >       // from summary_list for neighbor
>  >   >       struct ospf6_lsa *mine_summary;
>  >   >       if (mine != NULL && ospf6_lsa_compare (his, mine) <= 0)
>  >   >       {
>  >   >         mine_summary = ospf6_lsdb_lookup (his->header->type,
>  >  his->header->id,
>  >   >                                   his->header->adv_router,
>  >  on->summary_list);
>  >   >         if (mine_summary)
>  >   >       ospf6_lsdb_remove (mine_summary, on->summary_list);
>  >   >       }
>  >   > #endif // DBEX_OPT
>  >   >
>  >  780a795,808
>  >   >
>  >   > #ifdef DBEX_OPT  // From draft-ietf-ospf-dbex-opt
>  >   >       // If his is newer or same as mine, then remove mine
>  >   >       // from summary_list for neighbor
>  >   >       struct ospf6_lsa *mine_summary;
>  >   >       if (mine != NULL && ospf6_lsa_compare (his, mine) <= 0)
>  >   >       {
>  >   >         mine_summary = ospf6_lsdb_lookup (his->header->type,
>  >  his->header->id,
>  >   >                                   his->header->adv_router,
>  >  on->summary_list);
>  >   >         if (mine_summary)
>  >   >       ospf6_lsdb_remove (mine_summary, on->summary_list);
>  >   >       }
>  >   > #endif // DBEX_OPT
>  >   >
>  >  _______________________________________________
>  >  OSPF mailing list
>  >  OSPF@ietf.org
>  >  https://www.ietf.org/mailman/listinfo/ospf
>  >
>
_______________________________________________
OSPF mailing list
OSPF@ietf.org
https://www.ietf.org/mailman/listinfo/ospf