Re: [OSPF] Implementation of draft-ietf-ospf-dbex-opt-02.txt

"Vishwas Manral" <vishwas.ietf@gmail.com> Wed, 02 April 2008 21:38 UTC

Return-Path: <ospf-bounces@ietf.org>
X-Original-To: ospf-archive@optimus.ietf.org
Delivered-To: ietfarch-ospf-archive@core3.amsl.com
Received: from core3.amsl.com (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id D96593A6CA2; Wed, 2 Apr 2008 14:38:45 -0700 (PDT)
X-Original-To: ospf@core3.amsl.com
Delivered-To: ospf@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id D9FFC28C199 for <ospf@core3.amsl.com>; Wed, 2 Apr 2008 14:38:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SmFpcuGwOCUg for <ospf@core3.amsl.com>; Wed, 2 Apr 2008 14:38:37 -0700 (PDT)
Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.172]) by core3.amsl.com (Postfix) with ESMTP id 6A6803A6DED for <ospf@ietf.org>; Wed, 2 Apr 2008 14:38:37 -0700 (PDT)
Received: by wf-out-1314.google.com with SMTP id 25so2986469wfa.31 for <ospf@ietf.org>; Wed, 02 Apr 2008 14:38:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=hmVW9GLyZyLRRpBJ8whrLHEPyKA5imAqM4ehwXPSlDY=; b=D7nlw+IKq96YdXkvBC22B9dfrR2j0dymfGKvL5v2G1WG9WM8jp+ysFfvWxp5XRkiLKzYfXnJvzmAcgqLxmAgjBzJgctQUDHriVfJ2B5Re84CXixDj8oaTlSxY/eb3LTo+ulQGbOFYyTKzACgtUN015F3BOy6t3dnwuomqbYyMZQ=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=W1hrYfRgC6dm+xczg/ESbP5/vey2P5QpUWoymas+l3OraMiGx/R+T2DEFbXnRF14IT4B2syT6TVLxwQeyKTZXDiHZ+WjJfDc20O0UqXsG8BRR0pfP0cqJYzD6NhgxveAkEOTwxxO6T+Q7cDou4h8zFdDXQa+ievLXikhR7ffmVs=
Received: by 10.142.163.14 with SMTP id l14mr6447480wfe.230.1207172317548; Wed, 02 Apr 2008 14:38:37 -0700 (PDT)
Received: by 10.143.9.18 with HTTP; Wed, 2 Apr 2008 14:38:37 -0700 (PDT)
Message-ID: <77ead0ec0804021438m7ac2863icd0ed5dd808f9ba3@mail.gmail.com>
Date: Wed, 02 Apr 2008 14:38:37 -0700
From: Vishwas Manral <vishwas.ietf@gmail.com>
To: Richard Ogier <ogier@earthlink.net>
In-Reply-To: <47F4026E.2060503@earthlink.net>
MIME-Version: 1.0
Content-Disposition: inline
References: <47F4026E.2060503@earthlink.net>
Cc: ospf@ietf.org
Subject: Re: [OSPF] Implementation of draft-ietf-ospf-dbex-opt-02.txt
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/pipermail/ospf>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ospf-bounces@ietf.org
Errors-To: ospf-bounces@ietf.org

Hi Richard,

I think the draft is good and helpful.

Besides the changes already mentioned below, one more point that could
help is to actually send the LSA's in DB description packets in
different orders. If we probably run between two similar
implementations and bring up a new link between two routers (which are
already in connected in the same area - the optimization may not
help).

Thanks,
Vishwas

On undefined, Richard Ogier <ogier@earthlink.net> wrote:
> During the recent IESG review of this draft, it was mentioned
>  that there are no known implementations of this database
>  exchange optimization (other than the OSPF-MDR implementation
>  available from Boeing).  It is trivial to modify an existing
>  OSPF implementation to use this optimization, and I am including
>  a patch below for the Quagga 0.99.9 implementation of OSPFv3.
>  This patch was tested using the GTNetS simulator.
>
>  You can download the source code for Quagga 0.99.9 at
>  http://www.quagga.net/download/
>
>  To incorporate the optimization, put the "diff" code below in
>  a file called "patch_file" (you might have to correct any
>  wraparound), and apply the patch to the file
>
>  quagga-0.99.9/ospf6d/ospf6_message.c
>
>  I.e., go to the above directory and run
>
>  patch ospf6_message.c < patch_file
>
>  To activate the optimization, you must define DBEX_OPT.
>
>  Richard
>
>  558a559,572
>   >
>   > #ifdef DBEX_OPT  // From draft-ietf-ospf-dbex-opt
>   >       // If his is newer or same as mine, then remove mine
>   >       // from summary_list for neighbor
>   >       struct ospf6_lsa *mine_summary;
>   >       if (mine != NULL && ospf6_lsa_compare (his, mine) <= 0)
>   >       {
>   >         mine_summary = ospf6_lsdb_lookup (his->header->type,
>  his->header->id,
>   >                                   his->header->adv_router,
>  on->summary_list);
>   >         if (mine_summary)
>   >       ospf6_lsdb_remove (mine_summary, on->summary_list);
>   >       }
>   > #endif // DBEX_OPT
>   >
>  780a795,808
>   >
>   > #ifdef DBEX_OPT  // From draft-ietf-ospf-dbex-opt
>   >       // If his is newer or same as mine, then remove mine
>   >       // from summary_list for neighbor
>   >       struct ospf6_lsa *mine_summary;
>   >       if (mine != NULL && ospf6_lsa_compare (his, mine) <= 0)
>   >       {
>   >         mine_summary = ospf6_lsdb_lookup (his->header->type,
>  his->header->id,
>   >                                   his->header->adv_router,
>  on->summary_list);
>   >         if (mine_summary)
>   >       ospf6_lsdb_remove (mine_summary, on->summary_list);
>   >       }
>   > #endif // DBEX_OPT
>   >
>  _______________________________________________
>  OSPF mailing list
>  OSPF@ietf.org
>  https://www.ietf.org/mailman/listinfo/ospf
>
_______________________________________________
OSPF mailing list
OSPF@ietf.org
https://www.ietf.org/mailman/listinfo/ospf