[P2PSIP] Review of draft-ietf-p2psip-ddr-00

Marc Petit-Huguenin <petithug@acm.org> Sun, 06 November 2011 16:40 UTC

Return-Path: <petithug@acm.org>
X-Original-To: p2psip@ietfa.amsl.com
Delivered-To: p2psip@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BE67D21F8511 for <p2psip@ietfa.amsl.com>; Sun, 6 Nov 2011 08:40:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.657
X-Spam-Level:
X-Spam-Status: No, score=-102.657 tagged_above=-999 required=5 tests=[AWL=-0.057, BAYES_00=-2.599, NO_RELAYS=-0.001, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hUYoeQQ+j4pE for <p2psip@ietfa.amsl.com>; Sun, 6 Nov 2011 08:40:39 -0800 (PST)
Received: from implementers.org (implementers.org [IPv6:2604:3400:dc1:41:216:3eff:fe5b:8240]) by ietfa.amsl.com (Postfix) with ESMTP id 203E721F84FC for <p2psip@ietf.org>; Sun, 6 Nov 2011 08:40:39 -0800 (PST)
Received: from [IPv6:2001:470:1f05:616:213:d4ff:fe04:3e08] (shalmaneser.org [IPv6:2001:470:1f05:616:213:d4ff:fe04:3e08]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client CN "petithug", Issuer "implementers.org" (verified OK)) by implementers.org (Postfix) with ESMTPS id 5C33620138 for <p2psip@ietf.org>; Sun, 6 Nov 2011 16:31:32 +0000 (UTC)
Message-ID: <4EB6B884.6040008@acm.org>
Date: Sun, 06 Nov 2011 08:40:36 -0800
From: Marc Petit-Huguenin <petithug@acm.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20111010 Iceowl/1.0b2 Icedove/3.1.15
MIME-Version: 1.0
To: P2PSIP Mailing List <p2psip@ietf.org>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: [P2PSIP] Review of draft-ietf-p2psip-ddr-00
X-BeenThere: p2psip@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Peer-to-Peer SIP working group discussion list <p2psip.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/p2psip>, <mailto:p2psip-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/p2psip>
List-Post: <mailto:p2psip@ietf.org>
List-Help: <mailto:p2psip-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/p2psip>, <mailto:p2psip-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Nov 2011 16:40:39 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

1. Section 6.2.2: second paragraph

The new option is defined as EXTENSIVE_ROUTING_MODE_TYPE here and in other
sections, but is define as extensive_routing_mode in the IANA registry in
section 9.1.


2. Section 6.2.2, structure definition

The enum does not follow the usual syntax:

enum { (0), DDR(1), RPR(2), (255) } RouteMode;

OverlayLink should be OverlayLinkType.

In the next paragraph, Transport should be OverlayLinkType.

- -- 
Marc Petit-Huguenin
Personal email: marc@petit-huguenin.org
Professional email: petithug@acm.org
Blog: http://blog.marc.petit-huguenin.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk62uH8ACgkQ9RoMZyVa61eugACgiMQucyky9UbXc4RWJbyf9tLR
/ssAoKjYg/9a5WftuowTMImI/qF615KQ
=61db
-----END PGP SIGNATURE-----