IETF Logo Mail Archive

Re: [P2PSIP] Review of draft-ietf-p2psip-ddr-00

ZongNing <zongning@huawei.com> Mon, 07 November 2011 05:39 UTC

Return-Path: <zongning@huawei.com>
X-Original-To: p2psip@ietfa.amsl.com
Delivered-To: p2psip@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9D37521F8490 for <p2psip@ietfa.amsl.com>; Sun, 6 Nov 2011 21:39:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -105.416
X-Spam-Level:
X-Spam-Status: No, score=-105.416 tagged_above=-999 required=5 tests=[AWL=1.183, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 89gOfiUGitxx for <p2psip@ietfa.amsl.com>; Sun, 6 Nov 2011 21:39:30 -0800 (PST)
Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [119.145.14.67]) by ietfa.amsl.com (Postfix) with ESMTP id 11CDE21F84FB for <p2psip@ietf.org>; Sun, 6 Nov 2011 21:39:29 -0800 (PST)
Received: from huawei.com (szxga04-in [172.24.2.12]) by szxga04-in.huawei.com (iPlanet Messaging Server 5.2 HotFix 2.14 (built Aug 8 2006)) with ESMTP id <0LU900B8NZPI5P@szxga04-in.huawei.com> for p2psip@ietf.org; Mon, 07 Nov 2011 13:39:19 +0800 (CST)
Received: from szxrg02-dlp.huawei.com ([172.24.2.119]) by szxga04-in.huawei.com (iPlanet Messaging Server 5.2 HotFix 2.14 (built Aug 8 2006)) with ESMTP id <0LU9009K5ZPIUS@szxga04-in.huawei.com> for p2psip@ietf.org; Mon, 07 Nov 2011 13:39:18 +0800 (CST)
Received: from szxeml205-edg.china.huawei.com ([172.24.2.119]) by szxrg02-dlp.huawei.com (MOS 4.1.9-GA) with ESMTP id AEU31775; Mon, 07 Nov 2011 13:39:18 +0800
Received: from SZXEML403-HUB.china.huawei.com (10.82.67.35) by szxeml205-edg.china.huawei.com (172.24.2.57) with Microsoft SMTP Server (TLS) id 14.1.270.1; Mon, 07 Nov 2011 13:39:16 +0800
Received: from SZXEML504-MBS.china.huawei.com ([169.254.8.86]) by szxeml403-hub.china.huawei.com ([10.82.67.35]) with mapi id 14.01.0270.001; Mon, 07 Nov 2011 13:39:12 +0800
Date: Mon, 07 Nov 2011 05:38:54 +0000
From: ZongNing <zongning@huawei.com>
In-reply-to: <4EB6B884.6040008@acm.org>
X-Originating-IP: [10.138.41.128]
To: Marc Petit-Huguenin <petithug@acm.org>, P2PSIP Mailing List <p2psip@ietf.org>
Message-id: <B0D29E0424F2DE47A0B36779EC6667791485E764@szxeml504-mbs.china.huawei.com>
MIME-version: 1.0
Content-type: text/plain; charset="us-ascii"
Content-language: zh-CN
Content-transfer-encoding: 7bit
Accept-Language: en-US, zh-CN
Thread-topic: [P2PSIP] Review of draft-ietf-p2psip-ddr-00
Thread-index: AQHMnKLWdhlwkkpRHkesFwYg+k5rTJWg5X9Q
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
X-CFilter-Loop: Reflected
References: <4EB6B884.6040008@acm.org>
Subject: Re: [P2PSIP] Review of draft-ietf-p2psip-ddr-00
X-BeenThere: p2psip@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Peer-to-Peer SIP working group discussion list <p2psip.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/p2psip>, <mailto:p2psip-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/p2psip>
List-Post: <mailto:p2psip@ietf.org>
List-Help: <mailto:p2psip-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/p2psip>, <mailto:p2psip-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Nov 2011 05:39:31 -0000

Hi, Marc,

Thank you for the review. I will submit a new revision after the IETF submission reopen.

BR,
Ning Zong

-----Original Message-----
From: p2psip-bounces@ietf.org [mailto:p2psip-bounces@ietf.org] On Behalf Of Marc Petit-Huguenin
Sent: Monday, November 07, 2011 12:41 AM
To: P2PSIP Mailing List
Subject: [P2PSIP] Review of draft-ietf-p2psip-ddr-00

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

1. Section 6.2.2: second paragraph

The new option is defined as EXTENSIVE_ROUTING_MODE_TYPE here and in other
sections, but is define as extensive_routing_mode in the IANA registry in
section 9.1.


2. Section 6.2.2, structure definition

The enum does not follow the usual syntax:

enum { (0), DDR(1), RPR(2), (255) } RouteMode;

OverlayLink should be OverlayLinkType.

In the next paragraph, Transport should be OverlayLinkType.

- -- 
Marc Petit-Huguenin
Personal email: marc@petit-huguenin.org
Professional email: petithug@acm.org
Blog: http://blog.marc.petit-huguenin.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk62uH8ACgkQ9RoMZyVa61eugACgiMQucyky9UbXc4RWJbyf9tLR
/ssAoKjYg/9a5WftuowTMImI/qF615KQ
=61db
-----END PGP SIGNATURE-----
_______________________________________________
P2PSIP mailing list
P2PSIP@ietf.org
https://www.ietf.org/mailman/listinfo/p2psip

v2.23.0 | Report a Bug | By Email