Re: [payload] Proposed changes to draft-ietf-payload-flexible-fec-scheme-11

Ben Campbell <ben@nostrum.com> Fri, 07 December 2018 18:39 UTC

Return-Path: <ben@nostrum.com>
X-Original-To: payload@ietfa.amsl.com
Delivered-To: payload@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1FA33130FA8 for <payload@ietfa.amsl.com>; Fri, 7 Dec 2018 10:39:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.68
X-Spam-Level:
X-Spam-Status: No, score=-1.68 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=nostrum.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q_DHg1DmAMjr for <payload@ietfa.amsl.com>; Fri, 7 Dec 2018 10:39:20 -0800 (PST)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 735C5130FA6 for <payload@ietf.org>; Fri, 7 Dec 2018 10:39:17 -0800 (PST)
Received: from [10.0.1.45] (cpe-70-122-203-106.tx.res.rr.com [70.122.203.106]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id wB7IcxiS012515 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Fri, 7 Dec 2018 12:39:01 -0600 (CST) (envelope-from ben@nostrum.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nostrum.com; s=default; t=1544207942; bh=jR8w+VLjrcKPnfENtqouh1vnwldG8CpVA8aA8yaLU/Q=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=gryVINVJ4BjlNVeiNTgg2/hUgjLmGAmHk1S3QBod3QEyJlBASwFDL7+kX0tui0ZeT IRjO9qtmdBgyG8V9L5MgVNjZyB5T5TeTa6SMMqi1gOca/rmZVIVcDQhU0zEJUgJzZL NRkmqAmPenWMt0g+i01ENMzepHmHenekZjD7b9wQ=
X-Authentication-Warning: raven.nostrum.com: Host cpe-70-122-203-106.tx.res.rr.com [70.122.203.106] claimed to be [10.0.1.45]
From: Ben Campbell <ben@nostrum.com>
Message-Id: <39E260D1-2B02-4684-9624-150CBD0B6456@nostrum.com>
Content-Type: multipart/signed; boundary="Apple-Mail=_1C931877-2BD4-4E8A-A697-0D63BB194BE7"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 12.1 \(3445.101.1\))
Date: Fri, 07 Dec 2018 12:38:58 -0600
In-Reply-To: <AM0PR07MB4979BC9A6166E17F735C96BF95AA0@AM0PR07MB4979.eurprd07.prod.outlook.com>
Cc: Giridhar Mandyam <mandyam@qti.qualcomm.com>, "Roni Even (A)" <roni.even@huawei.com>, "Ali C. Begen" <ali.begen@networked.media>, "Mo Zanaty (mzanaty)" <mzanaty@cisco.com>, "payload@ietf.org" <payload@ietf.org>
To: Magnus Westerlund <magnus.westerlund@ericsson.com>
References: <113ed79cfaa347edb8b89a7ac5af3d69@NASANEXM01C.na.qualcomm.com> <c222823717894a13b7dd54a6620d9312@NASANEXM01C.na.qualcomm.com> <AM0PR07MB4979BC9A6166E17F735C96BF95AA0@AM0PR07MB4979.eurprd07.prod.outlook.com>
X-Mailer: Apple Mail (2.3445.101.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/payload/Ajxjgg39tqgy0yBHdnyk-pzQm4Y>
Subject: Re: [payload] Proposed changes to draft-ietf-payload-flexible-fec-scheme-11
X-BeenThere: payload@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Audio/Video Transport Payloads working group discussion list <payload.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/payload>, <mailto:payload-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/payload/>
List-Post: <mailto:payload@ietf.org>
List-Help: <mailto:payload-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/payload>, <mailto:payload-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Dec 2018 18:39:22 -0000

Does this resolve the discussion?

Thanks!

Ben (who apologies for not having caught up on the thread yet.)


> On Dec 7, 2018, at 7:26 AM, Magnus Westerlund <magnus.westerlund@ericsson.com> wrote:
> 
> Hi,
> 
> Looks good to me.
> 
> Cheers
> 
> Magnus
> 
> On 2018-12-06 22:03, Giridhar Mandyam wrote:
>> Sorry - sent out too soon.
>> 
>> The last change should have read:
>> 
>> "The RTP Stream Identifier Source Description [I.-D.ietf-avtext-rid] is a format that can be used to identify a single RTP source stream along with an associated repair stream.  However, this specification already defines a method of source and repair stream identification that can enable protection of multiple source streams with a single repair stream.  Therefore the RTP Stream Idenfifer Source Description SHOULD NOT be used for the Flexible FEC payload format."
>> 
>> -----Original Message-----
>> From: Giridhar Mandyam
>> Sent: Thursday, December 6, 2018 12:59 PM
>> To: 'Roni Even (A)' <roni.even@huawei.com>; Magnus Westerlund <magnus.westerlund@ericsson.com>
>> Cc: Ali C. Begen <ali.begen@networked.media>; Mo Zanaty (mzanaty) <mzanaty@cisco.com>; Ben Campbell <ben@nostrum.com>; payload@ietf.org
>> Subject: Proposed changes to draft-ietf-payload-flexible-fec-scheme-11
>> 
>> Magnus,
>> Here is the proposal to respond to your comments in https://mailarchive.ietf.org/arch/msg/payload/MkHU_bBWl_Dp1jRhlvnFpZB1ewI.
>> 
>> Thanks,
>> -Giri Mandyam
>> 
>> A. > At least in discussing this with Mo F2F I got the impression that the plan was to also be explicit about what the lack of it (ToP) means, i.e. it can be any of the self describing usages, so a mix of retransmission and FEC is possible.
>> 
>> Proposed change:  The following sentence will be added to each ToP section:  " The absence of the ToP field means that all protection types are allowed."
>> 
>> B. >The use of draft-ietf-avtext-rid RepairedRtpStreamId is not at all  needed, even if it could be used in a sub-set of applications of  flexfec. It would work in same RTP Session, with a single repair RTP stream only protects a singe source RTP stream. But, considering the possibility of repair of multiple source streams and different RTP Sessions, I think an explicit statement that this SHOULD NOT be used for the payload format would be good to include.
>> 
>> Proposed Change #1:  Add a reference to https://tools.ietf.org/html/draft-ietf-avtext-rid-09 in the Informative References section.
>> 
>> Proposed Change #2:  Add Section 7.2, entitled "On the Use of the RTP Stream Identifier Source Description", with the following text:
>> 
>> "The RTP Stream Identifier Source Description [I.-D.ietf-avtext-rid] is a format that can be used to identify a single RTP source stream along with an associated repair stream.  However, since this specification already defines a method of source and repair stream identification that can enable protection of Multiple source streams with a single repair stream.  Therefore the RTP Stream Idenfifer Source Description SHOULD NOT be used for the Flexible FEC payload format."
>> 
>> -----Original Message-----
>> From: Roni Even (A) <roni.even@huawei.com>
>> Sent: Thursday, December 6, 2018 3:03 AM
>> To: Magnus Westerlund <magnus.westerlund@ericsson.com>; Giridhar Mandyam <mandyam@qti.qualcomm.com>
>> Cc: Ali C. Begen <ali.begen@networked.media>; Mo Zanaty (mzanaty) <mzanaty@cisco.com>; Ben Campbell <ben@nostrum.com>; payload@ietf.org
>> Subject: RE: [payload] I-D Action: draft-ietf-payload-flexible-fec-scheme-10.txt
>> 
>> Hi,
>> Can you send these messages to the list.
>> I am wondering about ToP, I saw a previous question from Magnus about using for example ToP 0,3 (FEC plus retransmission) not allowed by current definition in 5.1.1 but if I read section 4.2.2.3 first paragraph correctly it is allowed I also assume that Magnus asked for the default value for ToP and I did not see any text in 5.1.1 Roni Even
>> 
>> 
>> -----Original Message-----
>> From: Magnus Westerlund [mailto:magnus.westerlund@ericsson.com]
>> Sent: Thursday, December 06, 2018 10:32 AM
>> To: Ben Campbell
>> Cc: Ali C. Begen; Mo Zanaty (mzanaty); Roni Even (A); ART ADs; Giridhar Mandyam
>> Subject: Re: [payload] I-D Action: draft-ietf-payload-flexible-fec-scheme-10.txt
>> 
>> Hi,
>> 
>> I have responded on the first question. Although I don't understand why that went off-list.
>> 
>> I want to comment on the second paragraph below.
>> 
>> On 2018-12-05 19:36, Ben Campbell wrote:
>>>> On Dec 5, 2018, at 12:28 PM, Giridhar Mandyam <mandyam@qti.qualcomm.com> wrote:
>>>> 
>>>> I believe his first comment on ToP needs to be addressed in the revision.  I believe his second comment is more problematic, because it refers to a standards-track document that has not achieved RFC status yet (i.e. it may undergo changes), and I am not sure it will help the document.
>>>> 
>>>> 
>> Considering that draft-ietf-avtext-rid is approved and stuck in RFC-editor missref state on cluster 238 I don't see this as a reason for not addressing my raised issue.
>> 
>> The reason I do want to raise this is that flexfec could be used in a sub-set of cases, but is not necessary in any cases as the linking to the source flow is provided in the FLEXFEC RTP packet. Thus, for making it clear that it is not needed, I think an explicit statement should be added to that effect. If we don't have a statement we might find situations where people will attempt to apply it and gets into the confusion if they try the FEC mode with multiple source SSRCs where it doesn't work.
>> 
>> Cheers
>> 
>> Magnus Westerlund
>> 
>> ----------------------------------------------------------------------
>> Network Architecture & Protocols, Ericsson Research
>> ----------------------------------------------------------------------
>> Ericsson AB                 | Phone  +46 10 7148287
>> Torshamnsgatan 23           | Mobile +46 73 0949079
>> SE-164 80 Stockholm, Sweden | mailto: magnus.westerlund@ericsson.com
>> ----------------------------------------------------------------------
>> 
>> 
> 
> --
> 
> Magnus Westerlund
> 
> ----------------------------------------------------------------------
> Network Architecture & Protocols, Ericsson Research
> ----------------------------------------------------------------------
> Ericsson AB                 | Phone  +46 10 7148287
> Torshamnsgatan 23           | Mobile +46 73 0949079
> SE-164 80 Stockholm, Sweden | mailto: magnus.westerlund@ericsson.com
> ----------------------------------------------------------------------
>