[Pce] Rtgdir early review of draft-ietf-pce-pcep-extension-native-ip-23

Ines Robles via Datatracker <noreply@ietf.org> Fri, 21 July 2023 16:46 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: pce@ietf.org
Delivered-To: pce@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id ECD86C152574; Fri, 21 Jul 2023 09:46:41 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ines Robles via Datatracker <noreply@ietf.org>
To: rtg-dir@ietf.org
Cc: draft-ietf-pce-pcep-extension-native-ip.all@ietf.org, pce@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 11.5.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <168995800195.26090.14291141918520350529@ietfa.amsl.com>
Reply-To: Ines Robles <mariainesrobles@googlemail.com>
Date: Fri, 21 Jul 2023 09:46:41 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/0mh6jX-9fU10cSzcKxf8iImsKIk>
Subject: [Pce] Rtgdir early review of draft-ietf-pce-pcep-extension-native-ip-23
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jul 2023 16:46:42 -0000

Reviewer: Ines Robles
Review result: Has Issues

Review: draft-ietf-pce-pcep-extension-native-ip-23
Reviewer: Ines Robles

Summary:

The document defines the Path Computation Element Communication Protocol (PCEP)
extension for Central Control Dynamic Routing (CCDR) based application in
Native IP network.

No major issues found.

Minor issues found as follows:

Section 3: Terminology:

* "The following terms are defined in this document" --> The following
terminology is used in this document? Since the mentioned terms are not defined
in the document, for example, the case of CCDR

* Also, The document claims that it defines QoS, but it is not mentioned in the
text.

Section 4.1: TBD1: Path is a Native IP path --> TBD1: Path is a Native IP TE
path ? (To be aligned with IANA section description)

Section 6: Error-value=TBD18, BPI/PPR --> Error-value=TBD18, BPI/PPA ?

Section 6.1: "... Peer IP address)" closed parenthesis, but it is not open.

Figure 1: the arrow from PCE to R3 is bidirectional, the arrow from PCE to R1
and R7 are unidirectional, is this correct?

Section 6.2: "... explicit routes operate similar to static routes..." --> in
which aspects is similar? in which aspects are dissimilar?

"...network management protocols..." --> it would be nice to add some examples
of network management protocols between brackets.

Figure 2: The same as Fig. 1. The arrow from PCE to R1 is unidirectional, R2,
R4 are bidirectional, is this correct?

Section 9: "..cares only..." --> ...focuses only on...?

Section 10: "...light weight BGP session setup..": It would be nice to add a
reference to it.

Section 12: Should the security considerations mention RFC9050?

Section 13.4: errors:: --> errors:

Question: Should this document add a section for Manageability Considerations,
like in RFC9050?

Thanks for this document,
Ines.