[Pce] 答复: Rtgdir early review of draft-ietf-pce-pcep-extension-native-ip-23

Aijun Wang <wangaijun@tsinghua.org.cn> Wed, 26 July 2023 04:01 UTC

Return-Path: <wangaijun@tsinghua.org.cn>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1006BC157902; Tue, 25 Jul 2023 21:01:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.909
X-Spam-Level:
X-Spam-Status: No, score=-1.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0FlN1lFHhDLh; Tue, 25 Jul 2023 21:01:53 -0700 (PDT)
Received: from mail-m121145.qiye.163.com (mail-m121145.qiye.163.com [115.236.121.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 14066C151701; Tue, 25 Jul 2023 21:01:47 -0700 (PDT)
Received: from LAPTOP09T7970K (unknown [219.142.69.75]) by mail-m121145.qiye.163.com (Hmail) with ESMTPA id D99BD80007F; Wed, 26 Jul 2023 12:01:44 +0800 (CST)
From: Aijun Wang <wangaijun@tsinghua.org.cn>
To: 'Ines Robles' <mariainesrobles@googlemail.com>, rtg-dir@ietf.org
Cc: draft-ietf-pce-pcep-extension-native-ip.all@ietf.org, pce@ietf.org
References: <168995800195.26090.14291141918520350529@ietfa.amsl.com>
In-Reply-To: <168995800195.26090.14291141918520350529@ietfa.amsl.com>
Date: Wed, 26 Jul 2023 12:01:46 +0800
Message-ID: <000501d9bf75$e5924eb0$b0b6ec10$@tsinghua.org.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQGraCPu+3SXF3BqKQBSCsEcGxIyarAoCScw
Content-Language: zh-cn
X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFKTEtLSjdXWS1ZQUlXWQ8JGhUIEh9ZQVkaSBhJVkpJSEoZSkxJHxgaGFUTARMWGhIXJB QOD1lXWRgSC1lBWUlKQlVKT0lVTUJVTE5ZV1kWGg8SFR0UWUFZT0tIVUpNT0lMTlVKS0tVSkJLS1 kG
X-HM-Tid: 0a89905c244bb03akuuud99bd80007f
X-HM-MType: 1
X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MDI6CBw5Nz1MVk0yCRc9IhUK KwpPFD1VSlVKTUJLSE9PSktNS0lCVTMWGhIXVQwaFRwaEhEOFTsPCBIVHBMOGlUUCRxVGBVFWVdZ EgtZQVlJSkJVSk9JVU1CVUxOWVdZCAFZQU9DQ0k3Bg++
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/ch6U7KW5BB7A6CFecLnI3qFbPSg>
Subject: [Pce] 答复: Rtgdir early review of draft-ietf-pce-pcep-extension-native-ip-23
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jul 2023 04:01:59 -0000

Hi, Ines:

Thanks for your review. I have updated the draft according to your suggestions.
The detail replies are inline below:


Best Regards

Aijun Wang
China Telecom

-----邮件原件-----
发件人: Ines Robles via Datatracker [mailto:noreply@ietf.org] 
发送时间: 2023年7月22日 0:47
收件人: rtg-dir@ietf.org
抄送: draft-ietf-pce-pcep-extension-native-ip.all@ietf.org; pce@ietf.org
主题: Rtgdir early review of draft-ietf-pce-pcep-extension-native-ip-23

Reviewer: Ines Robles
Review result: Has Issues

Review: draft-ietf-pce-pcep-extension-native-ip-23
Reviewer: Ines Robles

Summary:

The document defines the Path Computation Element Communication Protocol (PCEP) extension for Central Control Dynamic Routing (CCDR) based application in Native IP network.

No major issues found.

Minor issues found as follows:

Section 3: Terminology:

* "The following terms are defined in this document" --> The following terminology is used in this document? Since the mentioned terms are not defined in the document, for example, the case of CCDR
[WAJ] Update to the sentence as you suggested "The following terminology is used in this document"

* Also, The document claims that it defines QoS, but it is not mentioned in the text.
[WAJ] Delete it.

Section 4.1: TBD1: Path is a Native IP path --> TBD1: Path is a Native IP TE path ? (To be aligned with IANA section description)
[WAJ] Update

Section 6: Error-value=TBD18, BPI/PPR --> Error-value=TBD18, BPI/PPA ?
[WAJ] Update to BPI/PPA

Section 6.1: "... Peer IP address)" closed parenthesis, but it is not open.
[WAJ] Delete the parenthesis, also add some contents to the mentioned sentence.

Figure 1: the arrow from PCE to R3 is bidirectional, the arrow from PCE to R1 and R7 are unidirectional, is this correct?
[WAJ] They should be all bidirectional, updated.

Section 6.2: "... explicit routes operate similar to static routes..." --> in which aspects is similar? in which aspects are dissimilar?
[WAJ]Change the sentence to "Such explicit routes operate the same as static routes installed by network management protocol(NETCONF/YANG)"

"...network management protocols..." --> it would be nice to add some examples of network management protocols between brackets.
[WAJ] Added. One example, NETCONF/YANG

Figure 2: The same as Fig. 1. The arrow from PCE to R1 is unidirectional, R2,
R4 are bidirectional, is this correct?
[WAJ] Bidirectional, Updated. Together with Figure 3&4

Section 9: "..cares only..." --> ...focuses only on...?
[WAJ] Updated.

Section 10: "...light weight BGP session setup..": It would be nice to add a reference to it.
[WAJ] Delete the "light weight", because it is not one formal terminology.

Section 12: Should the security considerations mention RFC9050?
[WAJ] Added.

Section 13.4: errors:: --> errors:
[WAJ] Updated.

Question: Should this document add a section for Manageability Considerations, like in RFC9050?
[WAJ]Because there is no special consideration for the manageability considerations, I add one sentence at the section 10 "Deployment Considerations", as "Manageability considerations that described in RFC9050 should be followed"

Thanks for this document,
Ines.