Re: [Pce] Shepherd's review of draft-ietf-pce-pcep-service-aware-09

Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com> Fri, 24 June 2016 11:20 UTC

Return-Path: <Jonathan.Hardwick@metaswitch.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F3F1912B01E; Fri, 24 Jun 2016 04:20:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=metaswitch.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dGNH2DuLRoK8; Fri, 24 Jun 2016 04:19:59 -0700 (PDT)
Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0741.outbound.protection.outlook.com [IPv6:2a01:111:f400:fc10::741]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6474F12DA09; Fri, 24 Jun 2016 04:19:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=metaswitch.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eyFuq2llmSFqw//AZptffNzirwXN4DjDldSBp5HyHC4=; b=oW95gtKHZEo/H6AQusNG2vbpqGMUzRzvPOpfW3LaVKg4d0EvaiJ/zBTBfsZBzQ1b+CtfJ9l+QulSAv9SlclzfeZomgAQxIHo3Ak1r2SANWoy80wT/wI86B4D11t0THX6g3QOdxCUZ7j5sQMT68LqZ3G/H9Zajodhu4y9UGWYoIs=
Received: from BY2PR0201MB1910.namprd02.prod.outlook.com (10.163.75.152) by BY2PR0201MB1911.namprd02.prod.outlook.com (10.163.75.153) with Microsoft SMTP Server (TLS) id 15.1.523.12; Fri, 24 Jun 2016 11:19:39 +0000
Received: from BY2PR0201MB1910.namprd02.prod.outlook.com ([10.163.75.152]) by BY2PR0201MB1910.namprd02.prod.outlook.com ([10.163.75.152]) with mapi id 15.01.0523.019; Fri, 24 Jun 2016 11:19:39 +0000
From: Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com>
To: Dhruv Dhody <dhruv.dhody@huawei.com>, "draft-ietf-pce-pcep-service-aware@ietf.org" <draft-ietf-pce-pcep-service-aware@ietf.org>
Thread-Topic: Shepherd's review of draft-ietf-pce-pcep-service-aware-09
Thread-Index: AdHK+qd569EyV7DnTIyQVV5K+RvEzACAn9NQABfPCsAAIP6XwAAJ49Ng
Date: Fri, 24 Jun 2016 11:19:39 +0000
Message-ID: <BY2PR0201MB19109CC0B42670D3DC014A0E842E0@BY2PR0201MB1910.namprd02.prod.outlook.com>
References: <BY2PR0201MB1910E774724DA73B87BC7915842C0@BY2PR0201MB1910.namprd02.prod.outlook.com> <23CE718903A838468A8B325B80962F9B8C89EDB9@blreml501-mbb> <BY2PR0201MB19107036237C2807C7B05BFD842D0@BY2PR0201MB1910.namprd02.prod.outlook.com> <23CE718903A838468A8B325B80962F9B8C8A2177@blreml501-mbb>
In-Reply-To: <23CE718903A838468A8B325B80962F9B8C8A2177@blreml501-mbb>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jonathan.Hardwick@metaswitch.com;
x-originating-ip: [81.132.84.33]
x-ms-office365-filtering-correlation-id: ae084034-adac-4dcc-28f0-08d39c216eb9
x-microsoft-exchange-diagnostics: 1; BY2PR0201MB1911; 6:/AqeBttYEW0EQmt5qu/ajyJZZ2xNQRhaCPvWHNRbFeOxBsnBOk8JzX9tNabdQkPoX4EY2k2vXwasa+lg7collgWC6LSjS1JlMsaJndoWZmluholt+6o/xKCU4wEy83hoM0WXe3VvO/nHwV0p6zJPJGDZSZzgH2Voyo2aUdKNI8/8fn6juRMRSdYrLyM1bi79ZqXG3EsQOsDRwxgDU4NAANxuNp6sCsz1+HYfz2spReyiVYeBmhHXrNboLyj9cESSld221iPOFPwqx0mFQzMzACxGedtGfjVvSVh/1vDxO0fLjSR9m/D48R+ZI+dDWO94; 5:SJZLfI2jSk0NuFi5QQ8QXiRqkomtRkCZOzLEtrZVOACafdaqktyswjcxqbaAg94p2lNLKCjBUfeD3wxLN5rXmlEjmEvyVL9DqhqCabYPyYbRn2SeeU3BxCeL+wKMQ3PjY8gnWZ5pYzKq/k5AFSJNdg==; 24:xLzM6MJdHq9KXWtRarY/jNnr2bVXvHMqk6xWZA6WPllI3WsLSakolAR9oVX7jZblH3z7YRcJwnZKeQx5bsJNwkPAGrI/0NV7BXUXQLuDC/A=; 7:9ciGNpVL984kNhXJ3QFDl6HZPSJ79aW+jDDmX4C6PkF0euC2fl/DmBmYIMF9tI7xNMThItOQbzuxZDHecC0Tt9j2SSQbwT3fPqcpkLi40e02n3WnCfsDtVx2rD9Aou8LBBlqh19Pk/2uMQq16cNXMnAlJZLI9mZbyeA3IBY94n1nreJVZG4DNNpKyuZkObXjyVeptNgbc5qFsni2lhOtBRiTBatM15U0+KtqlUa4OJEcetADjHeI7gzYfZUWzZROB40FXsQJVTanF2MblhwqJw==
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0201MB1911;
x-microsoft-antispam-prvs: <BY2PR0201MB1911347DBCA0419AA447CF44842E0@BY2PR0201MB1911.namprd02.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(50582790962513)(21748063052155);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BY2PR0201MB1911; BCL:0; PCL:0; RULEID:; SRVR:BY2PR0201MB1911;
x-forefront-prvs: 0983EAD6B2
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(76104003)(189002)(199003)(7736002)(7696003)(33656002)(7846002)(5003600100003)(4326007)(81156014)(122556002)(189998001)(8676002)(74316001)(2906002)(92566002)(86362001)(2950100001)(2900100001)(2501003)(16236675004)(19625215002)(68736007)(76176999)(77096005)(10400500002)(19300405004)(54356999)(50986999)(19580395003)(19580405001)(66066001)(87936001)(5001770100001)(97736004)(101416001)(93886004)(9686002)(81166006)(3660700001)(99286002)(76576001)(15975445007)(106356001)(11100500001)(3280700002)(230783001)(3846002)(790700001)(102836003)(6116002)(8936002)(105586002)(5002640100001)(586003); DIR:OUT; SFP:1102; SCL:1; SRVR:BY2PR0201MB1911; H:BY2PR0201MB1910.namprd02.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en;
received-spf: None (protection.outlook.com: metaswitch.com does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_BY2PR0201MB19109CC0B42670D3DC014A0E842E0BY2PR0201MB1910_"
MIME-Version: 1.0
X-OriginatorOrg: metaswitch.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2016 11:19:39.4003 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 9d9e56eb-f613-4ddb-b27b-bfcdf14b2cdb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1911
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/17tej738dMvcO5ber3dkTrJPetI>
Cc: "pce@ietf.org" <pce@ietf.org>
Subject: Re: [Pce] Shepherd's review of draft-ietf-pce-pcep-service-aware-09
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Jun 2016 11:20:02 -0000

Thanks Dhruv,

A couple more typos I noticed:
Section 3: "a consistent ways of" should be "... way of"
Section 4.1.1.1: "the encoding for path delay metric value" should be "... the path delay metric value"

See also [JEH2] inline below.

Cheers
Jon

From: Dhruv Dhody [mailto:dhruv.dhody@huawei.com]
Sent: 24 June 2016 11:25
To: Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com>; draft-ietf-pce-pcep-service-aware@ietf.org
Cc: pce@ietf.org
Subject: RE: Shepherd's review of draft-ietf-pce-pcep-service-aware-09

Hi Jon,

Thank you fixing the grammatical issues with the document.
One change I would like to make is to the term "Fractional Percentage Link Loss" to just  "Fractional Link Loss".
[JEH2] OK. But in section 4.3 you actually changed it to "percentage link loss".  Also, in 4.1.3 and 4.3, I think the abbreviation should be FL(L) not FPL(L)?  I read the P in FPL as "Percentage".

<snip>

What do you think?
[JEH] I think fine.  Although rather than "network performance information" could we have "network performance metrics"?
[Dhruv2] I am worried that might be seen as excluding the bandwidth utilization related optimization criteria. I wanted to use a generic term and thus  "network performance information".
[JEH2] I'm only concerned that the existing sentence does not scan well.  How about "3. A PCC must be able to request that a PCE optimizes a path using any network performance criteria."

<snip>