Re: [Pce] WG Last Call for draft-ietf-pce-pcep-yang-19

tom petch <ietfc@btconnect.com> Thu, 06 October 2022 11:43 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EB368C14F73B for <pce@ietfa.amsl.com>; Thu, 6 Oct 2022 04:43:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.911
X-Spam-Level:
X-Spam-Status: No, score=-1.911 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VpHDcNBUI-PT for <pce@ietfa.amsl.com>; Thu, 6 Oct 2022 04:43:45 -0700 (PDT)
Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2119.outbound.protection.outlook.com [40.107.247.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 65620C14F720 for <pce@ietf.org>; Thu, 6 Oct 2022 04:43:45 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LNmIja4cux9pv27fKH/kzkRsq0+Z5pAR0n3yhMKmOn3n+AeLkuTcxsotZaPxihQWcDKuvRG+CGo0Le0iaVAnBO7BqAVm5Qq5NoDJTcrz4mRlTPj1H5l/mI3o7oEA9RoEGma8NHPUiDs4Mi0qczjQXukbVnJpDrq618uE0n/loGLnhT+f5gFNHfoNpCDpVLZ6e4U4DcBpiunyyU1JEfzow9Hg4zze2GgNnHrQKVbxXA7XyM25q777hYrLjyuv16MaUtZEaPFluXD2IVypiLeFdt0ApGP30MxygLWyTTObH5C2Ot7V4qjvTlRTvW4c5Z75CULLkSJ25dyfGz6SlNc9fw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AQy1BhRQaplr4DMSSJlaMCwDzSI8WdDJ84qbH4vre9g=; b=EDa2U0B2n8biSms3Z/LrG76CK/Zy9PKdGVOwiHvnLArdgwyn9tzTnpm+0bsOJD/OxtlH7C0TXkZ/sXxU3XRj5yldGg54jILf9X5oCiKmQKyJlkiCc2/dXI6kNp7JW3N4bfHLOA4zJiw2H3qzDjcvl6Vm/o/k3nPwDrSPSutSPUwoeMTWqqS3JK0ua75X20EOpejHkL0GjbniPZCPog8B889seVrFzgun7FK4ar6CHcC7BO5WXDJVkwUkBZpyBxzEgJQQeIRufOHtdl/OQcZb7NM6GK0vfRt4IdvIGllbbz6FcAGSRJ3Pex8bC2YfOZ4/YaW78GPOfzC0V340T+Tlow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AQy1BhRQaplr4DMSSJlaMCwDzSI8WdDJ84qbH4vre9g=; b=exaQ+18PBFTqfEZywSIIG9IELjWbDNwWrGouQoon4DnfQ93c17p4G9Qd/VLOTkHi0AJiMUAZ/+snw396DFtFWcCr1HkfiTFazgbxGuNP4GPJjQWeHTYe6JU2TlGlV21RiXjB7nPlUyA0LKVjp66M8UWnrJWoNVlFp3VOMMPnHq8=
Received: from AM7PR07MB6248.eurprd07.prod.outlook.com (2603:10a6:20b:134::11) by PR3PR07MB7019.eurprd07.prod.outlook.com (2603:10a6:102:78::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.9; Thu, 6 Oct 2022 11:43:42 +0000
Received: from AM7PR07MB6248.eurprd07.prod.outlook.com ([fe80::d188:3110:6650:e155]) by AM7PR07MB6248.eurprd07.prod.outlook.com ([fe80::d188:3110:6650:e155%9]) with mapi id 15.20.5709.010; Thu, 6 Oct 2022 11:43:42 +0000
From: tom petch <ietfc@btconnect.com>
To: "julien.meuric@orange.com" <julien.meuric@orange.com>, "pce@ietf.org" <pce@ietf.org>
Thread-Topic: [Pce] WG Last Call for draft-ietf-pce-pcep-yang-19
Thread-Index: AQHY0agp+SKthfRihE+fI17gKTPE/a4BQPQv
Date: Thu, 06 Oct 2022 11:43:42 +0000
Message-ID: <AM7PR07MB62489587051CF86BCA5DC867A05C9@AM7PR07MB6248.eurprd07.prod.outlook.com>
References: <0d3e71b7-738b-a5f6-852d-0e46f24129f5@orange.com>
In-Reply-To: <0d3e71b7-738b-a5f6-852d-0e46f24129f5@orange.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=btconnect.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: AM7PR07MB6248:EE_|PR3PR07MB7019:EE_
x-ms-office365-filtering-correlation-id: 5ac57033-97ee-4c7e-3e23-08daa79004d5
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: pstoSU9Xm/W4sfB6Y8tDTlCQxywmBUtGdS0k7MZDlkGEZ5UON/Pd6G7/s1YhxEH1GEAFEQC5y+9sLu3ibDcK1RnzTZd7nqf5SN1qy32gA23QXGHq0ZoYHQzp04Yldaq3hY+Tm4fgK3rFVv9d94M+9GF9/j9URIgNBzIimhd9T1gu7+yV9WGCq39iuwsr2ekaEluUIauqjaX+90CvDFe2xfVMZQ9CSavHQqTtaf9gBb+VPqe6gHe98zxI3eD7vQlnCErmjqm98QMRVYptZwbk1dosMI4BSrv8M5FM0DOWZZ2kP9OsXII5lDmdN4BSVEKUPyOsBf5aRfyL88eCufIm4Oz/8LHgDmUY3d4qIQgeBwt15+18DW5l4ggC0Xf3o3RA00zM359ycms0hMV/5eFLSSH/1LGgfM0Uaq3NiwmkjEU/dqXCMgdmhLSJm7A0E/becjR4kGGEKL7gAWKiY3FkyJgBG4UMWc1dlW/HlB8Em6OSSw0AIEFuksAzBd/FGlv/eSlvb7ul1yityR9JxOo4H8vOiHH0hBR8LztWdgkrjKw0e7hTcOmsKQS19xbOBcrBrGNJxDRQUhKtH2uL7lxmXVbfsXhRvZ8SLxP1vUgFn0jU1Zm6ChYMaQO9xR5NGX+pXhycedTORgt/AMd7BT+tfjJusPSXOVHseB7JqUa30qYbp3++PNCR0Re5InAQFCDmlxey199diupfxuZ7ud4ALclwD6LnS/kPAKCleKt8VRhFmjj9pQFxtQW8FREHlHUFlZSOwusFg0iIhhl1VbJnRw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR07MB6248.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(366004)(396003)(136003)(376002)(346002)(451199015)(5660300002)(41300700001)(52536014)(8936002)(2906002)(91956017)(8676002)(66446008)(66476007)(122000001)(64756008)(66946007)(76116006)(82960400001)(26005)(83380400001)(86362001)(38100700002)(6506007)(9686003)(7696005)(33656002)(186003)(38070700005)(478600001)(66556008)(71200400001)(316002)(55016003)(110136005); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: y6x+6OCq8u5NI7QGy2v36aZxA2DCSdzGwVm2wOYGluqBHAubik6BKU9r4/TQfU2fVgDloHbK4qrAx34YapHvddzrNq5t5onjGUsBugqqHhZqIStO43v1Lm98HBkZtyFTpUZoMVr43YscPfs65mrfs1J5Pf3D5ngPOzoyXfG5F2KJAkDtFgSbbBvFXhgoKk1m2X9dTd2ZPnH4MvBenyz/qRLvj4/fQchcTbtnDP+fnLCZz8gJas0wqAwFEYJMJrd9SuDskoFGl8fdXFoSlaQLHGWu1i8LiIWGKPlR3qwRYtFyrDHdtzaPULu0bLR1gqEEpMNNbzO9B7+e95i0iUWu+Kl/ZhDmu6TEY1fQZzhee17hSyeqjKOsJvFXfcVKcouEnSmIDDTSg0dl4LigekoC1GryK1omZvlO1cW3pRhTSkU2grxp00Iip4gYxN4RlxqqBsIySXIZaqvUALwwT2YxATxiygGIL1tWOZ9U2CdngqbXqwIs1XvLYDHsljrUvSRTr+lVPjqAIv/PWwO7oik/ME7MOKbLchXLA1QpDF6ZmZdZeV6I0oEETvQWyg3XcxIOXj/jK0MSPHX0u8E3xFIYl+UVMjHL5XAl+PBLe8366wqtADwO0SYnehL2kh4djV/5VzEtcTunRkDd4X+C/K3zN+uMSIUv4S49ucNVR+5KiPzdSn3WGnJrOzg/vvlj5pj/FkpS7dZg6cn1CB23KYdaNBnogdOh4BuqrwOD8uQumLmyLFiV8GXQ2EFdUchtGVs7vfFTwnU+mAhet9AqTUGgpf6qUv47gomvhTE4ED3dp6j48OsJbfAtsBwD4PYZRd8biFcfWh5DmsS6xOL1wUVVSm6tit7bDtI8hgK8JKnLo9qd/HwJrd+6ZZTQHCwMGrOT3g4TYvqHOtjtYguxu+T38Czv8PtLkOvj4caCJvfp3D7XapGrgxMB50oEnNwJ7IaYk/klh/+wnRowlHTTx6FaS2r5orI65XIRvx9eygjnuh4QiNwnwZgrKLH4TGfbM6bccY2r4mKHFyCqVC8EItiLTCmS183xorh0Cek4CXJ3mN30zBZC2sONuFH1o9IYp4w6WKcjrDks5bOTma1RBFV27SkGuc6OZj5mf4yamBMOgeEoUMnWG9PqTaMzBilF5vq2pfLvEHrRwXj5W8koloulu+zbNHtrZ4+dmg31nehO76pQDjGiwym/9sB6decoCaS9/zWPd5/IdQ+0XXwXlH3Kh7x2STIz3UqcK9PpD6cmDlH4EZQM7ORSLeyd+IWffri2QiVcpI4s6zZ0DxO4QxVHejDZopwz1NJS33p5P+FZdRjYFnbQSoDjrPNvRAD8KN/dRaYVfd7TTbrxNpGSFV6wILAg5K/MP7ESwxwRcJcVj1JfG8akwJ8r7aTwwQruBFj8fpcAUDrsZz7k5PN+hGDJNQwXLEB53+F8EOPtXWAFnyo25YyaG2136cVcb6+pkRz9iRqfWw3B9z/FLFKVOASmLPf/wmvhaYdPWQ9aS42JL8KwHXDpVynlLqEtNad8DHBh1YEeN43QxLm5aa+cJzxjxLNf8+qs+bt+aNHoIJfGZjMWI5xjqRJp7dq0koIiFZUF
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM7PR07MB6248.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ac57033-97ee-4c7e-3e23-08daa79004d5
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2022 11:43:42.3934 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TheNNbtGLHmcWW2JlIRJmFnJFY0xR7L89SgBLiSCTRrDTpVuIQxVSOpPuxWTNU6oUQ4PzJrK09F4/VqV30H66w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR07MB7019
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/MudjgcbJzLkmfcfV-BQj8vMrFGM>
Subject: Re: [Pce] WG Last Call for draft-ietf-pce-pcep-yang-19
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Oct 2022 11:43:50 -0000

From: Pce <pce-bounces@ietf.org> on behalf of julien.meuric@orange.com <julien.meuric@orange.com>
Sent: 26 September 2022 14:01

This message starts a 2-week WG Last Call for
draft-ietf-pce-pcep-yang-19. Please review and share any feedback using
the PCE mailing list.
This WGLC will end on Tuesday October 11.

<tp>
I commented before that this has  inadequate security since it mandates TLS1.3 where early data opens the door to all sorts of nasties.  Here are my other comments.

pce-pcep-stateful-pce-gmpls I think is now RFC8779

s.4.1.1.1 just one List I see

s.6.1 the list is also keyed on lsp-id

The YANG module has lower case must/should; is this intended?

The timer names are not those of RFC5440 - perhaps worth a note giving the mapping even if it is only hyphen-minus

container SR
set to true if SR is enabled
Where is that enabled, for what scope?

likewise msd; other I-D decompose MSD three ways on a per signalling basis, I am not clear which MSD applies here.  A bit like MTU, it  might need a context to be clear.

The reference for path-key looks like it is a line too long

RFC8231 says srp-id ffffffff is reserved in which case the range should not be ..max; this was correct in -18

I do not understand the use of must + error-message for config false.  I am used to it for validating an update and cannot see when this message will be generated.  This occurs in a number of places.

RPC often have a nacm default-deny-all

s.9 
The YANG modules   .../is/are/ 

Tom Petch


Thanks,

Julien