[Pce] RtgDir: Early Review of draft-ietf-pce-pcep-flowspec-05.txt - "PCEP Extension for Flow Specification"

"Acee Lindem (acee)" <acee@cisco.com> Tue, 22 October 2019 17:28 UTC

Return-Path: <acee@cisco.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4D7A9120025; Tue, 22 Oct 2019 10:28:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.098
X-Spam-Level:
X-Spam-Status: No, score=-12.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_COMMENT_SAVED_URL=1.391, HTML_MESSAGE=0.001, MANY_SPAN_IN_TEXT=1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_HTML_ATTACH=0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=JTo2CmF+; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=D2jJr0Hp
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5-y36x0MOzcU; Tue, 22 Oct 2019 10:28:42 -0700 (PDT)
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CC8A012008A; Tue, 22 Oct 2019 10:28:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=149216; q=dns/txt; s=iport; t=1571765321; x=1572974921; h=from:to:cc:subject:date:message-id:mime-version; bh=cxB//qIGD6up1WaEAn0vbGkJP4M2PsTwgRpmKMs55ak=; b=JTo2CmF+fiCHZ4SrsPVOzFXoJKzbwFxzV/bDC8Ess0yGLkaookImbLaB zn5TQ2zSCNsbPo8iRAOK4tKRMVGBkK1Quh+7YNsZOHx726AojSc6/4cs0 bJV3EqDkqYZmYeKTW3i1MPPSAtOSRGFv2acVvDNz83q+GBLy/DId7mHFg U=;
X-Files: Diff_ draft-ietf-pce-pcep-flowspec-05.txt.orig - draft-ietf-pce-pcep-flowspec-05.txt.html : 96169
IronPort-PHdr: =?us-ascii?q?9a23=3AGF8PURyLjg2T03jXCy+N+z0EezQntrPoPwUc9p?= =?us-ascii?q?sgjfdUf7+++4j5YRGN/u1j2VnOW4iTq+lJjebbqejBYSQB+t7A+GsHbIQKUh?= =?us-ascii?q?YEjcsMmAl1CcWIBGXwLeXhaGoxG8ERHFI=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CvAQDJOq9d/4MNJK1bChoBAQEBAQE?= =?us-ascii?q?BAQEDAQEBAREBAQECAgEBAQGBe4EcLyQFJwVsVyAECyqEJoFfgWgDileLEop?= =?us-ascii?q?ghG2BQoEQA1QCBwEBAQwBASUIAgEBgUyBPoE2GYMTJDgTAgMJAQEEAQEBAgE?= =?us-ascii?q?FBG2FCwgkDIVOFggBCAoTAQElEgERARoCJAECBwIEMBcQBAENExSDAAGCRgM?= =?us-ascii?q?uAQIMpxkCgTiIYXWBMoJ+AQEFgTgCg04YghAHCYE2hRaGeRiBf4EQAScfgwq?= =?us-ascii?q?CVwsBAQIBF4ELERMvCQwBgmMygiyJSoM2DwMJgl2FOoEShjSBbIMsimRuCoI?= =?us-ascii?q?kg0WCZWSCEoJDBT+EHoRhG4I7coFKhReELYsTjjaBP4ZokSACBAIEBQIOAQE?= =?us-ascii?q?FgWkigVhwFTsqAYJBCUcQFFZhgSskERIVbwEFgkaFFIU/dAEBgSeOfAEB?=
X-IronPort-AV: E=Sophos;i="5.68,217,1569283200"; d="html'217?scan'217,208,217";a="651998948"
Received: from alln-core-1.cisco.com ([173.36.13.131]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 22 Oct 2019 17:28:39 +0000
Received: from XCH-ALN-008.cisco.com (xch-aln-008.cisco.com [173.36.7.18]) by alln-core-1.cisco.com (8.15.2/8.15.2) with ESMTPS id x9MHSc1r013552 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 22 Oct 2019 17:28:39 GMT
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by XCH-ALN-008.cisco.com (173.36.7.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 22 Oct 2019 12:28:36 -0500
Received: from xhs-rcd-003.cisco.com (173.37.227.248) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 22 Oct 2019 13:28:00 -0400
Received: from NAM01-SN1-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 22 Oct 2019 12:28:00 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z2IiDtJNEZ73zqK6oi4Wa4ANVtS7BNQoifT6d1WGjQO4+yt2iG6F/xe867ZeRsy8TcpUiRzDcFplxyibe7VggZ1mlAwB2ATGjO4YrPB/PgcUM4HMCzjRw5Iqu4NxoEEnaTdHnSW0m5YRhRuQGX81U4h5gdN0e1rWfQv57pwNJ34pv5O3HAqd02B2W09IZqHhUNkrZ5in8CslafP8xVhBkSVVVuzO18MaeNmu3uN4BllVysQjtWiLobFVxf9xGd1ic7wLPVAOXRVJmvWGuTgLR1VkkWFFYQRinZY3Nt7TzKwTBMrrKSlXqKoPPVdgOTO/+/SORBXi6N3RzC4+ibTjrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A7XHUFddZbooauL5HthtkSb0EVHD7rvfnnuhFfzk460=; b=M9zsCa1QuqMTs4X9EVu8YOZXxzDCt8n4wtPAqbK8aSWjRrNyyfsPx0sVFTzETYN/QKc+osHXkICGMLGG/nmK4FdUGq37KvmsLJT2mUT6Cm1QWZzo1V2RId41tRLLPSlP2od1pX0ma0DuoLTlaIY5SeX03qQJ7WKETQP2BPykIBsfuc/AZy5l+l9WZm8ckrKbPtit18DOgm6724zzCZAwH1I6Txi+e3JxrJ47W11f7+qtt2bqu24YpqpAHXseg2ikxciIYPipqAk5ct5LMJHu569JqECLa3Nuq/DJPxvxrXsGuA5SjUWJuNTNSVnX8AbAS+m9UIWSjmJbNQofi1hRNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A7XHUFddZbooauL5HthtkSb0EVHD7rvfnnuhFfzk460=; b=D2jJr0HpLxbb1pH3xwGzNzYZaLkxJQ3XX+7YbWBA1WRthkvV7sN8lXWADXPTMQZi4dXPxl2CpQS91Ix/DaXKpl5BZYekht1pJkqXjCfTik1eeOTdmb0Vu8mimDOEKxWLCs52EdHMIXJCufGc7N8/XUOJs8vrYX/yMkSzgU8tEFA=
Received: from MN2PR11MB4221.namprd11.prod.outlook.com (52.135.38.14) by MN2PR11MB4222.namprd11.prod.outlook.com (52.135.36.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.20; Tue, 22 Oct 2019 17:27:59 +0000
Received: from MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::787e:8cf4:6217:9f56]) by MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::787e:8cf4:6217:9f56%4]) with mapi id 15.20.2347.029; Tue, 22 Oct 2019 17:27:59 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Routing ADs <rtg-ads@tools.ietf.org>, "draft-ietf-pce-pcep-flowspec@ietf.org" <draft-ietf-pce-pcep-flowspec@ietf.org>
CC: "pce@ietf.org" <pce@ietf.org>, Routing Directorate <rtg-dir@ietf.org>
Thread-Topic: RtgDir: Early Review of draft-ietf-pce-pcep-flowspec-05.txt - "PCEP Extension for Flow Specification"
Thread-Index: AQHViP4MtH6x+n2/sU2hLmfZzonfOg==
Date: Tue, 22 Oct 2019 17:27:59 +0000
Message-ID: <2B1BFBB7-702E-4E0F-BE3E-1A46D6FA7A15@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=acee@cisco.com;
x-originating-ip: [2001:420:c0c4:1008::334]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f273be7e-406f-4dc6-6a46-08d757152f25
x-ms-traffictypediagnostic: MN2PR11MB4222:
x-ms-exchange-purlcount: 19
x-microsoft-antispam-prvs: <MN2PR11MB4222281F5B55ED75D7F98595C2680@MN2PR11MB4222.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 01986AE76B
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(136003)(39860400002)(346002)(396003)(199004)(189003)(81166006)(2616005)(7736002)(33656002)(91956017)(2906002)(316002)(478600001)(76116006)(25786009)(4326008)(5660300002)(6506007)(256004)(71190400001)(71200400001)(14444005)(5024004)(81156014)(9326002)(486006)(86362001)(6436002)(64756008)(36756003)(66446008)(476003)(99286004)(8936002)(66946007)(54896002)(66616009)(66476007)(54906003)(110136005)(6306002)(6116002)(66556008)(14454004)(6486002)(8676002)(99936001)(966005)(46003)(186003)(102836004)(6512007)(2501003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4222; H:MN2PR11MB4221.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: peVCxlsgO2mO6lAjv+DNNcxQSxdpJt/P4nIaQxvt126k+7O+RXr9Fcki2upznHQb4AoKgPdLHRQdB8QLYEGEFBDodyIjllp+R1SZsgfBiMTj0GveNj5sDlC11B6NrWi72iH7088LvC3xY5dTqgQW1OeLyqhPepAH7R0EkBh9juxs4Or3GOYHB25SLEYrGbOXDlfOs/D3xjwE6cMAaacjP1hCe7XLpCxnkCupwMKMIxrJaKPcwQw/R4lgHg6WaNXrFZTsVOJfQrGmqKF7MIaPMShgnSSeVXAWNpk8DmhDKtIzEQQ+3Nap1guzvW6PKSgvz7quxjnbod8VLbhRJNk73tzkntayaoYYKUbKz7L834ashZlAVEcAOQVAoUz0G5al3ixyn2YM+mq62SwIriL56rcjJa5EIuA+YSo0R9nw3BlSE58mqFRRcnnirq+YpsnMbOLOJoV+DWrU2TipRAwql2J8Vn3jI+ig1DbKtT2DYZw=
x-ms-exchange-transport-forked: True
Content-Type: multipart/mixed; boundary="_004_2B1BFBB7702E4E0FBE3E1A46D6FA7A15ciscocom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f273be7e-406f-4dc6-6a46-08d757152f25
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2019 17:27:59.1406 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VSYPie8qBqjLEvZtsR65QRIuqmdW3JZMXpjsxsfeR75UeaiUqapv8aqmp8w4Po6z
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4222
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.18, xch-aln-008.cisco.com
X-Outbound-Node: alln-core-1.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/QW4uE8lU--ZlFRGxAOf7Soe4frQ>
Subject: [Pce] RtgDir: Early Review of draft-ietf-pce-pcep-flowspec-05.txt - "PCEP Extension for Flow Specification"
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 17:28:49 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft.
The Routing Directorate seeks to review all routing or routing-related
drafts as they pass through IETF last call and IESG review, and
sometimes on special request. The purpose of the review is to provide
assistance to the Routing ADs. For more information about the Routing
Directorate, please see ​

  http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs,
it would be helpful if you could consider them along with any other
IETF Early Review/Last Call  comments that you receive, and strive to
resolve them through discussion or by updating the draft.

Document: draft-ietf-pce-pcep-flowspec-05.txt
Reviewer: Acee Lindem
Review Date: 10/22/2019
IETF LC End Date: N/A
Intended Status: Standards Track

Summary:
This document is basically ready for further discussion and WG Last Call,
but has nits that should be considered prior to publication.

Comments:

 The draft is extremely easy to read and understand. This is an early
 review yet the document is in better shape than most documents I review
 during Working Group Last Call. I don't even follow the PCE Working
 Group but believe I could consume the entire draft with only a
 rudimentary understanding of the PCE protocol and having read and
 followed RFC 5575.

Major Issues: None

Minor Issues: None

Nits:

  I have a question and a few suggestions:

    1. For the multicast flow filter TLVs, is there some reason why
       the S-bit and G-bit respectively indicate that the fields are
       NOT used? In most protocol encodings, a Set bit indicates that
       a field is used and a Clear bit indicates that it is not used.
       Also, all zeros has also been used a wildcard specification
       but I guess you preferred something explicit.

    2. For IGPs, we always hyphenate Bit definitions. However, in this
       specification, the Bit definitions are not hyphenated other
       than in the IANA section. Being the LSR chair, I'd prefer
       consistency with the IGP specifications.

    3. In most IETF specifications, "headend" is a single compound
       word.

    4. In section 9, could you indicate that the only change is adding
       the <flowspec-list>? This seems to be the case but it would be
       good to state it explicitly.

    5. I have attached an RFCDIFF of suggested editorial changes.


Thanks,
Acee