Re: [Pce] I-D Action: draft-ietf-pce-sr-p2mp-policy-03.txt

Dhruv Dhody <dhruv.ietf@gmail.com> Fri, 10 March 2023 07:56 UTC

Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ED95DC19E108; Thu, 9 Mar 2023 23:56:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.095
X-Spam-Level:
X-Spam-Status: No, score=-2.095 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4_HqtdOX3ndp; Thu, 9 Mar 2023 23:56:34 -0800 (PST)
Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [IPv6:2607:f8b0:4864:20::e31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 90DD8C17EA47; Thu, 9 Mar 2023 23:56:34 -0800 (PST)
Received: by mail-vs1-xe31.google.com with SMTP id o6so3899686vsq.10; Thu, 09 Mar 2023 23:56:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678434993; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YCNMPrHyhzkdZBN2b0Bh/QPMhCF8PdWNfzDDWw0lUJQ=; b=k/kfxsdKkBbP0WcTJdeblHDUGc07ww4eOwQeNvZwB0V6CDWr3BMSSZAop7aEc4XYPo b+WXhAB74YF/viS3RkSDcqcs0wZjYhRL7H4czIzc1ZfZuvdOpDdd3DFIt7XRFApKJXJ6 pn6zBx2wDtQumfoGA47qz8UzRbc2GstJ+DCqI4WFi6B83jDsLFz6uEfU/xEbwiaJPldB LVoihYHalx0ZnQmFw2rm1H59u4ULuSAwXFGSoHh5aYc1MKkAQWRqZ8rP/H4LEjFD8vPt DcaSdto13UhJsYZgZxKkcZWVz28UGt0HMhHQHQmVePnpe42as7rmOIX/0vbbVR/YozO2 EoiQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678434993; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YCNMPrHyhzkdZBN2b0Bh/QPMhCF8PdWNfzDDWw0lUJQ=; b=SqDXR7DDNMYxECcORpbFfQ2o+hnl9c+C6t8DuVMc3VQdMkhDyWyLinrE2TxTABQMEQ 5iazGooKuEAY7iijr8VgxW8W15FaTpTfqEyIyMggtmwoj2JJEyNjxrtiX+mMLk+Z3tg3 YQJZv1NI/tugeybBvBR37epQklDSwv8dhlEq9LW/wZ9NMUtFZNoblx+dTU+M5MZuJSli VgLAqyoRi1GQepF6kHxV8pTzEZVUFnONWaH1j8KNrwsutE5se7dbyBDiKC11+Gf0Zy4r 2j+Sf6PaXvXxaWJT6koalIYFAc2SQlEgbNZkJXneqI0AP4IaJghze8k0unmI2yVY85RA B6Sg==
X-Gm-Message-State: AO0yUKWig1b8/2mWHmlRm7dinewAXhFi7+xAXxPxEYZR48bHAaxU7n+w QMl1frDtfY+bLugPH0EaXKups7F54ggaxcr2Czs=
X-Google-Smtp-Source: AK7set92tSrpDE3dXPZyrbBS9piymNxybyDHeW+YReFUL9cSxFzGWivnod4uNqHkT6Oe0T1vUInhpCZtiiaESYrBFhI=
X-Received: by 2002:a05:6102:2146:b0:411:c07e:f666 with SMTP id h6-20020a056102214600b00411c07ef666mr16118365vsg.0.1678434993244; Thu, 09 Mar 2023 23:56:33 -0800 (PST)
MIME-Version: 1.0
References: <167839134474.24444.4654728106875545303@ietfa.amsl.com> <CAP7zK5Ze0TN2vnyrdy_Rk6cSArr3nK7EbZ3wF96vXkO20LeK0w@mail.gmail.com> <PH0PR08MB65811338ADDC08AFBB87628691BA9@PH0PR08MB6581.namprd08.prod.outlook.com>
In-Reply-To: <PH0PR08MB65811338ADDC08AFBB87628691BA9@PH0PR08MB6581.namprd08.prod.outlook.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Fri, 10 Mar 2023 13:25:56 +0530
Message-ID: <CAB75xn5z-TSA=5aj9RjzgmGjbj97Qc6nfDcxAOtn8ajGi-=R5Q@mail.gmail.com>
To: "Hooman Bidgoli (Nokia)" <hooman.bidgoli@nokia.com>
Cc: Dhruv Dhody <dd@dhruvdhody.com>, "draft-ietf-pce-sr-p2mp-policy@ietf.org" <draft-ietf-pce-sr-p2mp-policy@ietf.org>, "pce@ietf.org" <pce@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000008d0dfb05f6871975"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/b-6QsUvB-Miu7tTp4itz9HpUGlQ>
Subject: Re: [Pce] I-D Action: draft-ietf-pce-sr-p2mp-policy-03.txt
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Mar 2023 07:56:39 -0000

Hi Hooman,

On Fri, Mar 10, 2023 at 9:36 AM Hooman Bidgoli (Nokia) <
hooman.bidgoli@nokia.com> wrote:

> Hi Dhruv
>
>
>
> Thanks for comments, I can change it in the next draft.
>

Thank you!



> There was just too many question on how the packet looks like and I felt
> drawing the bytes could help.
>
>
>
> Just to ensure you are looking for something like  below:
>
> Note: the questions I am getting is to give a rough view of how the packet
> looks in different cases.
>
>
>
> Common header
>
> Lsp object with plsp-id = 1, Root= A, tree-id=y, instance-id = L1
>
> Association object
>
> P2MP SR policy ID with root=A, tree-ID=y
>
> P2MP SR Policy name = “name”
>
> …
>
> CCI with cc-id =x , label 0
>
>               Path-attribute ero-path id =1 , backup-path id =2
>
>               SR-ERO ipv4-addr = NHD1, SID= d1
>
>
>
> Etc…
>
>
>

Yes, this is so much more readable. With example the focus should be more
on where the attributes are carried and not so much on the packet format
which is anyways covered when we define various Objects/TLVs.

Thanks!
Dhruv



> Thanks
>
> Hooman
>
>
>
> *From:* Pce <pce-bounces@ietf.org> *On Behalf Of *Dhruv Dhody
> *Sent:* Thursday, March 9, 2023 10:48 PM
> *To:* draft-ietf-pce-sr-p2mp-policy@ietf.org
> *Cc:* pce@ietf.org
> *Subject:* Re: [Pce] I-D Action: draft-ietf-pce-sr-p2mp-policy-03.txt
>
>
>
>
>
> *CAUTION:* This is an external email. Please be very careful when
> clicking links or opening attachments. See http://nok.it/ext for
> additional information.
>
>
>
> Hi,
>
>
>
> Just one quick comment! I remember making this point earlier as well, and
> if the WG disagrees please let me know!
>
>
>
> I am not a fan of the format used by the examples in this I-D (which are
> in the form of PCEP packet structures)  -
> https://datatracker.ietf.org/doc/html/draft-ietf-pce-sr-p2mp-policy-03#section-7.2
>
> It might be useful for someone debugging (well we also have tools that do
> that way better and show results in a much more friendly way), but not for
> a general reader of an RFC.
>
>
>
> You will also note that this is not the usual style followed in the PCE WG
> document. P2MP RFCs have examples in past, my request would be to follow
> the same style and not to deviate -
>
> https://www.rfc-editor.org/rfc/rfc8623.html#section-6.6
>
> https://www.rfc-editor.org/rfc/rfc8306.html#section-3.10
>
>
>
> Thanks!
>
> Dhruv (as a WG participant)
>
>
>
>
>
>
>
> On Fri, Mar 10, 2023 at 1:19 AM <internet-drafts@ietf.org> wrote:
>
>
> A New Internet-Draft is available from the on-line Internet-Drafts
> directories.
> This Internet-Draft is a work item of the Path Computation Element WG of
> the IETF.
>
>         Title           : PCEP extensions for p2mp sr policy
>         Authors         : Hooman Bidgoli
>                           Daniel Voyer
>                           Saranya Rajarathinam
>                           Anuj Budhiraja
>                           Tarek Saad
>                           Siva Sivabalan
>   Filename        : draft-ietf-pce-sr-p2mp-policy-03.txt
>   Pages           : 44
>   Date            : 2023-03-09
>
> Abstract:
>    SR P2MP policies are set of policies that enable architecture for
>    P2MP service delivery.  This document specifies extensions to the
>    Path Computation Element Communication Protocol (PCEP) that allow a
>    stateful PCE to compute and initiate P2MP paths from a Root to a set
>    of Leaves.
>
>
> The IETF datatracker status page for this Internet-Draft is:
> https://datatracker.ietf.org/doc/draft-ietf-pce-sr-p2mp-policy/
>
> There is also an htmlized version available at:
> https://datatracker.ietf.org/doc/html/draft-ietf-pce-sr-p2mp-policy-03
>
> A diff from the previous version is available at:
> https://author-tools.ietf.org/iddiff?url2=draft-ietf-pce-sr-p2mp-policy-03
>
>
> Internet-Drafts are also available by rsync at rsync.ietf.org:
> :internet-drafts
>
>
> _______________________________________________
> Pce mailing list
> Pce@ietf.org
> https://www.ietf.org/mailman/listinfo/pce
>
> _______________________________________________
> Pce mailing list
> Pce@ietf.org
> https://www.ietf.org/mailman/listinfo/pce
>