Re: [pcp] pcp-base-19

Tina TSOU <Tina.Tsou.Zouting@huawei.com> Wed, 21 December 2011 18:20 UTC

Return-Path: <Tina.Tsou.Zouting@huawei.com>
X-Original-To: pcp@ietfa.amsl.com
Delivered-To: pcp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C05F921F8505 for <pcp@ietfa.amsl.com>; Wed, 21 Dec 2011 10:20:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.494
X-Spam-Level:
X-Spam-Status: No, score=-0.494 tagged_above=-999 required=5 tests=[AWL=0.001, BAYES_00=-2.599, FH_RELAY_NODNS=1.451, HELO_MISMATCH_COM=0.553, RDNS_NONE=0.1]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QL+bUsbf84WM for <pcp@ietfa.amsl.com>; Wed, 21 Dec 2011 10:20:27 -0800 (PST)
Received: from szxga03-in.huawei.com (unknown [58.251.152.66]) by ietfa.amsl.com (Postfix) with ESMTP id C29A621F84DB for <pcp@ietf.org>; Wed, 21 Dec 2011 10:20:26 -0800 (PST)
Received: from huawei.com (szxga03-in [172.24.2.9]) by szxga03-in.huawei.com (iPlanet Messaging Server 5.2 HotFix 2.14 (built Aug 8 2006)) with ESMTP id <0LWK00IXIG9T93@szxga03-in.huawei.com> for pcp@ietf.org; Thu, 22 Dec 2011 02:20:18 +0800 (CST)
Received: from szxrg02-dlp.huawei.com ([172.24.2.119]) by szxga03-in.huawei.com (iPlanet Messaging Server 5.2 HotFix 2.14 (built Aug 8 2006)) with ESMTP id <0LWK006T7G9TSI@szxga03-in.huawei.com> for pcp@ietf.org; Thu, 22 Dec 2011 02:20:17 +0800 (CST)
Received: from szxeml203-edg.china.huawei.com ([172.24.2.119]) by szxrg02-dlp.huawei.com (MOS 4.1.9-GA) with ESMTP id AFV91311; Thu, 22 Dec 2011 02:19:32 +0800
Received: from SZXEML403-HUB.china.huawei.com (10.82.67.35) by szxeml203-edg.china.huawei.com (172.24.2.55) with Microsoft SMTP Server (TLS) id 14.1.323.3; Thu, 22 Dec 2011 02:19:27 +0800
Received: from SZXEML526-MBX.china.huawei.com ([169.254.2.37]) by szxeml403-hub.china.huawei.com ([10.82.67.35]) with mapi id 14.01.0323.003; Thu, 22 Dec 2011 02:19:23 +0800
Date: Wed, 21 Dec 2011 18:19:21 +0000
From: Tina TSOU <Tina.Tsou.Zouting@huawei.com>
X-Originating-IP: [10.212.244.251]
To: Dan Wing <dwing@cisco.com>
Message-id: <C0E0A32284495243BDE0AC8A066631A80C233F2F@szxeml526-mbx.china.huawei.com>
MIME-version: 1.0
Content-type: text/plain; charset="us-ascii"
Content-language: en-US
Content-transfer-encoding: 7bit
Accept-Language: en-US, zh-CN
Thread-topic: [pcp] pcp-base-19
Thread-index: AQHMvshLlgQo2yg0SuKgPIbgmlIgJZXmCNUggACR36A=
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
X-CFilter-Loop: Reflected
Cc: "pcp@ietf.org" <pcp@ietf.org>
Subject: Re: [pcp] pcp-base-19
X-BeenThere: pcp@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: PCP wg discussion list <pcp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pcp>, <mailto:pcp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/pcp>
List-Post: <mailto:pcp@ietf.org>
List-Help: <mailto:pcp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pcp>, <mailto:pcp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Dec 2011 18:20:27 -0000

Hi all,
Some comments on pcp-base-19:

1. P17, section 6.3 / P18, section 6.4
"If the PCP server does not implement this Option, ..."
"UNSUPP_OPTION: Unsupported Option.  This error only occurs if the Option is in the mandatory-to-process range."
	 
Why do we set this restriction "only occurs if the Option is in the mandatory-to-process range."?
I think UNSUPP_OPTION error code is better than MALFORMED_OPTION if there is an unsupported optional Option. 

2. P28, section 9 
"It is REQUIRED that the PCP-controlled device assign the same
external IP address to PCP-created explicit dynamic mappings and to
implicit dynamic mappings for a given Internal Address. In the absence 
of a PCP option indicating otherwise, it is REQUIRED that all
PCP-created explicit dynamic mappings be assigned the same external
IP address."
   
How about replace "In the absence of a PCP option indicating otherwise, it is REQUIRED that all PCP-created explicit dynamic mappings be assigned the same external IP address." 
with 
"It is indicated by the PCP client that PCP-created explicit dynamic 
mappings be assigned the same external IP address, unless there are 
explicit reasons of not doing so, e.g. http://tools.ietf.org/html/draft-penno-pcp-zones-00"?
   
Because "It is REQUIRED that the PCP" give the requirement from the server's point of view, I think we should also give the requirement from the client's point of view. 
This is more or less what Dan suggested before, perhaps an oversight.

3. P38, section 10.2 
"the PCP server may not be able grant the suggested External IP Address and Port"
	 
typo? be able to?  
	 
4. P57, section 12.3
"the value of the Prefix Length pertains only to to the IPv4 portion of the address." 
	 
typo, duplicate "to"
	 
5. P59, section 13.1.1
"In many networking APIs is is difficult or	impossible to have two independent clients listening for both unicasts and multicasts on the same port at the same time.  For this reason, two ports are used."
 	 
typo, duplicate "is"
 	      
6. P61, section 13.1.4 Processing a PEER Response

the title "PEER Response", 

guess it should be "ANNOUNCE"

"then for all PCP mappings it made at that server address the client should issue new PCP requests to to recreate any lost mapping state. "

typo, duplicate "to"


Happy holidays,
Tina


-----Original Message-----
From: pcp-bounces@ietf.org [mailto:pcp-bounces@ietf.org] On Behalf Of Dan Wing
Sent: Monday, December 19, 2011 5:21 PM
To: 'PCP'
Subject: [pcp] pcp-base-19

Major changes in -19 are summarized in the Changes section, and
are:

   o  Described race condition with MAP containing PREFER_FAILURE and
      Mapping Update.

   o  Added state machine (Section 14.5).

   o  Fully integrated Rapid Recovery, with a separate Opcode having its
      own processing description.

   o  Clarified that due to Mapping Update, a single MAP or PEER request
      can receive multiple responses, each updating the previous
      request, and that the PCP client needs to handle MAP updates or
      PEER updates accordingly.

Side-by-side diffs,
http://tools.ietf.org/rfcdiff?url2=draft-ietf-pcp-base-19.txt

-d


_______________________________________________
pcp mailing list
pcp@ietf.org
https://www.ietf.org/mailman/listinfo/pcp