Re: [pcp] WGLC: draft-ietf-pcp-base-12.txt

Stuart Cheshire <cheshire@apple.com> Tue, 07 June 2011 05:07 UTC

Return-Path: <cheshire@apple.com>
X-Original-To: pcp@ietfa.amsl.com
Delivered-To: pcp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 140F521F8541 for <pcp@ietfa.amsl.com>; Mon, 6 Jun 2011 22:07:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -106.599
X-Spam-Level:
X-Spam-Status: No, score=-106.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sUT9I+8fL8Db for <pcp@ietfa.amsl.com>; Mon, 6 Jun 2011 22:07:46 -0700 (PDT)
Received: from mail-out.apple.com (mail-out.apple.com [17.151.62.49]) by ietfa.amsl.com (Postfix) with ESMTP id 2263621F8535 for <pcp@ietf.org>; Mon, 6 Jun 2011 22:07:45 -0700 (PDT)
MIME-version: 1.0
Content-transfer-encoding: 7bit
Content-type: text/plain; CHARSET="US-ASCII"
Received: from relay13.apple.com ([17.128.113.29]) by mail-out.apple.com (Oracle Communications Messaging Exchange Server 7u4-20.01 64bit (built Nov 21 2010)) with ESMTPS id <0LME003F3M8SJU02@mail-out.apple.com> for pcp@ietf.org; Mon, 06 Jun 2011 22:07:45 -0700 (PDT)
X-AuditID: 1180711d-b7c70ae00000719a-78-4dedb221ad2c
Received: from jimbu (jimbu.apple.com [17.151.62.37]) (using TLS with cipher RC4-MD5 (RC4-MD5/128 bits)) (Client did not present a certificate) by relay13.apple.com (Apple SCV relay) with SMTP id B1.92.29082.122BDED4; Mon, 06 Jun 2011 22:07:45 -0700 (PDT)
Received: from [10.0.1.2] (173-164-252-149-SFBA.hfc.comcastbusiness.net [173.164.252.149]) by cardamom.apple.com (Oracle Communications Messaging Exchange Server 7u4-20.01 64bit (built Nov 21 2010)) with ESMTPSA id <0LME002Z0M8VT020@cardamom.apple.com> for pcp@ietf.org; Mon, 06 Jun 2011 22:07:45 -0700 (PDT)
From: Stuart Cheshire <cheshire@apple.com>
In-reply-to: <9B57C850BB53634CACEC56EF4853FF653B0BA0FD@TK5EX14MBXW604.wingroup.windeploy.ntdev.microsoft.com>
Date: Mon, 06 Jun 2011 22:07:42 -0700
Message-id: <E0F7BBA6-C22E-42B6-9611-E79ABC414256@apple.com>
References: <9B57C850BB53634CACEC56EF4853FF653B0BA0FD@TK5EX14MBXW604.wingroup.windeploy.ntdev.microsoft.com>
To: pcp@ietf.org
X-Mailer: Apple Mail (2.1084)
X-Brightmail-Tracker: AAAAAA==
Subject: Re: [pcp] WGLC: draft-ietf-pcp-base-12.txt
X-BeenThere: pcp@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: PCP wg discussion list <pcp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pcp>, <mailto:pcp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/pcp>
List-Post: <mailto:pcp@ietf.org>
List-Help: <mailto:pcp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pcp>, <mailto:pcp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Jun 2011 05:07:47 -0000

My comments are below. I have text in mind to fix these things, but I haven't had time to write it up yet.

1. The definition of "subscriber" needs to be tightened up.

2. Why are some IP address fields "always 128 bits", and others are "32 or 128 bits"? Can we make this consistent?

3. Where a 128-bit IP address field contains an IPv4 address, we need to ensure that it can't inadvertently look like a valid IPv6 address as well as being a zero-padded IPv4 address.

4. Handling of the "O" bit is not fully specified for clients.

5. The THIRD_PARTY scenarios are a bit confused and self-contradictory.

6. Security for the THIRD_PARTY option needs more detailed specification.

7. PROCESSING_ERROR is unused.

8. ADDRESS_MISMATCH value is undefined.

9. How to handle responses from multiple PCP servers is underspecified. Responses don't arrive simultaneously. One arrives first, and then the other arrives later. What should the client do when the later one arrives? Undo everything it did in response to the first one?

10. Document uses both "NAT" and "NAPT". We should pick one and be consistent.

11. Use of wildcard ("0") address, port and protocol fields could be explained more clearly.

12. Don't match External_AF when validating response.

13. Is option length in bytes or 32-bit words?

14. Is FILTER Option mandatory to implement? How many filters per mapping?

15. Non-EIM seems like a confusing double negative ("non-independent"). Can we just say "EDM" ("dependent") instead?

16. Saying that an "Ethernet switch needs to perform ingress filtering" seems to be putting unreasonable demands on devices that know nothing about PCP, NAT, or even IP.

17. Why are new OpCodes "Standards Action" but new Result Codes are only "Specification Required"?

Stuart Cheshire <cheshire@apple.com>
* Wizard Without Portfolio, Apple Inc.
* www.stuartcheshire.org