Re: [pcp] Review of draft-maglione-pcp-radius-ext-05

Alan DeKok <aland@deployingradius.com> Tue, 30 April 2013 13:15 UTC

Return-Path: <aland@deployingradius.com>
X-Original-To: pcp@ietfa.amsl.com
Delivered-To: pcp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2CA3221F9BD4 for <pcp@ietfa.amsl.com>; Tue, 30 Apr 2013 06:15:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.599
X-Spam-Level:
X-Spam-Status: No, score=-102.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1fZqXx-Aerz5 for <pcp@ietfa.amsl.com>; Tue, 30 Apr 2013 06:15:18 -0700 (PDT)
Received: from power.freeradius.org (power.freeradius.org [88.190.25.44]) by ietfa.amsl.com (Postfix) with ESMTP id 4818C21F9BC5 for <pcp@ietf.org>; Tue, 30 Apr 2013 06:15:18 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by power.freeradius.org (Postfix) with ESMTP id A8F772240EBD for <pcp@ietf.org>; Tue, 30 Apr 2013 15:15:17 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at power.freeradius.org
Received: from power.freeradius.org ([127.0.0.1]) by localhost (power.freeradius.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yvDgHOmUWadZ for <pcp@ietf.org>; Tue, 30 Apr 2013 15:15:17 +0200 (CEST)
Received: from Thor-2.local (bas1-ottawa11-1176121151.dsl.bell.ca [70.26.47.63]) by power.freeradius.org (Postfix) with ESMTPSA id 202732240842 for <pcp@ietf.org>; Tue, 30 Apr 2013 15:15:17 +0200 (CEST)
Message-ID: <517FC3E4.8060900@deployingradius.com>
Date: Tue, 30 Apr 2013 09:15:16 -0400
From: Alan DeKok <aland@deployingradius.com>
User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228)
MIME-Version: 1.0
To: "pcp@ietf.org" <pcp@ietf.org>
References: <513F39CA.4070701@deployingradius.com>
In-Reply-To: <513F39CA.4070701@deployingradius.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [pcp] Review of draft-maglione-pcp-radius-ext-05
X-BeenThere: pcp@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: PCP wg discussion list <pcp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pcp>, <mailto:pcp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/pcp>
List-Post: <mailto:pcp@ietf.org>
List-Help: <mailto:pcp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pcp>, <mailto:pcp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Apr 2013 13:15:23 -0000

Alan DeKok wrote:
>   This email is a quick review of the draft-maglione-pcp-radius-ext-05
> document.  Overall, it looks fairly good.

  Another note.  Section 3 says:

   In the scenario depicted in Figure 2 the Access-Request packet
   contains a Service-Type attribute with the value Authorize Only (17),
   thus according to [RFC5080] the Access-Request packet MUST contain a
   State attribute.


  That text is identical with previous drafts using RADIUS for
authorization-only.  It's wrong.  See:

http://tools.ietf.org/html/draft-ietf-softwire-6rd-radius-attrib-06