[pim] Benjamin Kaduk's Discuss on draft-ietf-pim-igmp-mld-yang-13: (with DISCUSS and COMMENT)
Benjamin Kaduk via Datatracker <noreply@ietf.org> Mon, 27 May 2019 02:15 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: pim@ietf.org
Delivered-To: pim@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 9B95E120229; Sun, 26 May 2019 19:15:04 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Benjamin Kaduk via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-pim-igmp-mld-yang@ietf.org, Stig Venaas <stig@venaas.com>, aretana.ietf@gmail.com, pim-chairs@ietf.org, stig@venaas.com, pim@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.97.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Benjamin Kaduk <kaduk@mit.edu>
Message-ID: <155892330463.6040.689041510063921681.idtracker@ietfa.amsl.com>
Date: Sun, 26 May 2019 19:15:04 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/04qe6whZLo2X7zg1V5tOe7X066Y>
Subject: [pim] Benjamin Kaduk's Discuss on draft-ietf-pim-igmp-mld-yang-13: (with DISCUSS and COMMENT)
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 May 2019 02:15:04 -0000
Benjamin Kaduk has entered the following ballot position for draft-ietf-pim-igmp-mld-yang-13: Discuss When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html for more information about IESG DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-pim-igmp-mld-yang/ ---------------------------------------------------------------------- DISCUSS: ---------------------------------------------------------------------- I agree with Mirja that reiterating the privacy considerations of explicit tracking of group membership (with pointer to the relevant IGMP/MLD protocol documents) would be worthwhile. Normally I would leave this as a Comment on the assumption that the privacy considerations are already documented in the protocol specification that documents explicit tracking, but I could not find such a document (with privacy considerations listed) in a quick search; I found RFC 6636 and draft-ietf-pim-explicit-tracking but probably missed a few others. Let's talk about what the current state actually is, and where it's best to document the privacy considerations (which is not necessarily this document, a priori). ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- Other than my Discuss point, basically all I have is editorial nits -- thanks for the well-written document! Section 2.1 Even though there is no protocol specific notifications are defined in this model, the subscription nit: s/there is// -- the "are defined in this model" takes care of the grammatical necessities here. and push mechanism defined in [I-D.ietf-netconf-subscribed- notifications] and [I-D.ietf-netconf-yang-push] can be used by the user to subscribe notifications on the data nodes in this model. nit: "subscribe to notifications" The model contains all basic configuration parameters to operate the protocols listed above. Depending on the implementation choices, nit: "all the basic" Section 4 grouping interface-common-config-attributes { [...] leaf query-interval { [...] description "The Query Interval is the interval between General Queries sent by the Querier.In RFC3376, Querier's Query Interval(QQI) is represented from the Querier's Query Interval Code in query message as follows: nit: one or two (not zero) spaces after the end of the sentence. nit: "In RFC3376, the Querier's Query Interval (QQI)" leaf exclude-lite { if-feature intf-exclude-lite; side-note: I misparsed this (I think) the first few times I read it, since "exclude lite" can be taken as an imperative command to not use the lite version. But it seems this is really just an ordinary feature-enablment tag about whether to use the EXCLUDE filtering that is available in the lite version of the protocol. I don't know whether reordering to "lite-exclude" would be a net win or net loss due to causing some other confusion, though. grouping interface-state-attributes-igmp { [...] list group { [...] list source { [...] list host { [...] leaf host-address { type inet:ipv4-address; description "The IPv6 address of the host."; nit: "ipv6-address" grouping interface-state-group-attributes-igmp-mld { nit: I thought most of the other shared groupings just didn't use a suffix, as opposed to using the "-igmp-mld" combined suffix. (Similarly for interface-state-source-attributes-igmp-mld and interface-state-host-attributes-igmp-mld, which does cause me to wonder if I'm not perceiving "most" correctly.) Section 5 igmp-mld:global This subtree specifies the configuration for the IGMP attributes at the global level on an IGMP instance. Modifying the configuration can cause IGMP membership deleted or reconstructed on all the interfaces of an IGMP instance. nit: "to be deleted or reconstructed" (Similarly for the following paragraphs.) The description of the considerations for unauthorized read access are fairly generic and do not specify specific potential harms, but I will not insist on any changes here.
- [pim] Benjamin Kaduk's Discuss on draft-ietf-pim-… Benjamin Kaduk via Datatracker
- Re: [pim] Benjamin Kaduk's Discuss on draft-ietf-… Xufeng Liu
- Re: [pim] Benjamin Kaduk's Discuss on draft-ietf-… Alvaro Retana
- Re: [pim] Benjamin Kaduk's Discuss on draft-ietf-… Benjamin Kaduk
- Re: [pim] Benjamin Kaduk's Discuss on draft-ietf-… Xufeng Liu
- Re: [pim] Benjamin Kaduk's Discuss on draft-ietf-… Benjamin Kaduk