IETF Logo Mail Archive

Re: [pim] [Gen-art] Genart last call review of draft-ietf-pim-igmp-mld-extension-05

Lars Eggert <lars@eggert.org> Thu, 03 February 2022 10:10 UTC

Return-Path: <lars@eggert.org>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 918F53A0D78; Thu, 3 Feb 2022 02:10:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PezAfrywzR3h; Thu, 3 Feb 2022 02:10:26 -0800 (PST)
Received: from mail.eggert.org (mail.eggert.org [IPv6:2a00:ac00:4000:400:211:32ff:fe22:186f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A3D203A0D9D; Thu, 3 Feb 2022 02:10:25 -0800 (PST)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:3483:e6e7:fbe7:7efc]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 1DFB81D4329; Thu, 3 Feb 2022 12:10:15 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1643883015; bh=jkFI3j6gO+BAwsHd2aqcoeXvktIETZhpGIyeEDgIdS8=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=vnEHFHfYIF812TZ4INvKYsCEyN0UzmGsiWAU/kk1w4zK/5ZzcrCxLWM6CmtnG66RG ew5CxrBjxAnlbC8r0HGDQsxeMHV82JTiRuRA0uSg9Cqg/ylr6p2lhTFfXyMoOsSSDS Wrxz4TOEKD56jbSiVtCq6PnzYRzYuKkeIqlpXmWo=
Content-Type: multipart/signed; boundary="Apple-Mail=_5697B2ED-491D-4B90-A0E8-8DBA6363678B"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.60.0.1.1\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <164211750829.31068.5259817839593824551@ietfa.amsl.com>
Date: Thu, 03 Feb 2022 12:10:14 +0200
Cc: gen-art@ietf.org, last-call@ietf.org, draft-ietf-pim-igmp-mld-extension.all@ietf.org, pim@ietf.org
Message-Id: <42F0DE54-5F75-445E-8873-6ED9E7F883DC@eggert.org>
References: <164211750829.31068.5259817839593824551@ietfa.amsl.com>
To: Pete Resnick <resnick@episteme.net>
X-MailScanner-ID: 1DFB81D4329.A8950
X-MailScanner: Found to be clean
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/FiPR6uTOHdYgaDPZhDV7dUnaZr0>
Subject: Re: [pim] [Gen-art] Genart last call review of draft-ietf-pim-igmp-mld-extension-05
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Feb 2022 10:10:32 -0000

Pete, thank you for your review. I have entered a No Objection ballot for this document.

Lars


> On 2022-1-14, at 1:45, Pete Resnick via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Pete Resnick
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-pim-igmp-mld-extension-05
> Reviewer: Pete Resnick
> Review Date: 2022-01-13
> IETF LC End Date: 2022-01-19
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: One possible minor issue and a couple of nits, but otherwise ready.
> 
> Major issues:
> 
> None.
> 
> Minor issues:
> 
> In section 3 it says,
> 
>   There is no alignment or padding.
> 
> Are you sure that implementations are going to work with this? In my old brain,
> there are still memories of trying to read 16-bit values out of an odd-aligned
> location caused all sorts of problems. Are you sure you don't want to at least
> pad this to even lengths?
> 
> Nits/editorial comments:
> 
> In section 3, this sentence confused me for a moment:
> 
>   A previously reserved bit in the IGMPv3 and MLDv2 headers is used to
>   indicate whether this extension is used.
> 
> I suggest:
> 
>   For each of the IGMPv3 and MLDv2 headers, a previously reserved bit
>   is used to indicate the presence of this extension.
> 
> In section 3:
> 
>   When this extension
>   mechanism is used, the number of Group Records in each Report message
>   should be kept small enough that the entire message, including any
>   extension TLVs can fit within the network MTU.
> 
> That "should" looks pretty interoperability-related to me. Perhaps "SHOULD"?
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

v2.23.0 | Report a Bug | By Email