Re: [pim] AD Review of draft-ietf-pim-igmp-mld-extension-04

Stig Venaas <stig@venaas.com> Fri, 10 September 2021 19:38 UTC

Return-Path: <stig@venaas.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 11D803A1761 for <pim@ietfa.amsl.com>; Fri, 10 Sep 2021 12:38:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=venaas-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w9rZcavJO3ch for <pim@ietfa.amsl.com>; Fri, 10 Sep 2021 12:38:04 -0700 (PDT)
Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A443A3A1764 for <pim@ietf.org>; Fri, 10 Sep 2021 12:38:04 -0700 (PDT)
Received: by mail-il1-x12c.google.com with SMTP id a20so3172363ilq.7 for <pim@ietf.org>; Fri, 10 Sep 2021 12:38:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=venaas-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BpryWYAW85nZOP/PhowwJHUH0s8u4SHayjDvIusmkmM=; b=kSJ3gTGkUIdvD/z6KlSbFrPNp3nxgKU2xPwowmHTjy56obVWRXELMSVPIMNBUTJgAY xw8IFKbJVS36ynAhqdyaXnX+JkZBUCToQ4e0gBx5FDXS5JabiALUnQgNB013cGZyymQ2 hXYjmSYszOWvCdcRinV8nqRFEExYAsN4awRcqPLrIbjLDPaxif6FkV3aobjfhtb7efH2 jruzoxX44cl/Q6gFdttddSDJXrYa4mP05gKukl83XtSN4HKi8G1J+MLOvfkZ3s8eIXXE cbxKhgMRYoAS+ueOAUw+7v1bqSieXTRACkcqkd9ysOQdhv64kWzBwcxKSZEasKik3kbQ KpfQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BpryWYAW85nZOP/PhowwJHUH0s8u4SHayjDvIusmkmM=; b=z9L2b8ZXYS94eRww91gepTFK0S462f5y888/bcJvm6wnRYedk2e9moxL6GkYmYAeZ1 j+NYy6YFhUJ2CryPANNVgUqj0LRKCHp0/k785FpupNXHtTc+yNSqErKqGejkHgIvRjJb S7iHQO5b92/4v+6xqQ5RX1UXtpyW5BZaM45Q4jHBcVpWB2KHajHGc3YRvX9RzJCb76mq W35NK7vo/BzItGZLYCP5cf1nA8SmZlJT2iSWMxPchtKnjH9jVv7hF7Hc1xtBwgg4+CxN nI9VlCL0+HED+UNeKgBTiI8RZEG7sJIua9t9Z67xsd7zJwrj1gIHzyyZbxQ0EDuDfLgm V8PA==
X-Gm-Message-State: AOAM533kq8j/okriTELlu/rJZ2jeXgDWcgJyPCXmqtGxw5GbztZ82JfR h8V4gnfAOHbkQc7XwrpDL9zIWBoUVizap0p7IY5ZnA==
X-Google-Smtp-Source: ABdhPJzYOvnWOUIcfVbEGziAZ3Mg11nAR3De7wXzxDeWJNlTNIjxBjVXyOj3TKLsVFPB1AuMOJeb77ZW52B3ZqXN4lQ=
X-Received: by 2002:a05:6e02:1c03:: with SMTP id l3mr7646076ilh.219.1631302683188; Fri, 10 Sep 2021 12:38:03 -0700 (PDT)
MIME-Version: 1.0
References: <CAMMESsw2QqJDbW3WXMNuH39DV5nDRf2925vWq9ECMnDsgtjrMQ@mail.gmail.com> <4cc46c5f-dde0-eaf0-931f-f44b8d6259b0@innovationslab.net> <CAHANBt+nDBwekwLgDFM6XdWFmm=vMbdnUfxfJ2_7yNJ+zYdgag@mail.gmail.com> <CAMMESsycfcOnU3ufU++tSN0PUTxOLc+bPhYzyDHkdFSqHOY_wA@mail.gmail.com>
In-Reply-To: <CAMMESsycfcOnU3ufU++tSN0PUTxOLc+bPhYzyDHkdFSqHOY_wA@mail.gmail.com>
From: Stig Venaas <stig@venaas.com>
Date: Fri, 10 Sep 2021 12:37:52 -0700
Message-ID: <CAHANBtKs8Px13n7eGMsefF-sTNr0kbbxxaTOdWE_HVjz_qtVoA@mail.gmail.com>
To: Alvaro Retana <aretana.ietf@gmail.com>
Cc: Brian Haberman <brian@innovationslab.net>, pim@ietf.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/jmg8fd3fcCGKHTqBteRVZkghEYI>
Subject: Re: [pim] AD Review of draft-ietf-pim-igmp-mld-extension-04
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Sep 2021 19:38:10 -0000

Hi again Alvaro

As an author, I am certainly happy to remove the updates text if it is
not needed. I'll go through your other comments and see how to address
them.

Thanks for the review,
Stig

On Fri, Sep 10, 2021 at 12:03 PM Alvaro Retana <aretana.ietf@gmail.com> wrote:
>
>
> Brian/Stig:
>
> Hi!
>
> The good (and also the bad) news is that there is no well-defined interpretation of Updates [1], which means that we can interpret it (almost) any way we want, but others can too.   IOW, there isn't an established set of rules, even if some are common (but subject to interpretation).
>
>
> I don't think that draft-ietf-pim-igmp-mld-extension has to change this piece of text from the Additional Data sub-sections: "...an IGMPv3|MLDv2 implementation MUST NOT include additional octets beyond the fields described here."   The TLVs take the place of the Additional Data so there's no change (no net-new fields are specified), and an rfc3376/rfc3810 implementation wouldn't be able to tell the difference.
>
> It is true that in general (but not always) a base document is Updated when the reserved fields are modified.  It is too bad that a registry wasn't created (back in the original documents) -- then we wouldn't have to worry about this point.
>
>
> My biggest concern is this:  Updates is not consistently defined -- a reasonable interpretation [*] is to consider the extension a required feature in rfc3376/rfc3810 -- this new feature could be seen as a significant change to the base protocols (it is!) resulting in not being able to get rfc3376bis/rfc3810bis to Internet Standard because of the change, but also because there won't be significant experience with it.
>
> I realize that I am making assumptions (and maybe planning for the worst): I don't know how the IESG will interpret the Updates tag when rfc3376bis/rfc3810bis get there.
>
>
> Alvaro.
>
>
> [1] https://datatracker.ietf.org/doc/draft-kuehlewind-update-tag/
>
> [*] That is usually how I interpret it.
>
>
> On September 10, 2021 at 1:04:35 PM, Stig Venaas (stig@venaas.com) wrote:
>
> Hi Alvaro and Brian
>
> As you noted Brian, when supporting this it would require relaxing at
> least that one rule. Also, don't we generally make it an update when
> we define use of previously reserved bits?
>
> Note that any implementation of the existing IGMPv3/MLDv2 would ignore
> this extension, which is what we want. But if an implementation is to
> send messages using the new extension, it would have to deviate from
> some existing text in e.g. 3376.
>
> I believe this is similar to e.g. reserved bits in general. A base
> protocol RFC would typically define reserved bits with text about how
> they must be set to 0 and ignored, in order to allow future
> extensions. Then new documents would say that you would set some of
> these bits in certain cases, hence deviating from the base RFC
> requirements. Wouldn't we then say that the new draft updates the old
> one? What is the general procedure?
>
> In this case we are also talking about sending additional octets, but
> it is essentially the same as reserved bits. 3376 says to not send
> additional data, but also to ignore the data if present.
>
> Thanks,
> Stig
>
>
>
>
> On Fri, Sep 10, 2021 at 5:10 AM Brian Haberman <brian@innovationslab.net> wrote:
> >
> > Hey Alvaro,
> >
> > On 9/9/21 5:15 PM, Alvaro Retana wrote:
> > > Dear authors:
> > >
> > > Thank you for this document!
> > >
> > > In general, I think this document is in good shape -- I do have
> > > comments and suggestions below (inline) that I would like to see
> > > addressed before publication.
> > >
> > > My main concern is the formal Update of rfc3376 and rfc3810. Do we
> > > really need to formally Update those documents? I didn't see a
> > > specific discussion on the list about this topic.
> > >
> >
> > I think the WG needs to think about this a bit given that we are in the
> > process of publishing 3376 and 3810 updates in order to move them to
> > Internet Standard. In general, I agree with the sentiment that optional
> > extensions do not need to update the base specification. However, we may
> > have an issue here as section 4.1.10 of 3376 states:
> >
> > ... When sending a Query,
> > an IGMPv3 implementation MUST NOT include additional octets beyond
> > the fields described here.
> >
> > This extension document has to relax that rule in 3376 IMO.
> >
> > We can't add the necessary extension text to the -bis drafts if we want
> > to make them Internet Standards.
> >
> > Regards,
> > Brian
> >
> > _______________________________________________
> > pim mailing list
> > pim@ietf.org
> > https://www.ietf.org/mailman/listinfo/pim
>
> _______________________________________________
> pim mailing list
> pim@ietf.org
> https://www.ietf.org/mailman/listinfo/pim