Re: [PWE3] WG Poll on draft-jin-pwe3-cbit-negotiation-03.txt ( comment )

Luca Martini <lmartini@cisco.com> Mon, 07 March 2011 19:34 UTC

Return-Path: <lmartini@cisco.com>
X-Original-To: pwe3@core3.amsl.com
Delivered-To: pwe3@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 5B7293A680E for <pwe3@core3.amsl.com>; Mon, 7 Mar 2011 11:34:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[AWL=0.000, BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k0crs-Y5RWOv for <pwe3@core3.amsl.com>; Mon, 7 Mar 2011 11:34:02 -0800 (PST)
Received: from napoleon.monoski.com (napoleon.monoski.com [70.90.113.113]) by core3.amsl.com (Postfix) with ESMTP id 234253A6809 for <pwe3@ietf.org>; Mon, 7 Mar 2011 11:34:02 -0800 (PST)
Received: from confusion.monoski.com (confusion.monoski.com [209.245.27.2]) (authenticated bits=0) by napoleon.monoski.com (8.13.8/8.13.8) with ESMTP id p27JZ9Fg017906 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Mon, 7 Mar 2011 12:35:11 -0700 (MST)
Message-ID: <4D75336C.2060505@cisco.com>
Date: Mon, 07 Mar 2011 12:35:08 -0700
From: Luca Martini <lmartini@cisco.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.15) Gecko/20110303 Lightning/1.0b2 Thunderbird/3.1.9 ThunderBrowse/3.3.5
MIME-Version: 1.0
To: lizhong.jin@zte.com.cn
References: <OF1E77B4A7.8BFBB01F-ON48257847.00149D26-48257848.00562B1B@zte.com.cn>
In-Reply-To: <OF1E77B4A7.8BFBB01F-ON48257847.00149D26-48257848.00562B1B@zte.com.cn>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: pwe3@ietf.org, andrew.g.malis@verizon.com
Subject: Re: [PWE3] WG Poll on draft-jin-pwe3-cbit-negotiation-03.txt ( comment )
X-BeenThere: pwe3@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Pseudo Wires Edge to Edge <pwe3.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/pwe3>, <mailto:pwe3-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/pwe3>
List-Post: <mailto:pwe3@ietf.org>
List-Help: <mailto:pwe3-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pwe3>, <mailto:pwe3-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2011 19:34:03 -0000

Sorry for the late response , comments below:
Luca


On 03/03/11 08:41, lizhong.jin@zte.com.cn wrote:
>
> Luca,
> After discussing with the authors, we decide to add the wait for label
> release before sending label request, this wouldn't harm and bring
> some secure.
>
> Then are you OK with the following text?
>
> When Local PE changes its control word from NOT PREFERRED to PREFERRED
> and only if it already received the remote label mapping message with
> C-bit=0, additional procedure will be added as follow:
> -i Local PE MUST send a label withdraw message to remote PE if it has
> previously sent a label mapping, and wait until receiving a label
> release from the remote PE.
> -ii Local PE MUST send a label request message to remote PE, and wait
> until receiving a label mapping message containing the remote PE
> configured control word setting.
> -iii After receiving remote PE label mapping with control word
> setting, Local PE MUST follow procedures defined in [RFC4447] section
> 6 when sending it's label mapping message.
>
Ok the above text is fine.
However you need to address the case when the Local PE changes its
control word from  PREFERRED to NOT PREFERRED as well.


> Correspondingly, the modified procedure of PE in figure 1 will be as
> follows:
>
> 1. PE2 changes locally configured control word to PREFERRED.
> 2. PE2 will then send label withdraw message to PE1.
> 3. PE1 MUST send label release in reply to label withdraw message from
> PE2.
> 4. Upon receipt of Label release message from PE1, PE2 MUST send label
> request messages to PE1 although it already received the label mapping
> with C-bit=0.
> 5. PE1 MUST send label mapping message with C-bit=1 again to PE2
> (Note: PE1 MUST send label mapping with locally configured CW parameter).
> 6. PE2 receives the label mapping from PE1 and updates the remote
> label binding information. PE2 MUST wait for PE1 label binding before
> sending its label binding with C-bit set, only if it previously had a
> label binding with C-bit = 0 from PE1.
> 7. PE2 will send label mapping to PE1 with C-bit=1.
>
No, the above procedure will result in a LDP error and session shutdown.
In LDP you  cannot "update" the FEC.  In step 5 PE1 can only send the
label mapping message it has previously sent. So PE1 cannot change the
C-Bit without first issuing a label withdraw.

> It is to be noted that the above assume that PE1 is configured to
> support CW, however in step 5 if PE1 doesn't support CW, PE1 would
> send the label mapping message with C-bit =0, this would result in PE2
> in step 7 sending a label mapping with C-bit=0 as per [RFC4447] CW
> negotiation procedure.
>
What is needed is some way to send a message to the remote PE that the
C-bit negotiation procedure needs to be re-started.

Solution 1

one way to get this procedure working is to have PE2 release the label
mapping previously sent by PE1.
If you do this today, most implementations will simply go to a dead
state requiring operator intervention.
What should happen is that upon receiving the label release , PE1 should
withdraw it's label mapping , and reset the c-bit negotiation state
machine , and re-advertise the new label mapping restarting the
procedure described in rfc4447 from the beginning.

Solution 2

Whenever a PE withdraws a FEC mapping , the remote PE resets the C-bit
negotiation procedure. If this results in a different C-bit local value
then previously advertised , the local PE MUST go though a label
withdraw/label release/label advertisement cycle.


Both solutions above should work within the  LDP rules and are backward
compatible. I like solution 2 a bit better.

Luca

> Thanks
> Lizhong
>
>
> ------------send by Luca
> Martini-------------------------------------------
> Matthew & Andy,
>
>
> Although I support clarifying this procedure , I believe this document
> needs some work.
> In section 3 for example :
>
>    When Local PE changes its control word from NOT PREFERRED to
>    PREFERRED and only if it already received the remote label mapping
>    message with C-bit=0, additional procedure will be added as follow:
>
>          -i. Local PE sends label withdraw message to the remote if it
>              already sends label mapping message, for it has changed its
>              control word parameter.
>
>         -ii. Local PE MUST send a label request messages to peer PE to
>              get peer's configured control word parameter before sending
>              new label mapping message to peer PE.
>
>        -iii. After receiving the new label mapping message from peer PE
>              and updating the remote label binding information, the
>              Local PE should send label mapping to peer PE according to
>              procedures defined in [RFC4447].
>
> What does the item i) mean ? the English is not clear.
> Why does the PE have to do ii) ?
>
> All we really need is a statement on how the c-bit negotiation state
> machine can be reset if one end has changed "his mind" .
>
> Can we fix this document before  issuing the -00 WG draft version ?
>
> Thanks.
> Luca
>  
> --------------------------------------------------------
> ZTE Information Security Notice: The information contained in this mail is solely property of the sender's organization. This mail communication is confidential. Recipients named above are obligated to maintain secrecy and are not permitted to disclose the contents of this communication to others.
> This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the originator of the message. Any views expressed in this message are those of the individual sender.
> This message has been scanned for viruses and Spam by ZTE Anti-Spam system.