Re: [quicwg/base-drafts] Fix language around CC on migration (#2918)

Tommy Pauly <notifications@github.com> Wed, 07 August 2019 16:10 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F5571205CB for <quic-issues@ietfa.amsl.com>; Wed, 7 Aug 2019 09:10:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C4dwaQvGqXIu for <quic-issues@ietfa.amsl.com>; Wed, 7 Aug 2019 09:10:34 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 470511205D2 for <quic-issues@ietf.org>; Wed, 7 Aug 2019 09:10:34 -0700 (PDT)
Date: Wed, 07 Aug 2019 09:10:33 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1565194233; bh=MWIPOXdwXbhFNhXckT+bLD2IZ7qYbU8S8bPRa1XXEZI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vie8Q/VjI5O1RZ9JJKGDVy2+yn6+tE3nMzHdQaUtnrDM+TfCw5NvIV3Gw/dauV8WN R/sgh5NCHbm4tTocNhFmVcJvpICSRSos1fCVBl8zIG+INHPD5AAFaVMasWbz6Tzp8L sYUjkXWDQl8wpfPg7S6GwCukicRduhVbtv/1R0d8=
From: Tommy Pauly <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK45IZSII6QZMHCKXQV3LAVHTEVBNHHBYEARTM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2918/review/272073804@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2918@github.com>
References: <quicwg/base-drafts/pull/2918@github.com>
Subject: Re: [quicwg/base-drafts] Fix language around CC on migration (#2918)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d4af7f951b03_7e103ff75a6cd964607373"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: tfpauly
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-EB-BobV3om_j5RHRkoB7inAPYU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Aug 2019 16:10:42 -0000

tfpauly commented on this pull request.



>  immediately reset the congestion controller and round-trip time estimator for
-the new path to initial values (see Sections A.3 and B.3 in {{QUIC-RECOVERY}}).
-
-An endpoint MUST NOT return to the send rate used for the previous path unless
-it is reasonably sure that the previous send rate is valid for the new path.
-For instance, a change in the client's port number is likely indicative of a
-rebinding in a middlebox and not a complete change in path.  This determination
-likely depends on heuristics, which could be imperfect; if the new path capacity
-is significantly reduced, ultimately this relies on the congestion controller
-responding to congestion signals and reducing send rates appropriately.
+the new path to initial values (see Sections A.3 and B.3 in {{QUIC-RECOVERY}})
+unless it has knowledge that a previous send rate or round-trip time estimate
+is valid for the new path.  For instance, an endpoint might infer that a change
+in only the client's port number is likely indicative of a NAT rebinding,
+meaning that the new path is likely to have similar bandwidth and round-trip
+time. This determination is likely to be imperfect.  If

Reading through this at an editorial level, it stands out a bit that the text says `likely` three times in the space of two sentences. I would argue that if an endpoint is inferring something, it's already clear that the state it is inferring is "likely" (but not certain) based on the fact that the state is inferred. I would suggest text like:

```
For instance, an endpoint might infer that a change
	in only the client's port number is indicative of a NAT rebinding,
	meaning that the new path is likely to have similar bandwidth and round-trip
	time. However, this determination will often be imperfect.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2918#pullrequestreview-272073804