[quicwg/base-drafts] draft-ietf-quic-recovery-13 ssthresh never set (#1598)

"Arvid E. Picciani" <notifications@github.com> Tue, 24 July 2018 16:31 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BA08A131181 for <quic-issues@ietfa.amsl.com>; Tue, 24 Jul 2018 09:31:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q0TpQ3fbbkC2 for <quic-issues@ietfa.amsl.com>; Tue, 24 Jul 2018 09:31:56 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E450D130EE7 for <quic-issues@ietf.org>; Tue, 24 Jul 2018 09:31:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=gjQ5o35kRIrul7dopWddp/lGn40=; b=poUhSAUKD07IkIAU hL2Jz7lJXrcToD4sitq5uD7aOBtCWc4LDzCQx6YhXlg5Mk/gCYEjzS5iYg0P4fZx eFmjQKoekPL5h4YhD2mwq7/D+OVU+8lCMWw2d3nfvWhQbrVzGHQbIa/GOE0SQxwR fcE2mjFZ8WR0GWvHxaV2pNSfeR4=
Received: by filter1000p1las1.sendgrid.net with SMTP id filter1000p1las1-26986-5B575479-1F 2018-07-24 16:31:53.61641935 +0000 UTC m=+582957.598702824
Received: from github-lowworker-e51511d.cp1-iad.github.net (unknown [192.30.252.34]) by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id Pi_aburuTFuCK_wLlONkZA for <quic-issues@ietf.org>; Tue, 24 Jul 2018 16:31:53.499 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e51511d.cp1-iad.github.net (Postfix) with ESMTP id 77AF280E38 for <quic-issues@ietf.org>; Tue, 24 Jul 2018 09:31:53 -0700 (PDT)
Date: Tue, 24 Jul 2018 16:31:53 +0000
From: "Arvid E. Picciani" <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab958a24219514f73e8370752077e18618d84bb49292cf00000001176f167992a169ce1482c3ac@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1598@github.com>
Subject: [quicwg/base-drafts] draft-ietf-quic-recovery-13 ssthresh never set (#1598)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b575479767cc_32a03fe4d20d45c050114"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: aep
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3PiCqCH/PjYv1yLeWp9PgHKztD8JRWQ7ivuH sSfwgiLl/nPq0EOcZU7fb+E8R/dvq27tIeiSSY/FlxiDmf9xOlQzBm8fH8/H+CmD24ABfrs5vuik1u y+BKg8rtXYbX6HWAwKtIX/Ie2gTjXxMGnXdaSRl3Aboi/PoURJHzh77OTES6kPtEXsRO9EPtsYYeX5 g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-PNQ7hzHMc6qNQsv6KsHGsMvtiU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jul 2018 16:32:05 -0000

in 4.3.  Congestion Avoidance

>  and sets the slow start threshold to the new congestion window.

however, the pseudo code doesnt do that

i'm guessing that CongestionEvent should do that?

```diff
      CongestionEvent(packet_number):
        // Start a new congestion event if packet_number
        // is larger than the end of the previous recovery epoch.
        if (!InRecovery(packet_number)):
          end_of_recovery = largest_sent_packet
          congestion_window *= kMarkReductionFactor
          congestion_window = max(congestion_window, kMinimumWindow)
+         ssthreshold = congestion_window
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1598