IETF Logo Mail Archive

Re: [quicwg/base-drafts] Clarify In-flight (#2200)

ianswett <notifications@github.com> Wed, 19 December 2018 21:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5AB6B130EE1 for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 13:25:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QNutTlUYDFVD for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 13:25:22 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 73559128D0C for <quic-issues@ietf.org>; Wed, 19 Dec 2018 13:25:22 -0800 (PST)
Date: Wed, 19 Dec 2018 13:25:21 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545254721; bh=raQkPInJTVvISh8LaQK7s33ijzUAJCkh4X8ocOUpr6U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=HUDT58/i0LUDJ7Rt/txWBQC6Myd8yPVQWc7eVonuqMP4tI50AbysZLcNKydbtyOQ7 WmaKoo+sA1NbJayB8m/Fw1KpSzR+sPkr/zax772CfGURclfDRKYF8GB/2YZaoyFq5x 1mKAqd5Ywa1aVDC/fsM0I7U3eCQwwY7yFkHn8MGU=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab65c97f36120f0c5656969ba69947668bf7b4177f92cf000000011832794192a169ce175a6070@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2200/review/186755511@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2200@github.com>
References: <quicwg/base-drafts/pull/2200@github.com>
Subject: Re: [quicwg/base-drafts] Clarify In-flight (#2200)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1ab74186484_62e83ff96d4d45bc18559a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0BZCWtSKIZuLsy-nYkTbFEOgyus>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Dec 2018 21:25:30 -0000

ianswett commented on this pull request.



> @@ -102,7 +102,9 @@ In-flight:
 
 : Packets are considered in-flight when they have been sent
   and neither acknowledged nor declared lost, and they are not
-  ACK-only.
+  ACK-only.  For example, packets containing STREAM frames are

After starting to add this in, I don't think it reads as clearly as I'd like, so I didn't.  However, I did fix an error in the pseudocode below involving ACK-only packets not being considered in-flight.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2200#discussion_r243080528

v2.23.0 | Report a Bug | By Email