IETF Logo Mail Archive

Re: [quicwg/base-drafts] Clarify In-flight (#2200)

ianswett <notifications@github.com> Mon, 17 December 2018 20:29 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DAD59130FB8 for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 12:29:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.056
X-Spam-Level:
X-Spam-Status: No, score=-3.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DN_v5Z3s88Je for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 12:29:46 -0800 (PST)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 220E8130F96 for <quic-issues@ietf.org>; Mon, 17 Dec 2018 12:29:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=T8YoSHJ89FPHHDHqEagQ59O1cRY=; b=KHfJeljIrE98NZN4 MnyB6NIorVsE4XWAQ5Zl+2IR1bG3z05gcYtOV2GTk0JOULYF4F6XP19eClaUpX9A zAtmiNnztk2EDU5gvfdxwryao/tPsYV6V3N3aYk0nlhiCgVbSMZS24ag66PV4A+1 gm2aaU5OxlGOfl0W8Me+aUIHDbg=
Received: by filter0260p1iad2.sendgrid.net with SMTP id filter0260p1iad2-19972-5C180734-19 2018-12-17 20:29:40.97550871 +0000 UTC m=+7761.529881216
Received: from github-lowworker-3c598a3.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0025p1iad2.sendgrid.net (SG) with ESMTP id FcqS9u8fSgqhre5SOGlFjQ for <quic-issues@ietf.org>; Mon, 17 Dec 2018 20:29:41.016 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-3c598a3.cp1-iad.github.net (Postfix) with ESMTP id 0BCF4A8015D for <quic-issues@ietf.org>; Mon, 17 Dec 2018 12:29:41 -0800 (PST)
Date: Mon, 17 Dec 2018 20:29:41 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab74ecd1ae0112927211be60bdb1a10ce927417c4092cf00000001182fc93592a169ce175a6070@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2200/review/185784387@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2200@github.com>
References: <quicwg/base-drafts/pull/2200@github.com>
Subject: Re: [quicwg/base-drafts] Clarify In-flight (#2200)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c180735a276_25fa3febd28d45c02120c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3BZ408cEF+LkIOG2as2tzCCEUn+Cpihbwew1 8wEwhU7eJRBXpehesJHdLqFA8EdEAxvJn74wv3l15uKIHRvG6CgRnV9gXUERIP482sK5v27006lzd6 nKsWX+gLTHKHOx8rV67i+UngdH4wVm7uylmqYd0sq7H+H6Hj52RECAjaaO3pjrWcET2q7wi8Gbtrmh U=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KKMDod9Jpc6hsFnghxQm9iQGBV8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Dec 2018 20:29:52 -0000

ianswett commented on this pull request.



> @@ -102,7 +102,8 @@ In-flight:
 
 : Packets are considered in-flight when they have been sent
   and neither acknowledged nor declared lost, and they are not
-  ACK-only.
+  ACK-only.  Packets are still considered in-flight even if
+  their payloads no longer need to be delivered.

In-flight packets count towards bytes in flight, which is defined in the pseudocode section, but we could move that definition up here if it's helpful.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2200#discussion_r242304847

v2.23.0 | Report a Bug | By Email