Re: [quicwg/base-drafts] clarify that old keys should always be dropped (#2191)

ianswett <notifications@github.com> Mon, 17 December 2018 20:34 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 67937130F3C for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 12:34:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.459
X-Spam-Level:
X-Spam-Status: No, score=-9.459 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wubgZffmiL33 for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 12:34:05 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C6A0112D4E9 for <quic-issues@ietf.org>; Mon, 17 Dec 2018 12:34:04 -0800 (PST)
Date: Mon, 17 Dec 2018 12:34:03 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545078843; bh=gCbgxVn/gpeFT4uHjhK9oETQsvSrM3AASYJVyf88bpE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LMAhFOCuDQUL7zZAd4D0P1pXaFs6m8KuLGm1EotfZJR928QabcQt5SKKvcXoSodyJ svh4FUS7lVnBdi1gTC8U3zItrroZUa0466FfOYsaZueUPNcNhaTsFihLOZPKpHmYk+ 8y31+nUY1my09vBD+Q+qWBmbqmmVEpeLiFCLtneI=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3293afb35cccde52ad149a3f5ec0ce60f477e9a392cf00000001182fca3b92a169ce175386ef@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2191/review/185786091@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2191@github.com>
References: <quicwg/base-drafts/pull/2191@github.com>
Subject: Re: [quicwg/base-drafts] clarify that old keys should always be dropped (#2191)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c18083b8d40c_693e3ff3038d45c4210828"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7d1wxl8HzbyhDLrUHcfYd_quWDg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Dec 2018 20:34:07 -0000

ianswett commented on this pull request.



> @@ -1108,16 +1108,12 @@ updated keys, it indicates that its peer has updated keys twice without awaiting
 a reciprocal update.  An endpoint MUST treat consecutive key updates as a fatal
 error and abort the connection.
 
-An endpoint SHOULD retain old keys for a short period to allow it to decrypt
-packets with smaller packet numbers than the packet that triggered the key
-update.  This allows an endpoint to consume packets that are reordered around
-the transition between keys.  Packets with higher packet numbers always use the
-updated keys and MUST NOT be decrypted with old keys.
-
-Keys and their corresponding secrets SHOULD be discarded when an endpoint has
-received all packets with packet numbers lower than the lowest packet number
-used for the new key.  An endpoint might discard keys if it determines that the
-length of the delay to affected packets is excessive.
+An endpoint SHOULD retain old keys for a period of no more than three times the
+Retransmitions Timeout (RTO, see {{QUIC-RECOVERY}}).  After this period, old

It's now Probe Timeouts, aka PTO.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2191#pullrequestreview-185786091