Re: [quicwg/base-drafts] QPACK: Clarify how maximum dynamic table capacity can be set (#2330)

Bence Béky <notifications@github.com> Mon, 28 January 2019 12:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3540A131021 for <quic-issues@ietfa.amsl.com>; Mon, 28 Jan 2019 04:37:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.573
X-Spam-Level:
X-Spam-Status: No, score=-11.573 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4y-4orvcubo5 for <quic-issues@ietfa.amsl.com>; Mon, 28 Jan 2019 04:37:18 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 579DA131007 for <quic-issues@ietf.org>; Mon, 28 Jan 2019 04:37:18 -0800 (PST)
Date: Mon, 28 Jan 2019 04:37:17 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548679037; bh=ftl52EaTz5h33jCxrNujQ6BM7YP8x6Bfa7Xgi3C0AMU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Xjv8plS8RwcxWs3wWYpvf6T45aKpJ0idgoWhQtDRZXCM1jjZzOVHBouk7S9hZS4sf /h34dxzy6RStv5DosieNVbIIKbFFb1q0W84CRTcjE5QYDHhPlOYFxF1QlG5K5JR8IZ k0KnrS154AFS0AGXJO3hyryTIV/sz83s1HiluUiU=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3259c83a403a131b1395ca136d6d3bed8320e1c692cf000000011866b97d92a169ce17bf8a90@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2330/review/197014559@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2330@github.com>
References: <quicwg/base-drafts/pull/2330@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: Clarify how maximum dynamic table capacity can be set (#2330)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c4ef77d2c04f_48d43f98e0ed45b459547"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0FmdMtMfXJHFPleOHv8bbq8dh_8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jan 2019 12:37:20 -0000

bencebeky commented on this pull request.



> @@ -427,16 +427,20 @@ The encoder MUST not set a dynamic table capacity that exceeds this maximum, but
 it can choose to use a lower dynamic table capacity (see
 {{set-dynamic-capacity}}).
 
+For clients using 0-RTT data in HTTP/3, the maximum table capacity is the
+remembered value of the setting. If the remembered value is not present or is 0,
+the server MAY set it to a non-zero value in its SETTINGS frame. If the

I agree with @kazuho.  If the remember value is "not present" on the server side, but it is on the client side, that can cause a problem.

Also, in my mind "the server MAY set it" and "if [...] omits SETTINGS_QPACK_MAX_TABLE_CAPACITY [...], the encoder MUST treat this as [...] error" are inconsistent.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2330#discussion_r251396769