Re: [quicwg/base-drafts] QPACK: Clarify how maximum dynamic table capacity can be set (#2330)

afrind <notifications@github.com> Tue, 29 January 2019 01:58 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D39F912875B for <quic-issues@ietfa.amsl.com>; Mon, 28 Jan 2019 17:58:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.552
X-Spam-Level:
X-Spam-Status: No, score=-12.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id efm71PRH35x6 for <quic-issues@ietfa.amsl.com>; Mon, 28 Jan 2019 17:58:05 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CD84E1277BB for <quic-issues@ietf.org>; Mon, 28 Jan 2019 17:58:04 -0800 (PST)
Date: Mon, 28 Jan 2019 17:58:04 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548727084; bh=GbFkmdWPyjgvABOyVclZYkIg4LM1DjwrghgQNbWDE5U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=B4vJzlmKpPbSwlh/DnYzo+vlhbH3yApqSNiO3sWK2TGZ2YcGPD+/wle5tpS6wOm6l WuYgu+uItZSeb1WqyJQ3RNEQErECjjedAaw+SqvZSeJbnZ3qu6FIlTHqyRC7TNxYBb t7kpnCyV+J8x1mzrbEqiNq8Ubg13QIe9kDeyWH+Y=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab17c7a1c1bd00d652a698f6426d28a2094030252092cf000000011867752c92a169ce17bf8a90@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2330/review/197347402@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2330@github.com>
References: <quicwg/base-drafts/pull/2330@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: Clarify how maximum dynamic table capacity can be set (#2330)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c4fb32cdbb3_440b3fc5ffed45b8189192"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/RrIGQJebAzKMbmrAP8o4oSkcXkI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Jan 2019 01:58:07 -0000

afrind commented on this pull request.



> @@ -427,16 +427,20 @@ The encoder MUST not set a dynamic table capacity that exceeds this maximum, but
 it can choose to use a lower dynamic table capacity (see
 {{set-dynamic-capacity}}).
 
+For clients using 0-RTT data in HTTP/3, the maximum table capacity is the
+remembered value of the setting. If the remembered value is not present or is 0,
+the server MAY set it to a non-zero value in its SETTINGS frame. If the

I was thinking of a case where the client was attempting 0-RTT from a session which never set SETTINGS_QPACK_MAX_TABLE_CAPACITY (leveraging the default, which is 0), rather than a case where the server had sent one but can't remember.

The 'MAY' refers to when 0-RTT is resumed using 0 or None (implying 0, the default), where the 'MUST treat as error' refers to when 0-RTT is resumed with non-zero.  

But if I confused both of you, then the text needs work. 

> For clients using 0-RTT data in HTTP/3, the server's maximum table capacity is the
remembered value of the setting, or 0 if the setting was not previously sent.  When the client's 0-RTT value of the setting is 0, the server MAY...

?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2330#discussion_r251666497