Re: [quicwg/base-drafts] Rephrase size requirement for Initial packets (#2520)

ianswett <notifications@github.com> Wed, 13 March 2019 18:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8D6E1130EF7 for <quic-issues@ietfa.amsl.com>; Wed, 13 Mar 2019 11:18:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UGrLh-QXIAxH for <quic-issues@ietfa.amsl.com>; Wed, 13 Mar 2019 11:17:59 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 285DF12DF72 for <quic-issues@ietf.org>; Wed, 13 Mar 2019 11:17:59 -0700 (PDT)
Date: Wed, 13 Mar 2019 11:17:57 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1552501077; bh=yMY6wKnnQgSh2ihyGj1RLpUQdY2JON6Zxs/G3W+cg8c=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=rdBDxL+KqTP8VnWvBdhU0jUR4++Z6A+iUz7JXba+q8STNPL770ovP5O7N40fkJt1b yCKxKzgobuZB1MwOvBSWBL8Zw2PPILITWzSt78SopdFLVgeACAtrID0jA4D3g0Lm4Y fcNzHMSzbDSTA8cB8CM6ddbWdB3H4xZxCs++gNVI=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2ebb01eb527742083231d7c82f53599dc73674e992cf0000000118a10b5592a169ce19118bed@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2520/review/214131411@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2520@github.com>
References: <quicwg/base-drafts/pull/2520@github.com>
Subject: Re: [quicwg/base-drafts] Rephrase size requirement for Initial packets (#2520)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c894955e2e09_5e433fd21c8d45b8378551"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0Vo6KRh2bA1xxQrFpHcy7_BA3iA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Mar 2019 18:18:01 -0000

ianswett commented on this pull request.



> @@ -1468,10 +1468,11 @@ magnitude of any amplification attack that can be mounted using spoofed source
 addresses.  In determining this limit, servers only count the size of
 successfully processed packets.
 
-Clients MUST pad UDP datagrams that contain only Initial packets to at least
-1200 bytes.  Once a client has received an acknowledgment for a Handshake packet
-it MAY send smaller datagrams.  Sending padded datagrams ensures that the server
-is not overly constrained by the amplification restriction.
+Clients MUST ensure that UDP datagrams containing Initial packets are sized to
+at least 1200 bytes, padding packets in the datagram if necessary.  Once a
+client has received an acknowledgment for a Handshake packet it MAY send smaller

I think we should stick with the simplest text possible and we should remove the second sentence.  Once you've received an ACK for a handshake packet, you should be done sending INITIAL packets anyway, so it feels like an unnecessary optimization.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2520#discussion_r265267670