Re: [quicwg/base-drafts] Replace recovery epoch with congestion event (#2585)
ianswett <notifications@github.com> Wed, 03 April 2019 13:15 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CB8A81200D6 for <quic-issues@ietfa.amsl.com>; Wed, 3 Apr 2019 06:15:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.375
X-Spam-Level:
X-Spam-Status: No, score=-5.375 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=0.726, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fePEx0j8qPeY for <quic-issues@ietfa.amsl.com>; Wed, 3 Apr 2019 06:15:58 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 147A51200FC for <quic-issues@ietf.org>; Wed, 3 Apr 2019 06:15:57 -0700 (PDT)
Date: Wed, 03 Apr 2019 06:15:56 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1554297356; bh=+tRBmsbkME9yeD/dNuoaKrH71Olb6p5h2x3+vZI6EJA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dTyftdyydXIk5dKlWtPFshQpm8IAKc2wJFp9T6j5PwBZjrnUOmCUYl0OhZ74XmuWM g9HaFeMCZ21+JnMvXEiNI5ODHNh0scpsdQvzcNrkqEm6mroB6QgQoMfwr/WIAdqvVq 1GwhMG4xwlm6qJeZLZCJY+MaSmoui0cLcqnBpVV4=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba09a53f3038e746c8740a7858d347a6801f2e52292cf0000000118bc740c92a169ce198953e0@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2585/review/222200879@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2585@github.com>
References: <quicwg/base-drafts/pull/2585@github.com>
Subject: Re: [quicwg/base-drafts] Replace recovery epoch with congestion event (#2585)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ca4b20ca411_20e53fedc1ad45b4190633"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0f0cw8tpua5k95kT_wwMyEAZsrE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Apr 2019 13:16:00 -0000
ianswett commented on this pull request.
> @@ -1318,8 +1318,8 @@ window.
~~~
CongestionEvent(sent_time):
- // Start a new congestion event if the sent time is larger
- // than the start time of the previous recovery epoch.
+ // Start a new congestion event if packet was sent after the
+ // start of the previous congestion event.
PTAL at https://github.com/quicwg/base-drafts/pull/2588
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2585#discussion_r271736247
- [quicwg/base-drafts] Replace recovery epoch with … ianswett
- Re: [quicwg/base-drafts] Replace recovery epoch w… Jana Iyengar
- Re: [quicwg/base-drafts] Replace recovery epoch w… ianswett
- Re: [quicwg/base-drafts] Replace recovery epoch w… Jana Iyengar
- Re: [quicwg/base-drafts] Replace recovery epoch w… ianswett
- Re: [quicwg/base-drafts] Replace recovery epoch w… Marten Seemann
- Re: [quicwg/base-drafts] Replace recovery epoch w… MikkelFJ
- Re: [quicwg/base-drafts] Replace recovery epoch w… MikkelFJ
- Re: [quicwg/base-drafts] Replace recovery epoch w… ianswett
- Re: [quicwg/base-drafts] Replace recovery epoch w… MikkelFJ
- Re: [quicwg/base-drafts] Replace recovery epoch w… ianswett
- Re: [quicwg/base-drafts] Replace recovery epoch w… MikkelFJ