Re: [quicwg/base-drafts] Insert Count Increment instruction description has race condition (#3082)

Bence Béky <notifications@github.com> Tue, 08 October 2019 15:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0698E1200B1 for <quic-issues@ietfa.amsl.com>; Tue, 8 Oct 2019 08:33:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cDGol5eGN4hZ for <quic-issues@ietfa.amsl.com>; Tue, 8 Oct 2019 08:33:16 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7C66A120026 for <quic-issues@ietf.org>; Tue, 8 Oct 2019 08:33:16 -0700 (PDT)
Received: from github-lowworker-39ac79b.ac4-iad.github.net (github-lowworker-39ac79b.ac4-iad.github.net [10.52.18.15]) by smtp.github.com (Postfix) with ESMTP id 968068C10D6 for <quic-issues@ietf.org>; Tue, 8 Oct 2019 08:33:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1570548795; bh=thVIVFeRfntvzNpMd2k2WFamZg8exA66OcO+wsnfgME=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=pDUiNZg4CfaFllpw4XUiGJlqdBeS6mHwiMm+0lLoho8SUOevQGYyY5gfIsO3DapcZ dlwyEFB6o0y/SLai7MsD+Z6ZHlugqWD0LMMKeq/NOoTbMwx2sjJxqCe2798NE1/9sX bgPlcGRiynX5NeuctsUz+ZN4LLXLRd3hFCelJl20=
Date: Tue, 08 Oct 2019 08:33:15 -0700
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5W2P3RI5GVN7JSVV53VHWMXEVBNHHB4CZRUQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3082/539570716@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3082@github.com>
References: <quicwg/base-drafts/issues/3082@github.com>
Subject: Re: [quicwg/base-drafts] Insert Count Increment instruction description has race condition (#3082)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d9cac3b87271_58c3f9ba8ccd96c1312ce"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1O_spR9Hy8A6oKd-IgcDZMlM6UE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Oct 2019 15:33:18 -0000

I agree that it's editorial.

In #2942 I'm already proposing to mandate both the encoder and the decoder to keep track of the Known Received Count.  Then Insert Count Increment could simply increase Known Received Count, without any references to previously acked header blocks if any etc.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3082#issuecomment-539570716