IETF Logo Mail Archive

Re: [quicwg/base-drafts] HTTP nitpick: checkng for maximum Push ID (#4052)

Mike Bishop <notifications@github.com> Tue, 25 August 2020 20:32 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A7CA53A0B93 for <quic-issues@ietfa.amsl.com>; Tue, 25 Aug 2020 13:32:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.501
X-Spam-Level:
X-Spam-Status: No, score=-0.501 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Dk_7ryVo7n-l for <quic-issues@ietfa.amsl.com>; Tue, 25 Aug 2020 13:32:46 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6FC893A0B92 for <quic-issues@ietf.org>; Tue, 25 Aug 2020 13:32:46 -0700 (PDT)
Received: from github-lowworker-fa7043e.ash1-iad.github.net (github-lowworker-fa7043e.ash1-iad.github.net [10.56.109.45]) by smtp.github.com (Postfix) with ESMTP id 3BB7A5C0E83 for <quic-issues@ietf.org>; Tue, 25 Aug 2020 13:32:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598387565; bh=MWO2sR4c7gYZCpNSz9tJ4/8EJikUmL1HOJrvi0naQiE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kIwnBsVc0J0L09l5UzopcOTn4S6z2nTaKZ3M3bN3B5EYTrgqxXuB74EIZAXMBhRM8 /N1XaWYsAdn1s0rOy+D+1WULh7Pu6ajjEe9auAwbRilH0yPeRB78D3kPwhh4+lol6u ktAFp0ZNafmC1rV8+bcNuRnWCLoVgn8mrSlOAS68=
Date: Tue, 25 Aug 2020 13:32:45 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4SV75PJGB3WPDHLU55KFLG3EVBNHHCRXIK2Q@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/4052/680254905@github.com>
In-Reply-To: <quicwg/base-drafts/issues/4052@github.com>
References: <quicwg/base-drafts/issues/4052@github.com>
Subject: Re: [quicwg/base-drafts] HTTP nitpick: checkng for maximum Push ID (#4052)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f45756d2cdb2_5c62196421367d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/392SuzntxKuGyEVcwB0Q-MZDtlk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Aug 2020 20:32:48 -0000

Unset is negative one?  The frame sets a `push_allowed` boolean?

I see a couple possible doc fixes.  The most minimal change is to simply state that it is also an error to receive anything that uses a Push ID if no MAX_PUSH_ID frame has been sent.  That's compatible and consistent with the intent of the current design.

Alternatively, we could define MAX_PUSH_ID to tell the recipient *how many* Push IDs they can use; 0 is the initial value, and sending 0 leaves push disabled.  That's consistent with QUIC's MAX_STREAMS et al. but would be a breaking change.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/4052#issuecomment-680254905

v2.23.0 | Report a Bug | By Email