Re: [quicwg/base-drafts] Define three QPACK error types, refine error handling. (#1726)

Bence Béky <notifications@github.com> Thu, 06 September 2018 23:32 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 67B4C130EE7 for <quic-issues@ietfa.amsl.com>; Thu, 6 Sep 2018 16:32:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.03
X-Spam-Level:
X-Spam-Status: No, score=-7.03 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id roC100UC-bBq for <quic-issues@ietfa.amsl.com>; Thu, 6 Sep 2018 16:32:31 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5F634130E4D for <quic-issues@ietf.org>; Thu, 6 Sep 2018 16:32:31 -0700 (PDT)
Date: Thu, 06 Sep 2018 16:32:30 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1536276750; bh=mu8j0KrVwV1I2vidwCbxxJLoFYoHkgEUnCrCwQJks/M=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=MHQAIvkA6bYnqRc7uFwBVutSl8KnyZVl98JonXaHKYxJ9ysLStJ6XYdC2IBXC1JOG tNIHu0Sxun1dov++aiS8PMHoFlu+g907oSbuF0yqGHWuwm1Iyx4KLGEplJyfDMxOvC r9UVxgczHH98/gU8FeSz3H0jOOEOswwUIv0xw6Zo=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf14fb4a65907ba5134a6b1bf7a98541e6ce2bc7392cf0000000117a97b0e92a169ce1553053a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1726/review/153159127@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1726@github.com>
References: <quicwg/base-drafts/pull/1726@github.com>
Subject: Re: [quicwg/base-drafts] Define three QPACK error types, refine error handling. (#1726)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b91b90e6807a_1db43fd397cd45c4861f2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/3WsoISz7KDpKasCdPwHySucR5es>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Sep 2018 23:32:33 -0000

bencebeky commented on this pull request.



>  QPACK which prevent the stream or connection from continuing:
 
-HTTP_QPACK_DECOMPRESSION_FAILED (0x06):
-: QPACK failed to decompress a frame and cannot continue.
+HTTP_QPACK_DECOMPRESSION_FAILED (TBD):
+: The decoder failed to interpret an instruction on a request or push stream and
+  is not able to continue decoding that header block.  This situation MAY be

Regarding stream vs connection errors, let me reword this section and every non-reference to stream error elsewhere in the document to flow more smoothly.

Regarding removing the error code, yes, it was intentional.  My understanding is that this is the registry at https://quicwg.org/base-drafts/draft-ietf-quic-http.html#rfc.section.10.5, where currently the next available error code is 0x0012, so this would need to be renumbered (by the RFC editor if the two documents get in the queue at the same time?) anyway.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1726#discussion_r215808267