IETF Logo Mail Archive

Re: [quicwg/base-drafts] Define three QPACK error types, refine error handling. (#1726)

Bence Béky <notifications@github.com> Thu, 06 September 2018 18:01 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9510E130E98 for <quic-issues@ietfa.amsl.com>; Thu, 6 Sep 2018 11:01:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.03
X-Spam-Level:
X-Spam-Status: No, score=-7.03 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zR1qgZJ4I5NI for <quic-issues@ietfa.amsl.com>; Thu, 6 Sep 2018 11:00:59 -0700 (PDT)
Received: from out-16.smtp.github.com (out-16.smtp.github.com [192.30.254.199]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C48E1130DC3 for <quic-issues@ietf.org>; Thu, 6 Sep 2018 11:00:59 -0700 (PDT)
Date: Thu, 06 Sep 2018 11:00:59 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1536256859; bh=CqHH3rhOPr3rXfFTBmkytSaALkdQQzbSRQMJzgPYsuA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=aDPnXh2LVNCmbfIpOIGBJsYcv4fJ7jE5OvYov69/hyPBTdp11wtok9Dza86dQCOSX My6fHqz7Xw8NTzVVZaZLKhyo5GcOc7zGpaaWfEUuMhVPEbldq4dSq60AQJyDEpQP/6 DBwOmLScRThSB0Up/Pi50i5emyA9Dl7hE2irrDaY=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abca0618024a76c2ae2ab3e7251b3fa158667f82c092cf0000000117a92d5b92a169ce1553053a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1726/review/153052187@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1726@github.com>
References: <quicwg/base-drafts/pull/1726@github.com>
Subject: Re: [quicwg/base-drafts] Define three QPACK error types, refine error handling. (#1726)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b916b5b2ad50_1ac03f80040d45bc1211a2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XEobY22mKGwa7DP5NcbgeEOa5cY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Sep 2018 18:01:02 -0000

bencebeky commented on this pull request.



> @@ -291,7 +300,7 @@ An encoder MUST limit the number of streams which could become blocked to the
 value of SETTINGS_QPACK_BLOCKED_STREAMS at all times. Note that the decoder
 might not actually become blocked on every stream which risks becoming blocked.
 If the decoder encounters more blocked streams than it promised to support, it
-SHOULD treat this as a stream error of type HTTP_QPACK_DECOMPRESSION_FAILED.
+MUST treat this as an error of type HTTP_QPACK_DECOMPRESSION_FAILED.

Same argument as above: I am worried that decoder implementations that do not do what they SHOULD do will allow the proliferation of non-conformant encoder implementations.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1726#pullrequestreview-153052187

v2.23.0 | Report a Bug | By Email