IETF Logo Mail Archive

Re: [quicwg/base-drafts] Bring back the Exclusive Flag (#2781)

Mike Bishop <notifications@github.com> Wed, 12 June 2019 18:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F17AB12000E for <quic-issues@ietfa.amsl.com>; Wed, 12 Jun 2019 11:26:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.391
X-Spam-Level:
X-Spam-Status: No, score=-6.391 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oBI0lFLrL49I for <quic-issues@ietfa.amsl.com>; Wed, 12 Jun 2019 11:26:30 -0700 (PDT)
Received: from out-11.smtp.github.com (out-11.smtp.github.com [192.30.254.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8E25F1200C4 for <quic-issues@ietf.org>; Wed, 12 Jun 2019 11:26:30 -0700 (PDT)
Date: Wed, 12 Jun 2019 11:26:29 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560363990; bh=J78PJ5VTxTadJ6dOBIWurE+2MisftRcWvCCfzCS1+5Q=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mrk0mADcZZOfzS1SjDe07Ie2kB1vJ308P1cvZ37RLIvV+IpfI0qSjnX+TYfG7ZCBj On/07GIKZ9W01C9uo4//lsL5R5vZ6+iVh/BG4nJZixmsm+YQavTpgVS9hIjcZvGZB6 /ujbtIRuvpxOjds2l8RaHqPotBqhp+vlUuQEc6B4=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6ABRLSYHUUYXLMKJ53BZ3FLEVBNHHBWFUTBA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2781/review/248940127@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2781@github.com>
References: <quicwg/base-drafts/pull/2781@github.com>
Subject: Re: [quicwg/base-drafts] Bring back the Exclusive Flag (#2781)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0143d5b4bba_55673ff00e4cd964286887"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/3g9wBNk8TLLfG58CW5mPxHD0vfM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Jun 2019 18:26:32 -0000

MikeBishop commented on this pull request.



> @@ -1155,22 +1151,25 @@ The PRIORITY frame payload has the following fields:
 
   PT (Prioritized Element Type):
   : A two-bit field indicating the type of element being prioritized (see
-    {{prioritized-element-types}}). When sent on a request stream, this MUST be
-    set to `11`.  When sent on the control stream, this MUST NOT be set to `11`.

We probably want to retain the "MUST NOT be set to `11` here, even if we call it out as an error later.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2781#pullrequestreview-248940127

v2.23.0 | Report a Bug | By Email