Re: [quicwg/base-drafts] ECN counts in the ACK frame should be in the same pn_space of the ACK frame (#2964)

Yuanshan <notifications@github.com> Wed, 14 August 2019 18:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E2573120D05 for <quic-issues@ietfa.amsl.com>; Wed, 14 Aug 2019 11:18:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hBL4Al7qfCuW for <quic-issues@ietfa.amsl.com>; Wed, 14 Aug 2019 11:18:34 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 26BEF120D03 for <quic-issues@ietf.org>; Wed, 14 Aug 2019 11:18:34 -0700 (PDT)
Date: Wed, 14 Aug 2019 11:18:33 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1565806713; bh=8AQCBY9syALWIqChzwCUCVflXWpWXX32EVkaGuSEfuA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TcUtvXm24LqDb36Sc7r3V4v5U0vKcDwpccM4EQpPUVDoJmj13SGgLHmbDHfKvfezn NnMu+F08R1p5d0++jqwXhdkIUHGXZ73bNAw1bdB0M/248ZuTwJIXoclNWIg8VG0gy2 8Qj5PpTku/tQnbSy/wGNQ9dJuxX8elghVwOcD7c0=
From: Yuanshan <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK52LP4FEET24YWFOCV3MGBPTEVBNHHBZD27OQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2964/review/275065046@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2964@github.com>
References: <quicwg/base-drafts/pull/2964@github.com>
Subject: Re: [quicwg/base-drafts] ECN counts in the ACK frame should be in the same pn_space of the ACK frame (#2964)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d5450793c95a_65233fa1866cd95c1081a0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: YuanshanZ
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/434nIr2_fGSlk1_1NJOglUaEsfo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Aug 2019 18:18:36 -0000

YuanshanZ commented on this pull request.



>  
 CE Count:
 : A variable-length integer representing the total number of packets received
-  with the CE codepoint.
+  with the CE codepoint in the same packet number space of the ACK.

Thanks for the suggestion! I've fixed this one along with the other two in the latest commit. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2964#discussion_r314016026