Re: [quicwg/base-drafts] Skip a packet number when sending one PTO packet (#2952)

Jana Iyengar <notifications@github.com> Tue, 17 March 2020 22:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 058073A094E for <quic-issues@ietfa.amsl.com>; Tue, 17 Mar 2020 15:46:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.554
X-Spam-Level:
X-Spam-Status: No, score=-1.554 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nae3wXeNq7Bq for <quic-issues@ietfa.amsl.com>; Tue, 17 Mar 2020 15:46:47 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8A7983A0949 for <quic-issues@ietf.org>; Tue, 17 Mar 2020 15:46:47 -0700 (PDT)
Received: from github-lowworker-2e54e43.va3-iad.github.net (github-lowworker-2e54e43.va3-iad.github.net [10.48.17.27]) by smtp.github.com (Postfix) with ESMTP id DF2588C08A4 for <quic-issues@ietf.org>; Tue, 17 Mar 2020 15:46:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584485206; bh=mOZ9mCUeK1w/nJDXwWgFt46N8yl4tEOgiaIOcvgXB0I=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=N9Zr6OUWLl0AEAh1wB/KJVaerJ7JubEj7B2WmMMC4Gh8QbZ4jiss1Wp9ibNIQPyY9 QGeUJNB3PZOZTOFPLMtQ5jgxPv2moCUHCQSXyzcnDU4nsJnKw0dYiZvMG18RjKaF0Q R+f+JXTNmPCi0hwDMDP606MayvqEIhXEvbjBGh7I=
Date: Tue, 17 Mar 2020 15:46:46 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4EQEMH7QON6R2WEAN4PU2FNEVBNHHBYY33OM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2952/review/376456604@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2952@github.com>
References: <quicwg/base-drafts/pull/2952@github.com>
Subject: Re: [quicwg/base-drafts] Skip a packet number when sending one PTO packet (#2952)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e715356cf59c_69f03f84ce2cd96c10783b"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/55_6AZ-GECsjUgqAlnBJ1CUOSpg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Mar 2020 22:46:50 -0000

janaiyengar commented on this pull request.



> @@ -587,6 +587,9 @@ In addition to sending data in the packet number space for which the timer
 expired, the sender SHOULD send ack-eliciting packets from other packet
 number spaces with in-flight data, coalescing packets if possible.
 
+When only sending a single packet on PTO, senders can skip a packet number to

```suggestion
If the sender sends a single packet on PTO, it can skip a packet number to
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2952#pullrequestreview-376456604