Re: [quicwg/base-drafts] 0-RTT can't use transport parameters or 1-RTT frames (#2461)

Kazuho Oku <notifications@github.com> Wed, 13 February 2019 03:07 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D76CE1295D8 for <quic-issues@ietfa.amsl.com>; Tue, 12 Feb 2019 19:07:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6ZP_KgcKfPae for <quic-issues@ietfa.amsl.com>; Tue, 12 Feb 2019 19:07:52 -0800 (PST)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1665D1277D2 for <quic-issues@ietf.org>; Tue, 12 Feb 2019 19:07:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=ymbVWtzfcrkyyNxGDPs3Pn4LVck=; b=kt068FlWQ+hcae4M WBF7oEG23uyGtXKyvO9OO6H2WXFw0nQsxTYLZj9WSSLgQG6mr2wDvMJ0ifElJLEh zjbi3ybHAjbq8mq8o6zl1immSWDJqEfTuJ5I6nIVDBq0Cue5r+/17XSB/n9DHCT4 0jQ9T/Huh9inG6yoS68MkJKbCm8=
Received: by filter0999p1las1.sendgrid.net with SMTP id filter0999p1las1-12308-5C638A06-16 2019-02-13 03:07:50.875260101 +0000 UTC m=+356175.253909715
Received: from github-lowworker-3c598a3.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0026p1iad2.sendgrid.net (SG) with ESMTP id DNDeu5HPTUGgLAO3_OeK7A for <quic-issues@ietf.org>; Wed, 13 Feb 2019 03:07:50.786 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-3c598a3.cp1-iad.github.net (Postfix) with ESMTP id BBFFAA80242 for <quic-issues@ietf.org>; Tue, 12 Feb 2019 19:07:50 -0800 (PST)
Date: Wed, 13 Feb 2019 03:07:51 +0000
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2dfb5860eab9ac2d11992c446be1ec0bab4b49f492cf00000001187b4c0692a169ce1869fe88@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2461/review/203012122@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2461@github.com>
References: <quicwg/base-drafts/pull/2461@github.com>
Subject: Re: [quicwg/base-drafts] 0-RTT can't use transport parameters or 1-RTT frames (#2461)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c638a06b193a_3acf3fe9cf6d45b81311aa"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1hP/wFL+CztJjGUj3YC4GlLfAQyaGkgjmV4v enDz8MIqAQrlrIEdWVlfkB2vMvk0z7BrlW5IsBwr+45aLJIzS43057SyPfvzAf5FdBBwm3lYRkdwih ybqVPQu601VmCJ8MPT+z75jvg6IKai5Gby9HLNx6wQPXJiwocMaykQpcotqqfK38d6/dODp/p7/FA7 Q=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5yi5miQwre--kHT4cBSrqpkRWYg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Feb 2019 03:07:54 -0000

kazuho approved this pull request.

LGTM modulo the very minor concern below.

>  
 A client SHOULD instead generate a fresh cryptographic handshake message and
 start packet numbers from 0.  This ensures that new 0-RTT packets will not use
 the same keys, avoiding any risk of key and nonce reuse; this also prevents
 0-RTT packets from previous handshake attempts from being accepted as part of
 the connection.
 
+A client MUST NOT send 0-RTT packets once it starts processing 1-RTT packets
+from the server.  This means that 0-RTT packets can't contain any response to
+packets a server sends.  For instance, a client cannot send an ACK frame in a

Maybe it's worth clarifying that: "any response to _1-RTT_ packets"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2461#pullrequestreview-203012122