Re: [quicwg/base-drafts] Remove HTTP_PUSH_ALREADY_IN_CACHE error (#2813)

Mike Bishop <> Wed, 19 June 2019 17:29 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 755561205FB for <>; Wed, 19 Jun 2019 10:29:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.605
X-Spam-Status: No, score=-6.605 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id 2biU-XNs3CrN for <>; Wed, 19 Jun 2019 10:29:07 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 667851205E4 for <>; Wed, 19 Jun 2019 10:29:07 -0700 (PDT)
Date: Wed, 19 Jun 2019 10:29:06 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1560965346; bh=TmvwibDI5U4w5Q0qZRwSnEPQ/PemQZtRH2up2qYUQ4Y=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mvIaHjHIENcIZ7H5dKT5SXKf9e/Y/DzRbnnIi7m4RnmOmwNfYpHfKr1JzUA1MCIAZ jBTzUs7AzW+z3d/fNk3GQYZ/ZUSUHgFWNdT4GoK9KV2QsmCxkZQO9Fb45cgIKUg7g/ Bc8G0BnUvEp4mCR6BkX6DLW/C3lohkAmujNCx/dg=
From: Mike Bishop <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2813/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Remove HTTP_PUSH_ALREADY_IN_CACHE error (#2813)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0a70e251d2e_369e3f8ebc0cd96c4049cc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Wed, 19 Jun 2019 17:29:10 -0000

MikeBishop requested changes on this pull request.

Is there a reason to reserve the error codes we remove?

> @@ -785,10 +785,9 @@ amount of data a server may commit to the pushed stream.
 If a promised server push is not needed by the client, the client SHOULD send a
 CANCEL_PUSH frame. If the push stream is already open or opens after sending the
-CANCEL_PUSH frame, a QUIC STOP_SENDING frame with an appropriate error code can
-{{errors}}). This asks the server not to transfer additional data and indicates
-that it will be discarded upon receipt.
+CANCEL_PUSH frame, a QUIC STOP_SENDING frame with an error code of
+HTTP_PUSH_REFUSED. This asks the server not to transfer additional data and

This sentence is missing a verb.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: