Re: [quicwg/base-drafts] Rationalize HTTP_WRONG_SETTING_DIRECTION (#2814)

[Mike Bishop <[e-mail]>]

MikeBishop commented on this pull request.

Looks good!

> @@ -1595,9 +1595,10 @@ HTTP_NO_ERROR (0x00):
 : No error.  This is used when the connection or stream needs to be closed, but
   there is no error to signal.
 
-HTTP_WRONG_SETTING_DIRECTION (0x01):
-: A client-only setting was sent by a server, or a server-only setting by a
-  client.
+HTTP_SETTINGS_ERROR (0x01):
+: An endpoint detected an error with a SETTINGS frame: a duplicate setting was
+  detected, a client-only setting was sent by a server, or a server-only setting
+  by a client.

The suggestion to move HTTP_GENERAL_PROTOCOL_ERROR to 0x01 might be worth taking at the same time, since people are going to change which error to use for these anyway.  (Also, I just noticed that GPE is missing from the IANA table.)

> @@ -1902,7 +1903,7 @@ The entries in the following table are registered by this document.
 | Name                                | Code       | Description                              | Specification          |
 | ----------------------------------- | ---------- | ---------------------------------------- | ---------------------- |
 | HTTP_NO_ERROR                       | 0x0000     | No error                                 | {{http-error-codes}}   |
-| HTTP_WRONG_SETTING_DIRECTION        | 0x0001     | Setting sent in wrong direction          | {{http-error-codes}}   |
+| HTTP_SETTINGS_ERROR                 | 0x0001     | Setting duplication or wrong direction   | {{http-error-codes}}   |

I'd be more general -- SETTINGS frame contained invalid values, or something like that.  It's anything that could go wrong with that frame's payload.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2814#pullrequestreview-251852413