IETF Logo Mail Archive

Re: [quicwg/base-drafts] Rationalize HTTP_WRONG_SETTING_DIRECTION (#2814)

Kazuho Oku <notifications@github.com> Thu, 20 June 2019 00:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 186D512029A for <quic-issues@ietfa.amsl.com>; Wed, 19 Jun 2019 17:33:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.605
X-Spam-Level:
X-Spam-Status: No, score=-6.605 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z6pjgicgR1li for <quic-issues@ietfa.amsl.com>; Wed, 19 Jun 2019 17:33:49 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5DEE8120134 for <quic-issues@ietf.org>; Wed, 19 Jun 2019 17:33:49 -0700 (PDT)
Date: Wed, 19 Jun 2019 17:33:48 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560990828; bh=YOUoDGwO7UUrMd8HDiP4yf/qpqIWNmzDwbNZPjrH5R4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XYEHHtxOn9VfHxWOJqz9ETGo0NxFaznJKwJlwWXaKbgiB/xZSOXRf38UqoePhMOHP ls2jGbSl0Sf45tWKnVIZhlzDJ5Ap3rRrhV5xzdnOfeuFOf7dbzQM8PHi7Udvn+ODPA 5vgORBwuCLBaJYzu0fjT5hyJLBLqSeCzK7HwEtOE=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZW2QPQUUI37EH623V3DADOZEVBNHHBWTCMKQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2814/review/252034093@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2814@github.com>
References: <quicwg/base-drafts/pull/2814@github.com>
Subject: Re: [quicwg/base-drafts] Rationalize HTTP_WRONG_SETTING_DIRECTION (#2814)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0ad46c48e04_74ec3fdc898cd96c897d7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/iVMVrxgQ11yDaoj-OFmNSVEk6Y4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Jun 2019 00:33:51 -0000

kazuho commented on this pull request.



> @@ -1664,9 +1664,10 @@ HTTP_UNEXPECTED_FRAME (0x0013):
 HTTP_REQUEST_REJECTED (0x0014):
 : A server rejected a request without performing any application processing.
 
-HTTP_GENERAL_PROTOCOL_ERROR (0x00FF):
-: Peer violated protocol requirements in a way which doesn't match a more
-  specific error code, or endpoint declines to use the more specific error code.
+HTTP_SETTINGS_ERROR (0x00FF):
+: An endpoint detected an error with a SETTINGS frame: a duplicate setting was

Maybe "detected an error _in the payload of_ a SETTINGS frame"?

I suggest this assuming that HTTP_MALFORMED_FRAME is the error code to be used when seeing a badly-formatted SETTINGS frame (for example a SETTINGS frame carrying one byte of data: 0xff).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2814#pullrequestreview-252034093

v2.23.0 | Report a Bug | By Email