Re: [quicwg/base-drafts] Merge Crypto timeout and PTO (#2806)

Matt Olson <notifications@github.com> Wed, 19 June 2019 22:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C5DB3120134 for <quic-issues@ietfa.amsl.com>; Wed, 19 Jun 2019 15:53:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.008
X-Spam-Level:
X-Spam-Status: No, score=-8.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MxR8B5HFnDVY for <quic-issues@ietfa.amsl.com>; Wed, 19 Jun 2019 15:53:15 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 307741202E7 for <quic-issues@ietf.org>; Wed, 19 Jun 2019 15:53:15 -0700 (PDT)
Date: Wed, 19 Jun 2019 15:53:13 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560984793; bh=zi0zg+vdaJHgw1gZrDlQpafD8lGxh+x+V8fmXuasPm0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yjfZwO2tYDuUwG2Fspp9CE/GUWn3mi13ElEy1Ht1LQvRm13fNuW0a7UpJJ4/B8xyL kR2E456s2hx5g0xAbDxMFMzlvdyuDepwRUFHXXc6KXXW8eK6UwpdlA3tvDAQZO9EN5 XMJ5rHoFAKoMK+Xp5mDpa7XPM01YVr+0eTWw8lcQ=
From: Matt Olson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4GXDIWGSMR4VZYEMF3C7XVTEVBNHHBWSJPJ4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2806/review/252010535@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2806@github.com>
References: <quicwg/base-drafts/pull/2806@github.com>
Subject: Re: [quicwg/base-drafts] Merge Crypto timeout and PTO (#2806)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0abcd9d65d6_23303ff2ad8cd964162881"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: maolson-msft
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/L0Jerk4ZGhv9Xw17GUhZH3NDQIQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jun 2019 22:53:18 -0000

maolson-msft commented on this pull request.



> +
+A connection MAY use the delay between sending a PATH_CHALLENGE and receiving
+a PATH_RESPONSE to seed initial_rtt for a new path, but the delay SHOULD NOT
+be considered an RTT sample.
+
+Until the server has validated the client's address on the path, the amount of
+data it can send is limited, as specified in Section 8.1 of {{QUIC-TRANSPORT}}.
+If not all unacknowledged CRYPTO data can be sent, then all unacknowledged
+CRYPTO data sent in Initial packets should be retransmitted.  If no data can be
+sent, then no alarm should be armed until data has been received from the
+client.
+
+Because the server could be blocked until more packets are received, the client
+MUST ensure that the retransmission timer is set if there is
+unacknowledged crypto data or if the client does not yet have 1-RTT keys.
+If the retransmission timer expires before the client has 1-RTT keys,

```suggestion
If the probe timer expires before the client has 1-RTT keys,
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2806#pullrequestreview-252010535