Re: [quicwg/base-drafts] Merge Crypto timeout and PTO (#2806)

[ianswett <[e-mail]>]

ianswett commented on this pull request.



> @@ -543,49 +544,46 @@ delay sending an acknowledgement.
 The PTO value MUST be set to at least kGranularity, to avoid the timer expiring
 immediately.
 
-When a PTO timer expires, the sender probes the network as described in the next
-section. The PTO period MUST be set to twice its current value. This exponential
-reduction in the sender's rate is important because the PTOs might be caused by
-loss of packets or acknowledgements due to severe congestion.
+When a PTO timer expires, the PTO period MUST be set to twice its current
+value. This exponential reduction in the sender's rate is important because
+the PTOs might be caused by loss of packets or acknowledgements due to severe
+congestion.
 

TCP clamps to a value(typically 30 seconds), but I think it's better to recommend a dead path timeout, such as a limit on the number of successive PTOs(I think some TCP impls default to 7?).

> @@ -1283,7 +1237,7 @@ OnLossDetectionTimeout():
        SendOneHandshakePacket()
      else:
        SendOnePaddedInitialPacket()
-    crypto_count++
+    pto_count++

You're correct, the else is off.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2806#discussion_r301290467