Re: [quicwg/base-drafts] Merge Crypto timeout and PTO (#2806)

ianswett <> Mon, 08 July 2019 20:45 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 887141202AE for <>; Mon, 8 Jul 2019 13:45:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id Vb58bee5DoK4 for <>; Mon, 8 Jul 2019 13:44:58 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 2CFAF12014B for <>; Mon, 8 Jul 2019 13:44:58 -0700 (PDT)
Date: Mon, 08 Jul 2019 13:44:56 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1562618696; bh=CcOOnNZxjRQYRMpwRsRb6ZHpxP/OjSgr6J/lB/MnEpc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FjTWMbj46t+Hm6PEgKp4wbisvnAIPuTHTDewGPP7Sc4WZUZC48aGCfmSsbY+H4cYV 7WTryaTtqmD8j0OQxzrzVGbTPz3tlDQ3K6DdLegLs0UZo7TukXCBjoCh/TOYPjjlMU hWXCRJRHaS1L9x/ord2joOX1hNeLpFW6yX21j3G8=
From: ianswett <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2806/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Merge Crypto timeout and PTO (#2806)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d23ab48c6859_118c3ff919ecd9641738897"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Mon, 08 Jul 2019 20:45:09 -0000

ianswett commented on this pull request.

> @@ -543,49 +544,46 @@ delay sending an acknowledgement.
 The PTO value MUST be set to at least kGranularity, to avoid the timer expiring
-When a PTO timer expires, the sender probes the network as described in the next
-section. The PTO period MUST be set to twice its current value. This exponential
-reduction in the sender's rate is important because the PTOs might be caused by
-loss of packets or acknowledgements due to severe congestion.
+When a PTO timer expires, the PTO period MUST be set to twice its current
+value. This exponential reduction in the sender's rate is important because
+the PTOs might be caused by loss of packets or acknowledgements due to severe

TCP clamps to a value(typically 30 seconds), but I think it's better to recommend a dead path timeout, such as a limit on the number of successive PTOs(I think some TCP impls default to 7?).

> @@ -1283,7 +1237,7 @@ OnLossDetectionTimeout():
-    crypto_count++
+    pto_count++

You're correct, the else is off.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: