IETF Logo Mail Archive

Re: [quicwg/base-drafts] Rationalize HTTP_WRONG_SETTING_DIRECTION (#2814)

Lucas Pardue <notifications@github.com> Wed, 19 June 2019 17:34 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E2FCE12065A for <quic-issues@ietfa.amsl.com>; Wed, 19 Jun 2019 10:34:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.605
X-Spam-Level:
X-Spam-Status: No, score=-6.605 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R8up8PA7P0YS for <quic-issues@ietfa.amsl.com>; Wed, 19 Jun 2019 10:34:09 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 007451205DB for <quic-issues@ietf.org>; Wed, 19 Jun 2019 10:34:08 -0700 (PDT)
Date: Wed, 19 Jun 2019 10:34:07 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560965647; bh=7qzmtU1+SA7ZPJSxoLupQOFY5gqWkU2mYmrvJslGNZo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=BhjFQZ+IDGO8OI3c19ex4YPjQMERWNyCwn764qNS5UkySLqlYf3EVTH9VrUdBI+Rv GpGTL7eTC2NL2HSC6P9wFGSJqnYfwjNsV+F3cQnKh8R+sYLbriAHmymSGgmf2lkn8K bdX20MNpQHnXbWoWhDRZkkjC2M2gmXNdB3rQcHpI=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4SST5KYBHQ7VU6HHF3C6SI7EVBNHHBWTCMKQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2814/review/251857026@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2814@github.com>
References: <quicwg/base-drafts/pull/2814@github.com>
Subject: Re: [quicwg/base-drafts] Rationalize HTTP_WRONG_SETTING_DIRECTION (#2814)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0a720fa3fd2_37323ff1406cd95c7551f7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uYP4nz_N8cW87ta3gZlz60F3Hlw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jun 2019 17:34:11 -0000

LPardue commented on this pull request.



> @@ -1595,9 +1595,10 @@ HTTP_NO_ERROR (0x00):
 : No error.  This is used when the connection or stream needs to be closed, but
   there is no error to signal.
 
-HTTP_WRONG_SETTING_DIRECTION (0x01):
-: A client-only setting was sent by a server, or a server-only setting by a
-  client.
+HTTP_SETTINGS_ERROR (0x01):
+: An endpoint detected an error with a SETTINGS frame: a duplicate setting was
+  detected, a client-only setting was sent by a server, or a server-only setting
+  by a client.

That was my initial intention but I thought it might make life harder. However, life is hard regardless so I'll try it out.

> (Also, I just noticed that GPE is missing from the IANA table.)

You reminded me that I fixed this on the MALFORMED_FRAME PR. It makes sense to fix that here though while shuffling things around.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2814#discussion_r295420052

v2.23.0 | Report a Bug | By Email