Re: [quicwg/base-drafts] Remove duplicated CONNECTION_CLOSE rules (#3295)

Jana Iyengar <notifications@github.com> Wed, 11 December 2019 03:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EAE6412006B for <quic-issues@ietfa.amsl.com>; Tue, 10 Dec 2019 19:29:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ontKBYUTsy4O for <quic-issues@ietfa.amsl.com>; Tue, 10 Dec 2019 19:29:20 -0800 (PST)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 47714120059 for <quic-issues@ietf.org>; Tue, 10 Dec 2019 19:29:20 -0800 (PST)
Date: Tue, 10 Dec 2019 19:29:19 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1576034959; bh=ajWi8fXt7xVxFLaelteRdYU0w+uFs9fu1QePagS2P6c=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LWTYl6T/eoxIjy9Z2DNHnCCaybSAbY3bq8JEoN2Fs1O9avDwnRTZ5l57rMlIlpLy3 x7fdCMIrrl3Gvl85++i5I37oz+TWSNgLFvKQxZ5NVQDATvGJKg5WLU+4fZUvV9iE7X p+1Bt5v+IC1cj0vWkXt1VgOS7o7IsE5ukjlPX21U=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6HJUF7EPD7MXGN7C537WKQ7EVBNHHB744Z4E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3295/review/330279718@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3295@github.com>
References: <quicwg/base-drafts/pull/3295@github.com>
Subject: Re: [quicwg/base-drafts] Remove duplicated CONNECTION_CLOSE rules (#3295)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5df0628f58d03_5d513fc8624cd96013428a"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6GP-v1OyQoRR6QfJUVblaKVMvI4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Dec 2019 03:29:22 -0000

janaiyengar commented on this pull request.



> @@ -2489,7 +2483,8 @@ least one of them is processable by the client.  Similarly, a peer might be
 unable to read 1-RTT packets, so an endpoint SHOULD send CONNECTION_CLOSE in
 Handshake and 1-RTT packets prior to confirming the handshake; see Section 4.1.2
 of {{QUIC-TLS}}.  These packets can be coalesced into a single UDP datagram; see
-{{packet-coalesce}}.
+{{packet-coalesce}}.  After the handshake is confirmed, an endpoint MUST send

```suggestion
{{packet-coalesce}}.

After the handshake is confirmed, an endpoint MUST send
```

> @@ -2489,7 +2483,8 @@ least one of them is processable by the client.  Similarly, a peer might be
 unable to read 1-RTT packets, so an endpoint SHOULD send CONNECTION_CLOSE in
 Handshake and 1-RTT packets prior to confirming the handshake; see Section 4.1.2
 of {{QUIC-TLS}}.  These packets can be coalesced into a single UDP datagram; see
-{{packet-coalesce}}.
+{{packet-coalesce}}.  After the handshake is confirmed, an endpoint MUST send

I would also suggest moving this up to the earlier para after the sentence "Generally, this means sending the frame in a packet with the highest level of packet protection to avoid the packet being discarded.". Then, change the beginning of the next sentence to "However, prior to handshake confirmation ...".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3295#pullrequestreview-330279718